Skip to contentSkip to conversation

package/smartmontools: bump to version 7.0

PATCH New Christopher McCrory 2 participants 3 messages Sep 8, 2019 – Sep 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 15/27 package/smartmontools: bump to version 7.0

Add work around for broken configure check

---
 package/smartmontools/smartmontools.hash | 6 +++---
 package/smartmontools/smartmontools.mk   | 7 ++++++-
 2 files changed, 9 insertions(+), 4 deletions(-)
package/smartmontools/smartmontools.hash +3 -3
index 2f2b7aa096..b36681eb4e 100644
@@ -1,3 +1,3 @@
-# From http://sourceforge.net/projects/smartmontools/files/smartmontools/6.5/
-md5	093aeec3f8f39fa9a37593c4012d3156	smartmontools-6.5.tar.gz
-sha1	7e788b429534a4ae627858fbcc826b93402cee7e	smartmontools-6.5.tar.gz
+# Locally calculated
+sha256 e5e1ac2786bc87fdbd6f92d0ee751b799fbb3e1a09c0a6a379f9eb64b3e8f61c smartmontools-7.0.tar.gz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING
package/smartmontools/smartmontools.mk +6 -1
index 137c00a505..36b9c39243 100644
@@ -4,9 +4,14 @@
 #
 ################################################################################
 
-SMARTMONTOOLS_VERSION = 6.5
+SMARTMONTOOLS_VERSION = 7.0
 SMARTMONTOOLS_SITE = http://downloads.sourceforge.net/project/smartmontools/smartmontools/$(SMARTMONTOOLS_VERSION)
 SMARTMONTOOLS_LICENSE = GPL-2.0+
 SMARTMONTOOLS_LICENSE_FILES = COPYING
 
+# Work around broken configure check.
+ifneq ($(BR2_TOOLCHAIN_HAS_SSP),y)
+SMARTMONTOOLS_CONF_OPTS += CXXFLAGS="$(TARGET_CXXFLAGS) -fno-stack-protector"
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 15/27 package/smartmontools: bump to version 7.0

Hello Christopher,

package/smartmontools/smartmontools.mk line 15

Quoted 4 lines · On Sun, 8 Sep 2019 09:11:59 -0700 Christopher McCrory <[email protected]>…
package/smartmontools/smartmontools.mk +4 -0
+# Work around broken configure check.
+ifneq ($(BR2_TOOLCHAIN_HAS_SSP),y)
+SMARTMONTOOLS_CONF_OPTS += CXXFLAGS="$(TARGET_CXXFLAGS) -fno-stack-protector"
+endif

Could you instead fix the configure.ac, by using AC_LINK_IFELSE() instead of AC_COMPILE_IFELSE() to check for the availability of -fstack-protector ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 15/27 package/smartmontools: bump to version 7.0

My free time comes and goes. I should have some free time mid week to give it a shot

Quoted 15 lines · Thomas Petazzoni

Hello Christopher,

package/smartmontools/smartmontools.mk

Quoted 3 lines · On Sun, 8 Sep 2019 09:11:59 -0700 Christopher McCrory <[email protected]>…
package/smartmontools/smartmontools.mk +3 -0
+# Work around broken configure check.
+ifneq ($(BR2_TOOLCHAIN_HAS_SSP),y)
+SMARTMONTOOLS_CONF_OPTS += CXXFLAGS="$(TARGET_CXXFLAGS)

-fno-stack-protector"

Quoted 1 line

+endif

Could you instead fix the configure.ac, by using AC_LINK_IFELSE() instead of AC_COMPILE_IFELSE() to check for the availability of -fstack-protector ?

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190915/25064bb3/attachment.html>