Skip to contentSkip to conversation

net/wan: dscc4: remove broken dscc4 driver

PATCH Applied Dan Carpenter 3 participants 3 messages Sep 13, 2019 – Sep 16, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/wan: dscc4: remove broken dscc4 driver

Using static analysis, I discovered that the "dpriv->pci_priv->pdev" pointer is always NULL. This pointer was supposed to be initialized during probe and is essential for the driver to work. It would be easy to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has been broken since before we started using git and no one has complained so probably we should just remove it.

---
 MAINTAINERS              |    6 -
 drivers/net/wan/Kconfig  |   14 -
 drivers/net/wan/Makefile |    1 -
 drivers/net/wan/dscc4.c  | 2057 --------------------------------------
 4 files changed, 2078 deletions(-)
 delete mode 100644 drivers/net/wan/dscc4.c
MAINTAINERS +0 -6
index ee4e873c0f9a..731fb91aa836 100644
@@ -5602,12 +5602,6 @@ T:	git git://linuxtv.org/media_tree.git
 S:	Maintained
 F:	drivers/media/radio/dsbr100.c
 
-DSCC4 DRIVER
-M:	Francois Romieu <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/net/wan/dscc4.c
-
 DT3155 MEDIA DRIVER
 M:	Hans Verkuil <[email protected]>
 L:	[email protected]
drivers/net/wan/Kconfig +0 -14
index 09fdd619ac67..dd1a147f2971 100644
@@ -267,20 +267,6 @@ config FARSYNC
 	  To compile this driver as a module, choose M here: the
 	  module will be called farsync.
 
-config DSCC4
-	tristate "Etinc PCISYNC serial board support"
-	depends on HDLC && PCI && m
-	help
-	  Driver for Etinc PCISYNC boards based on the Infineon (ex. Siemens)
-	  DSCC4 chipset.
-
-	  This is supposed to work with the four port card. Take a look at
-	  <http://www.cogenit.fr/dscc4/> for further information about the
-	  driver.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called dscc4.
-
 config FSL_UCC_HDLC
 	tristate "Freescale QUICC Engine HDLC support"
 	depends on HDLC
drivers/net/wan/Makefile +0 -1
index 9532e69fda87..701f5d2fe3b6 100644
@@ -18,7 +18,6 @@ obj-$(CONFIG_HOSTESS_SV11)	+= z85230.o	hostess_sv11.o
 obj-$(CONFIG_SEALEVEL_4021)	+= z85230.o	sealevel.o
 obj-$(CONFIG_COSA)		+= cosa.o
 obj-$(CONFIG_FARSYNC)		+= farsync.o
-obj-$(CONFIG_DSCC4)             += dscc4.o
 obj-$(CONFIG_X25_ASY)		+= x25_asy.o
 
 obj-$(CONFIG_LANMEDIA)		+= lmc/
drivers/net/wan/dscc4.c deleted +0 -2056

2,056 lines not on this page · raw message

Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw

Dan Carpenter <[email protected]> :

Quoted 8 lines

Using static analysis, I discovered that the "dpriv->pci_priv->pdev" pointer is always NULL. This pointer was supposed to be initialized during probe and is essential for the driver to work. It would be easy to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has been broken since before we started using git and no one has complained so probably we should just remove it.

Signature · 1 line
Ueimor
maintainer Applied
#2 lore raw
In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Fri, 13 Sep 2019 16:28:17 +0300

Quoted 8 lines

Using static analysis, I discovered that the "dpriv->pci_priv->pdev" pointer is always NULL. This pointer was supposed to be initialized during probe and is essential for the driver to work. It would be easy to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has been broken since before we started using git and no one has complained so probably we should just remove it.

Applied to net-next.