Skip to contentSkip to conversation

config: set RTE_KNI_PREEMPT_DEFAULT in meson

PATCH Applied Igor Ryzhov 3 participants 4 messages Sep 16, 2019 – Oct 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config: set RTE_KNI_PREEMPT_DEFAULT in meson

Same behavior as in make build system.

---
 config/rte_config.h | 3 +++
 1 file changed, 3 insertions(+)
config/rte_config.h +3 -0
index 0bbbe274f..e6a35a170 100644
@@ -98,6 +98,9 @@
 #define RTE_SCHED_PORT_N_GRINDERS 8
 #undef RTE_SCHED_VECTOR
 
+/* rte_kni defines */
+#define RTE_KNI_PREEMPT_DEFAULT 1
+
 /****** driver defines ********/
 
 /* QuickAssist device */
Signature · 1 line
2.23.0
#1 lore raw

CCing Bruce, maintainer of the meson build system.

It's a simple patch to make meson behavior consistent with make behavior.

CONFIG_RTE_KNI_PREEMPT_DEFAULT is set to "y" in config/common_base, so we need to set RTE_KNI_PREEMPT_DEFAULT to 1 in meson.

Best regards,
Igor

Quoted 25 lines · Igor Ryzhov

Same behavior as in make build system.

---
 config/rte_config.h | 3 +++
 1 file changed, 3 insertions(+)
config/rte_config.h +3 -1
index 0bbbe274f..e6a35a170 100644
@@ -98,6 +98,9 @@
 #define RTE_SCHED_PORT_N_GRINDERS 8
 #undef RTE_SCHED_VECTOR
 
+/* rte_kni defines */
+#define RTE_KNI_PREEMPT_DEFAULT 1
+
 /****** driver defines ********/
 
 /* QuickAssist device */
--

2.23.0

#2 lore raw
Quoted 8 lines · Igor Ryzhov

CCing Bruce, maintainer of the meson build system.
It's a simple patch to make meson behavior consistent with make behavior.
CONFIG_RTE_KNI_PREEMPT_DEFAULT is set to "y" in config/common_base, so we need to set RTE_KNI_PREEMPT_DEFAULT to 1 in meson. Best regards,
Igor

No objection from me.

Quoted 27 lines
   On Mon, Sep 16, 2019 at 1:08 PM Igor Ryzhov <[1][email protected]>
   wrote:

     Same behavior as in make build system.
     Signed-off-by: Igor Ryzhov <[2][email protected]>
     ---
      config/rte_config.h | 3 +++
      1 file changed, 3 insertions(+)
     diff --git a/config/rte_config.h b/config/rte_config.h
     index 0bbbe274f..e6a35a170 100644
     --- a/config/rte_config.h
     +++ b/config/rte_config.h
     @@ -98,6 +98,9 @@
      #define RTE_SCHED_PORT_N_GRINDERS 8
      #undef RTE_SCHED_VECTOR
     +/* rte_kni defines */
     +#define RTE_KNI_PREEMPT_DEFAULT 1
     +
      /****** driver defines ********/
      /* QuickAssist device */
     --
     2.23.0

References

1. mailto:[email protected]
2. mailto:[email protected]

#3 lore raw

18/09/2019 12:32, Bruce Richardson:

Quoted 9 lines · Igor Ryzhov
Quoted 8 lines

CCing Bruce, maintainer of the meson build system.
It's a simple patch to make meson behavior consistent with make behavior.
CONFIG_RTE_KNI_PREEMPT_DEFAULT is set to "y" in config/common_base, so we need to set RTE_KNI_PREEMPT_DEFAULT to 1 in meson. Best regards,
Igor

Quoted 3 lines

No objection from me.

Applied, thanks