Skip to contentSkip to conversation

drm/amdkfd: Delete unused KFD_IS_DGPU macro

PATCH In review Zhao, Yong 2 participants 2 messages Sep 16, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Zhao, Yong

author
#0 lore raw

PATCH 1/1 drm/amdkfd: Delete unused KFD_IS_DGPU macro

This was deleted before, but somehow showed up again. Delete it again.

Change-Id I19b3063932380cb74a01d505e8e92f897a2c2cb7
---
 drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_priv.h +0 -3
index 06bb2d7a9b39..6ed31a76dfda 100644
@@ -180,9 +180,6 @@ enum cache_policy {
 };
 
 #define KFD_IS_VI(chip) ((chip) >= CHIP_CARRIZO && (chip) <= CHIP_POLARIS11)
-#define KFD_IS_DGPU(chip) (((chip) >= CHIP_TONGA && \
-			   (chip) <= CHIP_NAVI10) || \
-			   (chip) == CHIP_HAWAII)
 #define KFD_IS_SOC15(chip) ((chip) >= CHIP_VEGA10)
 
 struct kfd_event_interrupt_class {
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 13 lines · On 2019-09-16 12:26 p.m., wrote:

This was deleted before, but somehow showed up again. Delete it again.

Change-Id I19b3063932380cb74a01d505e8e92f897a2c2cb7
---
  drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 ---
  1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_priv.h +0 -0
index 06bb2d7a9b39..6ed31a76dfda 100644

drivers/gpu/drm/amd/amdkfd/kfd_priv.h enum cache_policy { · line 185

Quoted 6 lines
drivers/gpu/drm/amd/amdkfd/kfd_priv.h +0 -3
@@ -180,9 +180,6 @@ enum cache_policy {
  };
 
  #define KFD_IS_VI(chip) ((chip) >= CHIP_CARRIZO && (chip) <= CHIP_POLARIS11)
-#define KFD_IS_DGPU(chip) (((chip) >= CHIP_TONGA && \
-			   (chip) <= CHIP_NAVI10) || \
-			   (chip) == CHIP_HAWAII)

Are you familiar with "git blame"? It's really useful to track down which commit introduced code. In this case it shows that both IS_DGPU and IS_VI were added back by Philip Cox in his Navi10 change, probably accidentally while resolving a rebase conflict. You can probably remove IS_VI as well.

Regards,
  Felix

drivers/gpu/drm/amd/amdkfd/kfd_priv.h enum cache_policy { · line 185

Quoted 3 lines
drivers/gpu/drm/amd/amdkfd/kfd_priv.h +0 -0
  #define KFD_IS_SOC15(chip) ((chip) >= CHIP_VEGA10)
 
  struct kfd_event_interrupt_class {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx