Skip to contentSkip to conversation

drm/amd/display: memory leak

PATCH Applied Navid Emamdoost 2 participants 3 messages Sep 17, 2019 – Oct 2, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: memory leak

In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated clk_src needs release.

---
 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++-
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c   | 1 +
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c   | 1 +
 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c   | 1 +
 7 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +2 -1
index 6248c8455314..21de230b303a 100644
@@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create(
 		clk_src->base.dp_clk_src = dp_clk_src;
 		return &clk_src->base;
 	}
-
+
+	kfree(clk_src);
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -0
index 764329264c3b..0cb83b0e0e1e 100644
@@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create(
 		return &clk_src->base;
 	}
 
+	kfree(clk_src);
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -0
index c6136e0ed1a4..147d77173e2b 100644
@@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create(
 		return &clk_src->base;
 	}
 
+	kfree(clk_src);
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -0
index 4a6ba3173a5a..0b5eeff17d00 100644
@@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create(
 		return &clk_src->base;
 	}
 
+	kfree(clk_src);
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +1 -0
index 860a524ebcfa..952440893fbb 100644
@@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create(
 		return &clk_src->base;
 	}
 
+	kfree(clk_src);
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +1 -0
index a12530a3ab9c..3f25e8da5396 100644
@@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create(
 		return &clk_src->base;
 	}
 
+	kfree(clk_src);
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +1 -0
index b949e202d6cb..418fdcf1f492 100644
@@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create(
 		return &clk_src->base;
 	}
 
+	kfree(clk_src)
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
Signature · 1 line
2.17.1
#1 lore raw

Would you please review this patch?

Thanks,
Navid.

Quoted 104 lines · Navid Emamdoost

In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated clk_src needs release.

---
 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++-
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c   | 1 +
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c   | 1 +
 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c   | 1 +
 7 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +2 -1
index 6248c8455314..21de230b303a 100644
@@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create(
                clk_src->base.dp_clk_src = dp_clk_src;
                return &clk_src->base;
        }
-
+
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -0
index 764329264c3b..0cb83b0e0e1e 100644
@@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -0
index c6136e0ed1a4..147d77173e2b 100644
@@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -0
index 4a6ba3173a5a..0b5eeff17d00 100644
@@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +1 -0
index 860a524ebcfa..952440893fbb 100644
@@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +1 -0
index a12530a3ab9c..3f25e8da5396 100644
@@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +1 -1
index b949e202d6cb..418fdcf1f492 100644
@@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src)
        BREAK_TO_DEBUGGER();
        return NULL;
 }
--

2.17.1

Signature · 1 line
Navid.
Applied
#2 lore raw
Quoted 3 lines · Navid Emamdoost

Would you please review this patch?

Applied. thanks!

Alex

Quoted 103 lines

Thanks,
Navid.

Quoted 97 lines · Navid Emamdoost

In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated clk_src needs release.

---
 drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++-
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 +
 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c   | 1 +
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c   | 1 +
 drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c   | 1 +
 7 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +2 -1
index 6248c8455314..21de230b303a 100644
@@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create(
                clk_src->base.dp_clk_src = dp_clk_src;
                return &clk_src->base;
        }
-
+
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -0
index 764329264c3b..0cb83b0e0e1e 100644
@@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -0
index c6136e0ed1a4..147d77173e2b 100644
@@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -0
index 4a6ba3173a5a..0b5eeff17d00 100644
@@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +1 -0
index 860a524ebcfa..952440893fbb 100644
@@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +1 -0
index a12530a3ab9c..3f25e8da5396 100644
@@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +0 -0
index b949e202d6cb..418fdcf1f492 100644
@@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create(
                return &clk_src->base;
        }
 
Quoted 15 lines
Quoted 7 lines
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +1 -1
+       kfree(clk_src)
        BREAK_TO_DEBUGGER();
        return NULL;
 }
--

2.17.1

--
Navid.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx