drm/amd/display: memory leak
Subsystems (3)
PATCH 1/1 drm/amd/display: memory leak
In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated clk_src needs release.
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + 7 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +2 -1
@@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create( clk_src->base.dp_clk_src = dp_clk_src;return &clk_src->base; } - + +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -0
@@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -0
@@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -0
@@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +1 -0
@@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +1 -0
@@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +1 -0
@@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create(return &clk_src->base; } +kfree (clk_src)BREAK_TO_DEBUGGER ();return NULL ; }
Signature · 1 line
2.17.1
Would you please review this patch?
Thanks,
Navid.
Quoted 104 lines · Navid Emamdoost
In dcn*_clock_source_create when
dcn20_clk_src_constructfails allocatedclk_srcneeds release.Signed-off-by Navid Emamdoost <[email protected]>--- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + 7 files changed, 8 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +2
-1@@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create( clk_src->base.dp_clk_src = dp_clk_src;return &clk_src->base; } - + +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1
-0@@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1
-0@@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1
-0@@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +1
-0@@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +1
-0@@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +1
-1@@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create(return &clk_src->base; } +kfree (clk_src)BREAK_TO_DEBUGGER ();return NULL ; } --2.17.1
Signature · 1 line
Navid.
Alex Deucher
AppliedQuoted 3 lines · Navid Emamdoost
Would you please review this patch?
Applied. thanks!
Alex
Quoted 103 lines
Thanks,
Navid.Quoted 97 lines · Navid Emamdoost
In dcn*_clock_source_create when
dcn20_clk_src_constructfails allocatedclk_srcneeds release.Signed-off-by Navid Emamdoost <[email protected]>--- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + 7 files changed, 8 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +2
-1@@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create( clk_src->base.dp_clk_src = dp_clk_src;return &clk_src->base; } - + +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1
-0@@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1
-0@@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1
-0@@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +1
-0@@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +1
-0@@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create(return &clk_src->base; } +kfree (clk_src);BREAK_TO_DEBUGGER ();return NULL ; }drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +0
-0@@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create(return &clk_src->base; }
Quoted 15 lines
Quoted 7 lines
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +1
-1+kfree (clk_src)BREAK_TO_DEBUGGER ();return NULL ; } --2.17.1
--
Navid.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx