Skip to contentSkip to conversation

tools/libs: Fix build following c/s 56dccee3f, take 2

PATCH In review Andrew Cooper 2 participants 2 messages Sep 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/libs: Fix build following c/s 56dccee3f, take 2

The fix for c/s 01ba8f62b618 was speculative given no local repro. It turns out that it didn't fix the problem.

The $(AUTOINCS) variable needs to be visible before libs.mk is included, to have any effect.

---
CC: Ian Jackson <[email protected]>
CC: Wei Liu <[email protected]>
CC: Juergen Gross <[email protected]>

---
 tools/libs/toolcore/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/libs/toolcore/Makefile +1 -2
index edce61dca4..9c5a92d93f 100644
@@ -4,6 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR	= 1
 MINOR	= 0
 LIBNAME  := toolcore
+AUTOINCS := include/_xentoolcore_list.h
 
 SRCS-y	+= handlereg.c
 
@@ -11,8 +12,6 @@ include $(XEN_ROOT)/tools/libs/libs.mk
 
 $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR = $(XEN_LIBXENTOOLCORE)/include
 
-AUTOINCS=include/_xentoolcore_list.h
-
 $(LIB_OBJS): $(AUTOINCS)
 $(PIC_OBJS): $(AUTOINCS)
 
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw

Andrew Cooper writes ("[PATCH] tools/libs: Fix build following c/s 56dccee3f, take 2"):

Quoted 5 lines

The fix for c/s 01ba8f62b618 was speculative given no local repro. It turns out that it didn't fix the problem.

The $(AUTOINCS) variable needs to be visible before libs.mk is included, to have any effect.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel