nvmet: change ppl to lpp
Subsystems (2)
PATCH 1/1 nvmet: change ppl to lpp
In nvmet_bdev_set_limits() the number of logical blocks per physical block is calculated, but the opposite is mentioned in the associated comment and reflected in the variable name. Correct the comment and adjust the variable name to reflect the calculation done.
--- drivers/nvme/target/io-cmd-bdev.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/nvme/target/io-cmd-bdev.c +8 -8
@@ -11,10 +11,10 @@void nvmet_bdev_set_limits (struct block_device *bdev,struct nvme_id_ns *id) {const struct queue_limits *ql = &bdev_get_queue (bdev)->limits; -/* Number of physical blocks per logical block. */ -const u32 ppl = ql->physical_block_size / ql->logical_block_size; -/* Physical blocks per logical block, 0's based. */ -const __le16 ppl0b =to0based (ppl); +/* Number of logical blocks per physical block. */ +const u32 lpp = ql->physical_block_size / ql->logical_block_size; +/* Logical blocks per physical block, 0's based. */ +const __le16 lpp0b =to0based (lpp);/* * For NVMe 1.2 and later, bit 1 indicates that the fields NAWUN,
@@ -25,9 +25,9 @@ void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id)* field from the identify controller data structure should be used. */ id->nsfeat |=1 <<1 ; - id->nawun = ppl0b; - id->nawupf = ppl0b; - id->nacwu = ppl0b; + id->nawun = lpp0b; + id->nawupf = lpp0b; + id->nacwu = lpp0b;/* * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and
@@ -36,7 +36,7 @@ void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id)*/ id->nsfeat |=1 <<4 ;/* NPWG = Namespace Preferred Write Granularity. 0's based */ - id->npwg = ppl0b; + id->npwg = lpp0b;/* NPWA = Namespace Preferred Write Alignment. 0's based */ id->npwa = id->npwg;/* NPDG = Namespace Preferred Deallocate Granularity. 0's based */
Signature · 7 lines
2.17.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 5 lines · John Pittman
In
nvmet_bdev_set_limits()the number of logical blocks per physical block is calculated, but the opposite is mentioned in the associated comment and reflected in the variable name. Correct the comment and adjust the variable name to reflect the calculation done.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Thanks for the fix, looks good to me.
Quoted 5 lines · John Pittman
In
nvmet_bdev_set_limits()the number of logical blocks per physical block is calculated, but the opposite is mentioned in the associated comment and reflected in the variable name. Correct the comment and adjust the variable name to reflect the calculation done.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme