Skip to contentSkip to conversation

dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

PATCH Superseded Maciej Falkowski 4 participants 7 messages Sep 12, 2019 – Sep 17, 2019 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/1 dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

Convert Samsung Image Rotator to newer dt-schema format.

---
v2:
- add required properties
- add proper commit recipients

---
 .../bindings/gpu/samsung-rotator.txt          | 28 ----------
 .../bindings/gpu/samsung-rotator.yaml         | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.txt
 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
Documentation/devicetree/bindings/gpu/samsung-rotator.txt deleted +0 -28
deleted file mode 100644
index 3aca2578da0b..000000000000
@@ -1,28 +0,0 @@
-* Samsung Image Rotator
-
-Required properties:
-  - compatible : value should be one of the following:
-	* "samsung,s5pv210-rotator" for Rotator IP in S5PV210
-	* "samsung,exynos4210-rotator" for Rotator IP in Exynos4210
-	* "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412
-	* "samsung,exynos5250-rotator" for Rotator IP in Exynos5250
-
-  - reg : Physical base address of the IP registers and length of memory
-	  mapped region.
-
-  - interrupts : Interrupt specifier for rotator interrupt, according to format
-		 specific to interrupt parent.
-
-  - clocks : Clock specifier for rotator clock, according to generic clock
-	     bindings. (See Documentation/devicetree/bindings/clock/exynos*.txt)
-
-  - clock-names : Names of clocks. For exynos rotator, it should be "rotator".
-
-Example:
-	rotator@12810000 {
-		compatible = "samsung,exynos4210-rotator";
-		reg = <0x12810000 0x1000>;
-		interrupts = <0 83 0>;
-		clocks = <&clock 278>;
-		clock-names = "rotator";
-	};
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +52 -0

52 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw
Quoted 4 lines · Maciej Falkowski

Convert Samsung Image Rotator to newer dt-schema format.

Just to make it clear, Marek's signed-off should appear for one of conditions:
- he contributed some source code to your patch,
- he took your patch, rebased, send by himself (not a case here, I think),
- he contributed significant ideas, although for this there is a "Co-developed-by" tag.

If someone made just review - add Reviewed-by. If someone suggested the patch - add Suggested-by.

Quoted 51 lines

---
v2:
- add required properties
- add proper commit recipients

---
 .../bindings/gpu/samsung-rotator.txt          | 28 ----------
 .../bindings/gpu/samsung-rotator.yaml         | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.txt
 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
Documentation/devicetree/bindings/gpu/samsung-rotator.txt deleted +0 -28
deleted file mode 100644
index 3aca2578da0b..000000000000
@@ -1,28 +0,0 @@
-* Samsung Image Rotator
-
-Required properties:
-  - compatible : value should be one of the following:
-	* "samsung,s5pv210-rotator" for Rotator IP in S5PV210
-	* "samsung,exynos4210-rotator" for Rotator IP in Exynos4210
-	* "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412
-	* "samsung,exynos5250-rotator" for Rotator IP in Exynos5250
-
-  - reg : Physical base address of the IP registers and length of memory
-	  mapped region.
-
-  - interrupts : Interrupt specifier for rotator interrupt, according to format
-		 specific to interrupt parent.
-
-  - clocks : Clock specifier for rotator clock, according to generic clock
-	     bindings. (See Documentation/devicetree/bindings/clock/exynos*.txt)
-
-  - clock-names : Names of clocks. For exynos rotator, it should be "rotator".
-
-Example:
-	rotator@12810000 {
-		compatible = "samsung,exynos4210-rotator";
-		reg = <0x12810000 0x1000>;
-		interrupts = <0 83 0>;
-		clocks = <&clock 278>;
-		clock-names = "rotator";
-	};
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +0 -0
new file mode 100644
index 000000000000..96afafe98388

Documentation/devicetree/bindings/gpu/samsung-rotator.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpu/samsung-rotator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Image Rotator

Thanks Maciej for working on this.

I am trying to make the names more consistent:
1. For Exynos bindings:
Samsung Exynos SoC xxx yyy zzz

2. For multiple SoCs (S3C, S5P, Exynos etc):
Samsung SoC xxx yyy zzz

Currently the names are mixture of legacy and new names. It is a nit-pick but makes all bindings look like a part of bigger effort, not bunch of patches done by random people. :)

If there are no objections, maybe you could change it to:
Samsung SoC Image Rotator

Documentation/devicetree/bindings/gpu/samsung-rotator.yaml line 18

Quoted 11 lines
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +11 -0
+
+maintainers:
+  - Inki Dae <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - "samsung,s5pv210-rotator"    # for Rotator IP in S5PV210
+      - "samsung,exynos4210-rotator" # for Rotator IP in Exynos4210
+      - "samsung,exynos4212-rotator" # for Rotator IP in Exynos4212/4412
+      - "samsung,exynos5250-rotator" # for Rotator IP in Exynos5250

The comments are duplicating the compatible, so skip them.

Documentation/devicetree/bindings/gpu/samsung-rotator.yaml line 28

Quoted 10 lines
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +10 -0
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    description: |
+      Clock specifier for rotator clock according to generic clock
+      bindings. (See Documentation/devicetree/bindings/clock/exynos*.txt)

Skip the description. Clocks property is a well-known binding.

Documentation/devicetree/bindings/gpu/samsung-rotator.yaml line 34

Quoted 6 lines
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +6 -0
+    maxItems: 1
+
+  clock-names:
+    items:
+    - const: rotator
+    maxItems: 1

I think there is no need to maxItems since all possible items are fixed.

Best regards,
Krzysztof

Quoted 21 lines
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +18 -0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+examples:
+  - |
+    rotator@12810000 {
+        compatible = "samsung,exynos4210-rotator";
+        reg = <0x12810000 0x1000>;
+        interrupts = <0 83 0>;
+        clocks = <&clock 278>;
+        clock-names = "rotator";
+    };
+
Signature · 1 line
2.17.1
#3 lore raw

Hi Krzysztof,

Quoted 9 lines · Krzysztof Kozlowski
Quoted 4 lines · Maciej Falkowski

Convert Samsung Image Rotator to newer dt-schema format.

Just to make it clear, Marek's signed-off should appear for one of conditions:
- he contributed some source code to your patch,
- he took your patch, rebased, send by himself (not a case here, I

Quoted 6 lines
    think),

- he contributed significant ideas, although for this there is a "Co-developed-by" tag.

If someone made just review - add Reviewed-by. If someone suggested the patch - add Suggested-by.

My signed-off here was added to mark that this patch is allowed to be submitted to the public mailing list, as I have required company permissions for such activity. It is not that uncommon that a given patch has more than one signed-off and still the main author has the first signed-off tag.

Quoted 1 line

...

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
#4 lore raw
Quoted 17 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski
Quoted 4 lines · Maciej Falkowski

Convert Samsung Image Rotator to newer dt-schema format.

Just to make it clear, Marek's signed-off should appear for one of conditions:
- he contributed some source code to your patch,
- he took your patch, rebased, send by himself (not a case here, I

    think),

- he contributed significant ideas, although for this there is a "Co-developed-by" tag.

Quoted 8 lines
Quoted 2 lines

If someone made just review - add Reviewed-by. If someone suggested the patch - add Suggested-by.

My signed-off here was added to mark that this patch is allowed to be submitted to the public mailing list, as I have required company permissions for such activity. It is not that uncommon that a given patch has more than one signed-off and still the main author has the first signed-off tag.

Thanks for explanations. If I understand correctly, your SoB appears because some internal Samsung rules. That is not what SoB is meant for:
https://elixir.bootlin.com/linux/v5.3-rc8/source/Documentation/process/submitting-patches.rst#L431
If you do not contributed to the patch, did not touch it (e.g. rebasing) and you are not sending it, then your SoB should not be there. It looks like the same madness with Kyungmin Park long time ago:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=for-next&id=6c6cf64b16438eac6da9a90412a82316ad196e7c
Every patch was marked with SoB even though he was not involved at all in the process.

That's not what kernel's SoB is for.

Best regards,
Krzysztof

#5 lore raw
Quoted 40 lines · Krzysztof Kozlowski
Quoted 17 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski
Quoted 4 lines · Maciej Falkowski

Convert Samsung Image Rotator to newer dt-schema format.

Just to make it clear, Marek's signed-off should appear for one of conditions:
- he contributed some source code to your patch,
- he took your patch, rebased, send by himself (not a case here, I

    think),

- he contributed significant ideas, although for this there is a "Co-developed-by" tag.

Quoted 8 lines
Quoted 2 lines

If someone made just review - add Reviewed-by. If someone suggested the patch - add Suggested-by.

My signed-off here was added to mark that this patch is allowed to be submitted to the public mailing list, as I have required company permissions for such activity. It is not that uncommon that a given patch has more than one signed-off and still the main author has the first signed-off tag.

Thanks for explanations. If I understand correctly, your SoB appears because some internal Samsung rules. That is not what SoB is meant for:
https://elixir.bootlin.com/linux/v5.3-rc8/source/Documentation/process/submitting-patches.rst#L431
If you do not contributed to the patch, did not touch it (e.g. rebasing) and you are not sending it, then your SoB should not be there. It looks like the same madness with Kyungmin Park long time ago:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=for-next&id=6c6cf64b16438eac6da9a90412a82316ad196e7c
Every patch was marked with SoB even though he was not involved at all in the process.

Quoted 1 line

That's not what kernel's SoB is for.

Ah, and if you meant that Maciej does not have the permissions to send the patches, then your SoB along with patch going through your account makes sense. Otherwise, adding your SoB and sending by Maciej, is a joke of company regulations. It means absolutely nothing and then strip it out.

Best regards,
Krzysztof

#6 lore raw

PATCH v3 1/1 dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

In reply to Krzysztof Kozlowski

Convert Samsung Image Rotator to newer dt-schema format.

---
v3:
- remove unneded comments and descriptions
- remove unneded maxItems field from clock-names property

---
 .../bindings/gpu/samsung-rotator.txt          | 28 -----------
 .../bindings/gpu/samsung-rotator.yaml         | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.txt
 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
Documentation/devicetree/bindings/gpu/samsung-rotator.txt deleted +0 -28
deleted file mode 100644
index 3aca2578da0b..000000000000
@@ -1,28 +0,0 @@
-* Samsung Image Rotator
-
-Required properties:
-  - compatible : value should be one of the following:
-	* "samsung,s5pv210-rotator" for Rotator IP in S5PV210
-	* "samsung,exynos4210-rotator" for Rotator IP in Exynos4210
-	* "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412
-	* "samsung,exynos5250-rotator" for Rotator IP in Exynos5250
-
-  - reg : Physical base address of the IP registers and length of memory
-	  mapped region.
-
-  - interrupts : Interrupt specifier for rotator interrupt, according to format
-		 specific to interrupt parent.
-
-  - clocks : Clock specifier for rotator clock, according to generic clock
-	     bindings. (See Documentation/devicetree/bindings/clock/exynos*.txt)
-
-  - clock-names : Names of clocks. For exynos rotator, it should be "rotator".
-
-Example:
-	rotator@12810000 {
-		compatible = "samsung,exynos4210-rotator";
-		reg = <0x12810000 0x1000>;
-		interrupts = <0 83 0>;
-		clocks = <&clock 278>;
-		clock-names = "rotator";
-	};
Documentation/devicetree/bindings/gpu/samsung-rotator.yaml new file +48 -0

48 lines not on this page · raw message

Signature · 1 line
2.17.1
maintainer Applied
#7 lore raw
Quoted 8 lines · Maciej Falkowski

Convert Samsung Image Rotator to newer dt-schema format.

---
v3:
- remove unneded comments and descriptions
- remove unneded maxItems field from clock-names property

Quoted 7 lines
---
 .../bindings/gpu/samsung-rotator.txt          | 28 -----------
 .../bindings/gpu/samsung-rotator.yaml         | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.txt
 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-rotator.yaml

Applied, thanks.

Rob