drm/amdgpu/psp: flush HDP write fifo after submitting cmds to the psp
Subsystems (2)
PATCH 1/2 drm/amdgpu/psp: flush HDP write fifo after submitting cmds to the psp
We need to make sure the fifo is flushed before we ask the psp to process the commands.
--- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 1 + 4 files changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/psp_v10_0.c +1 -0
@@ -266,6 +266,7 @@ static int psp_v10_0_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +1 -0
@@ -549,6 +549,7 @@ static int psp_v11_0_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
drivers/gpu/drm/amd/amdgpu/psp_v12_0.c +1 -0
@@ -378,6 +378,7 @@ static int psp_v12_0_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +1 -0
@@ -454,6 +454,7 @@ static int psp_v3_1_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190917202046.26634-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
PATCH 2/2 drm/amdgpu/psp: invalidate the hdp read cache before reading the psp response
Otherwise we may get stale data.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -0
@@ -151,10 +151,12 @@ psp_cmd_submit_buf(struct psp_context *psp,return ret; } +amdgpu_asic_invalidate_hdp (psp->adev,NULL );while (*((unsigned int *)psp->fence_buf) != index) {if (--timeout ==0 )break ;msleep (1 ); +amdgpu_asic_invalidate_hdp (psp->adev,NULL ); }/* In some cases, psp response status is not 0 even there is no
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190917202046.26634-2-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Xu, Feifei
Reviewed-by Feifei XuRE: [PATCH 2/2] drm/amdgpu/psp: invalidate the hdp read cache before reading the psp response
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Wednesday, September 18, 2019 4:21 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH 2/2] drm/amdgpu/psp: invalidate the hdp read cache before reading the psp response
Otherwise we may get stale data.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -0
@@ -151,10 +151,12 @@ psp_cmd_submit_buf(struct psp_context *psp,return ret; } +amdgpu_asic_invalidate_hdp (psp->adev,NULL );while (*((unsigned int *)psp->fence_buf) != index) {if (--timeout ==0 )break ;msleep (1 ); +amdgpu_asic_invalidate_hdp (psp->adev,NULL ); }/* In some cases, psp response status is not 0 even there is no
Signature · 10 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Xu, Feifei
Reviewed-by Feifei Xu-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Wednesday, September 18, 2019 4:21 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH 1/2] drm/amdgpu/psp: flush HDP write fifo after submitting cmds to the psp
We need to make sure the fifo is flushed before we ask the psp to process the commands.
--- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 1 + 4 files changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/psp_v10_0.c +1 -0
@@ -266,6 +266,7 @@ static int psp_v10_0_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw; diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index 64802e88a9a2..04318cfd50a8 100644
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +1 -0
@@ -549,6 +549,7 @@ static int psp_v11_0_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw; diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
index c72e43f8e0be..8f553f6f92d6 100644
drivers/gpu/drm/amd/amdgpu/psp_v12_0.c +1 -0
@@ -378,6 +378,7 @@ static int psp_v12_0_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw; diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
index d2c727f6a8bd..fdc00938327b 100644
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +1 -0
@@ -454,6 +454,7 @@ static int psp_v3_1_cmd_submit(struct psp_context *psp, write_frame->fence_addr_hi =upper_32_bits (fence_mc_addr); write_frame->fence_addr_lo =lower_32_bits (fence_mc_addr); write_frame->fence_value = index; +amdgpu_asic_flush_hdp (adev,NULL );/* Update the write Pointer in DWORDs */ psp_write_ptr_reg = (psp_write_ptr_reg + rb_frame_size_dw) % ring_size_dw;
--
2.20.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx