package/webkitgtk: add missing host-perl dependency
PATCH 1/1 package/webkitgtk: add missing host-perl dependency
Fixes:
http://autobuild.buildroot.net/results/faa23c0e648b916d0fb01adb95948234d6db7a71/
The JSON::PP module is included within the Perl installation. WebKit has some scripts used at build time which require Perl installed in the host.
--- package/webkitgtk/webkitgtk.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/webkitgtk/webkitgtk.mk +1 -1
@@ -12,7 +12,7 @@ WEBKITGTK_LICENSE = LGPL-2.1+, BSD-2-Clause WEBKITGTK_LICENSE_FILES = \ Source/WebCore/LICENSE-APPLE \ Source/WebCore/LICENSE-LGPL-2.1 -WEBKITGTK_DEPENDENCIES = host-ruby host-python host-gperf \ +WEBKITGTK_DEPENDENCIES = host-ruby host-perl host-python host-gperf \ enchant harfbuzz icu jpeg libgcrypt libgtk3 libsecret libsoup \ libtasn1 libxml2 libxslt openjpeg sqlite webp woff2 WEBKITGTK_CONF_OPTS = \
Signature · 1 line
2.23.0
PATCH 1/1 package/webkitgtk: add missing host-perl dependency
Le dim. 15 sept. 2019 ? 15:01, Adrian Perez de Castro <[email protected]> a ?crit :
Quoted 9 lines
Fixes:
http://autobuild.buildroot.net/results/faa23c0e648b916d0fb01adb95948234d6db7a71/
The
JSON::PPmodule is included within the Perl installation. WebKit has some scripts used at build time which require Perl installed in the host.
Building host-perl is overkill, the system perl is enough.
The presence of a core module like JSON::PP could be checked in dependencies.sh
see
https://git.busybox.net/buildroot/tree/support/dependencies/dependencies.sh#n259
Note: JSON::PP is a core module since Perl 5.18 which was released in 2013
Fran?ois
Quoted 22 lines
Signed-off-by Adrian Perez de Castro <[email protected]>--- package/webkitgtk/webkitgtk.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/webkitgtk/ renamed from package/webkitgtk/webkitgtk.mk +0
-0webkitgtk.mk
index97e3311654..74c832d5df100644package/webkitgtk/webkitgtk.mk +1
-2@@ -12,7 +12,7 @@ WEBKITGTK_LICENSE = LGPL-2.1+, BSD-2-Clause WEBKITGTK_LICENSE_FILES = \ Source/WebCore/LICENSE-APPLE \ Source/WebCore/LICENSE-LGPL-2.1 -WEBKITGTK_DEPENDENCIES = host-ruby host-python host-gperf \ +WEBKITGTK_DEPENDENCIES = host-ruby host-perl host-python host-gperf \ enchant harfbuzz icu jpeg libgcrypt libgtk3 libsecret libsoup \ libtasn1 libxml2 libxslt openjpeg sqlite webp woff2 WEBKITGTK_CONF_OPTS = \ --2.23.0
Quoted 5 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190915/410825e0/attachment.html>
PATCH v2 1/1 support/dependencies/dependencies.sh: check for JSON:PP Perl module
In reply to Adrian Perez de CastroFixes:
http://autobuild.buildroot.net/results/faa23c0e648b916d0fb01adb95948234d6db7a71/
The JSON::PP Perl module is used at build time by the webkitgtk and wpewebkit packages.
--- support/dependencies/dependencies.sh | 4 ++++ 1 file changed, 4 insertions(+)
---
v1 -> v2:
- Intead of making the package depend on host-perl, check for the module in the dependencies.sh script to avoid making the build slower. The module has been in core Perl since 2013.
support/dependencies/dependencies.sh +4 -0
@@ -270,6 +270,10 @@ if grep -q ^BR2_PACKAGE_WHOIS=y $BR2_CONFIG ; then required_perl_modules="$required_perl_modules autodie" fi +if grep -q -E '^BR2_PACKAGE_(WEBKITGTK|WPEWEBKIT)=y' $BR2_CONFIG ; then + required_perl_modules="${required_perl_modules} JSON::PP" +fi + # This variable will keep the modules that are missing in your system. missing_perl_modules=""
Signature · 1 line
2.23.0
PATCH v2 1/1 support/dependencies/dependencies.sh: check for JSON:PP Perl module
Hello Adrian,
Quoted 7 lines · On Mon, 16 Sep 2019 01:57:43 +0300 Adrian Perez de Castro <[email protected]>…
Fixes:
http://autobuild.buildroot.net/results/faa23c0e648b916d0fb01adb95948234d6db7a71/The
JSON::PPPerl module is used at build time by the webkitgtk and wpewebkit packages.Signed-off-by Adrian Perez de Castro <[email protected]>
I've applied to master, thanks. However, I did a mistake: I deleted the Fixes line and the URL, because I thought this patch would not fix the build issue. Indeed, I thought that it if fails today when building wpewebkit or webkitgtk, with your patch it would simply fail earlier in the dependencies check.
However, as I wrote this explanation I realized that utils/genrandconfig has some logic to check the dependencies and reject a configuration if the necessary dependencies are not met.
So indeed, your patch fixes the above issue. Unfortunately, I had already pushed the commit, so it was too late to re-amend the commit log.
Sorry about that :-/
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 support/dependencies/dependencies.sh: check for JSON:PP Perl module
In reply to Adrian Perez de CastroQuoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Adrian" == Adrian Perez de Castro <[email protected]> writes:
Fixes:
http://autobuild.buildroot.net/results/faa23c0e648b916d0fb01adb95948234d6db7a71/The
JSON::PPPerl module is used at build time by the webkitgtk and wpewebkit packages.Signed-off-by Adrian Perez de Castro <[email protected]>--- support/dependencies/dependencies.sh | 4 ++++ 1 file changed, 4 insertions(+)
Quoted 5 lines
---
v1 -> v2:
- Intead of making the package depend on host-perl, check for the module in thedependencies.shscript to avoid making the build slower. The module has been in core Perl since 2013.
Committed to 2019.02.x, 2019.05.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard