Skip to contentSkip to conversation

docker: add sanitizers back to clang build

PATCH In review John Snow 3 participants 5 messages Sep 12, 2019 – Sep 19, 2019

lore
Share & tools
lore

John Snow

author
#0 lore raw

PATCH 1/1 docker: add sanitizers back to clang build

Fedora23 is but a distant twinkle.
The sanitizer works again, and even if not,
we have --enable-sanitizers now.

---

The problem is that I do see some ASAN warnings:

TEST check-qtest-aarch64: tests/device-introspect-test

Direct leak of 2272 byte(s) in 48 object(s) allocated from:

    #0 0x55aea5598b4e in calloc (/tmp/qemu-test/build/aarch64-softmmu/qemu-system-aarch64+0x19a9b4e)
    #1 0x7f783ff11ce0 in g_malloc0 (/lib64/libglib-2.0.so.0+0x55ce0)

Direct leak of 864 byte(s) in 18 object(s) allocated from:

    #0 0x55aea5598b4e in calloc (/tmp/qemu-test/build/aarch64-softmmu/qemu-system-aarch64+0x19a9b4e)
    #1 0x7f783ff11ce0 in g_malloc0 (/lib64/libglib-2.0.so.0+0x55ce0)
    #2 0x55aea712b379 in object_initialize_with_type /tmp/qemu-test/src/qom/object.c:467:5

I'd run it again, but it took eight years to get to that point, it's late and I'm tired.

---
 tests/docker/test-clang | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
tests/docker/test-clang +1 -5
index 324e341cea..db9e6970b7 100755
@@ -17,11 +17,7 @@ requires clang
 
 cd "$BUILD_DIR"
 
-OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
-# -fsanitize=undefined is broken on Fedora 23, skip it for now
-# See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834
-#OPTS="$OPTS --extra-cflags=-fsanitize=undefined \
-    #--extra-cflags=-fno-sanitize=float-divide-by-zero"
+OPTS="--cxx=clang++ --cc=clang --host-cc=clang --enable-sanitizers"
 build_qemu $OPTS
 check_qemu
 install_qemu
Signature · 1 line
2.21.0
#1 lore raw
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Subject: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build
Message-id: [email protected]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
Switched to a new branch 'test'
96d44b9 docker: add sanitizers back to clang build

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 12 lines checked

Commit 96d44b9f7f66 (docker: add sanitizers back to clang build) has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]

author
#2 lore raw
Quoted 22 lines · On 9/11/19 9:52 PM, [email protected] wrote:

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Subject: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build
Message-id: [email protected]
Type: series

=== TEST SCRIPT BEGIN === #!/bin/bash
git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END ===

Quoted 7 lines

From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
Switched to a new branch 'test'
96d44b9 docker: add sanitizers back to clang build

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

GDI.

I keep adding this to my configuration files, but it keeps "falling off", somehow.

I have some patches in the works for stgit where I'm going to work through some test cases for setting profile variables and try to fix this.

In the meantime:

#3 lore raw
Quoted 38 lines · John Snow
Quoted 22 lines · On 9/11/19 9:52 PM, [email protected] wrote:

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Subject: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build
Message-id: [email protected]
Type: series

=== TEST SCRIPT BEGIN === #!/bin/bash
git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END ===

Quoted 7 lines

From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
Switched to a new branch 'test'
96d44b9 docker: add sanitizers back to clang build

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

GDI.

I keep adding this to my configuration files, but it keeps "falling off", somehow.

Quoted 6 lines

I have some patches in the works for stgit where I'm going to work through some test cases for setting profile variables and try to fix this.

In the meantime:

Isn't this because you inserted a '---' line in the middle of the commit message so the part after it is ditched by 'git am'?

This feels a bit hard to catch, wondering what is in the works. :)

Fam

author
#4 lore raw
Quoted 42 lines · Fam Zheng
Quoted 41 lines · John Snow
Quoted 22 lines · On 9/11/19 9:52 PM, [email protected] wrote:

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Subject: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build
Message-id: [email protected]
Type: series

=== TEST SCRIPT BEGIN === #!/bin/bash
git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END ===

Quoted 7 lines

From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
Switched to a new branch 'test'
96d44b9 docker: add sanitizers back to clang build

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

GDI.

I keep adding this to my configuration files, but it keeps "falling off", somehow.

I have some patches in the works for stgit where I'm going to work through some test cases for setting profile variables and try to fix this.

Quoted 9 lines
Quoted 3 lines

In the meantime:

Isn't this because you inserted a '---' line in the middle of the commit message so the part after it is ditched by 'git am'?

This feels a bit hard to catch, wondering what is in the works. :)

gah, you're right -- I blamed it on the script failing, because it has been a little unreliable for me lately :)

Hm, how do I accommodate putting in notes to my commit messages while keeping tooling happy ...

--js