Skip to contentSkip to conversation

block: Fix implicit unsigned to signed conversion

PATCH In review Alessio Balsini 2 participants 2 messages Sep 18, 2019 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: Fix implicit unsigned to signed conversion

An unsigned integer variable may be assigned negative values, and is returned by the function with an implicit conversion to signed. Besides the implicit conversion at return time for which the variable representation is fine and there is no variable manipulation that may lead to bugs in the current code base, this is a conceptual error.

Fix by changing the variable type from unsigned to signed.

---
 block/blk-settings.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
block/blk-settings.c +2 -1
index 6bd1e3b082d8..c76c25c45869 100644
@@ -496,7 +496,8 @@ EXPORT_SYMBOL(blk_queue_stack_limits);
 int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
 		     sector_t start)
 {
-	unsigned int top, bottom, alignment, ret = 0;
+	unsigned int top, bottom, alignment;
+	int ret = 0;
 
 	t->max_sectors = min_not_zero(t->max_sectors, b->max_sectors);
 	t->max_hw_sectors = min_not_zero(t->max_hw_sectors, b->max_hw_sectors);
Signature · 1 line
2.23.0.237.gc6a4ce50a0-goog
Reviewed-by on v1 1/1
#1 lore raw

Since this is a conceptual error and will not cause any bug not sure if this needed as things are not leading to any bugs.

However cleanup is helpful in avoiding any confusion.

Looks good to me.

Quoted 10 lines · Alessio Balsini

An unsigned integer variable may be assigned negative values, and is returned by the function with an implicit conversion to signed. Besides the implicit conversion at return time for which the variable representation is fine and there is no variable manipulation that may lead to bugs in the current code base, this is a conceptual error.

Fix by changing the variable type from unsigned to signed.