Skip to contentSkip to conversation

stable backport for dc8635b78cd8669

PATCH Applied Vineet Gupta 3 participants 7 messages Sep 18, 2019 – Sep 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Stable team,

Can we please backport dc8635b78cd8669c37e230058d18c33af7451ab1 ("kernel/exit.c:
export abort() to modules")

0-Day kernel test infra reports ARC 4.x.y builds failing after backport of af1be2e21203867cb958aace ("ARC: handle gcc generated __builtin_trap for older compiler")

Thx
-Vineet

#1 lore raw
Quoted 8 lines · Vineet Gupta

Hi Stable team,

Can we please backport dc8635b78cd8669c37e230058d18c33af7451ab1 ("kernel/exit.c:
export abort() to modules")

0-Day kernel test infra reports ARC 4.x.y builds failing after backport of af1be2e21203867cb958aace ("ARC: handle gcc generated __builtin_trap for older compiler")

So is this only needed in 4.9.y and 4.4.y?

thanks,

greg k-h

#2 lore raw
Quoted 1 line · Greg Kroah-Hartman

So is this only needed in 4.9.y and 4.4.y?

Yes indeed !

Thx,
-Vineet

#3 lore raw
Quoted 4 lines · Vineet Gupta
Quoted 1 line · Greg Kroah-Hartman

So is this only needed in 4.9.y and 4.4.y?

Yes indeed !

It doesn't apply there at all, can you provide a working backport for those kernels so that I can queue it up?

thanks,

greg k-h

#4 lore raw

PATCH 1/1 ARC: export "abort" for modules

This is a custom patch (no mainline equivalent) for stable backport only to address 0-Day kernel test infra ARC 4.x.y builds errors.

The reason for this custom patch as that it is a single patch, touches only ARC, vs. atleast two 7c2c11b208be09c1, dc8635b78cd8669 which touch atleast 3 other arches (one long removed) and could potentially have a fallout.

Reported-by kbuild test robot <lkp at intel.com>
CC stable at vger.kernel.org # 4.4, 4.9
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
---
 arch/arc/kernel/traps.c | 1 +
 1 file changed, 1 insertion(+)
arch/arc/kernel/traps.c +1 -0
index 2fb0cd39a31c..cd6e3615e3d1 100644
@@ -163,3 +163,4 @@ void abort(void)
 {
 	__asm__ __volatile__("trap_s  5\n");
 }
+EXPORT_SYMBOL(abort);
Signature · 1 line
2.20.1
maintainer Applied
#5 lore raw

Patch "ARC: export "abort" for modules" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled

ARC: export "abort" for modules

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arc-export-abort-for-modules.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <stable at vger.kernel.org> know about it.

Quoted 1 line

From Vineet.Gupta1 at synopsys.com Thu Sep 19 23:10:40 2019

From: Vineet Gupta <[email protected]>
Date: Thu, 19 Sep 2019 13:58:47 -0700
Subject: ARC: export "abort" for modules
To: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: linux-snps-arc at lists.infradead.org, Vineet Gupta <Vineet.Gupta1 at synopsys.com>, kbuild test robot <lkp at intel.com>, stable at vger.kernel.org
List-ID: <[email protected]>
To: [email protected]
Message-ID: <20190919205847.4806-1-vgupta at synopsys.com>

From: Vineet Gupta <[email protected]>

This is a custom patch (no mainline equivalent) for stable backport only to address 0-Day kernel test infra ARC 4.x.y builds errors.

The reason for this custom patch as that it is a single patch, touches only ARC, vs. atleast two 7c2c11b208be09c1, dc8635b78cd8669 which touch atleast 3 other arches (one long removed) and could potentially have a fallout.

Reported-by kbuild test robot <lkp at intel.com>
CC stable at vger.kernel.org # 4.4, 4.9
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
Signed-off-by Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 arch/arc/kernel/traps.c |    1 +
 1 file changed, 1 insertion(+)
arch/arc/kernel/traps.c +1 -0
@@ -163,3 +163,4 @@ void abort(void)
 {
 	__asm__ __volatile__("trap_s  5\n");
 }
+EXPORT_SYMBOL(abort);

Patches currently in stable-queue which might be from Vineet.Gupta1 at synopsys.com are

queue-4.4/arc-export-abort-for-modules.patch

maintainer Applied
#6 lore raw

Patch "ARC: export "abort" for modules" has been added to the 4.9-stable tree

In reply to Vineet Gupta

This is a note to let you know that I've just added the patch titled

ARC: export "abort" for modules

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arc-export-abort-for-modules.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <stable at vger.kernel.org> know about it.

Quoted 1 line

From Vineet.Gupta1 at synopsys.com Thu Sep 19 23:10:40 2019

From: Vineet Gupta <[email protected]>
Date: Thu, 19 Sep 2019 13:58:47 -0700
Subject: ARC: export "abort" for modules
To: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: linux-snps-arc at lists.infradead.org, Vineet Gupta <Vineet.Gupta1 at synopsys.com>, kbuild test robot <lkp at intel.com>, stable at vger.kernel.org
List-ID: <[email protected]>
To: [email protected]
Message-ID: <20190919205847.4806-1-vgupta at synopsys.com>

From: Vineet Gupta <[email protected]>

This is a custom patch (no mainline equivalent) for stable backport only to address 0-Day kernel test infra ARC 4.x.y builds errors.

The reason for this custom patch as that it is a single patch, touches only ARC, vs. atleast two 7c2c11b208be09c1, dc8635b78cd8669 which touch atleast 3 other arches (one long removed) and could potentially have a fallout.

Reported-by kbuild test robot <lkp at intel.com>
CC stable at vger.kernel.org # 4.4, 4.9
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
Signed-off-by Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 arch/arc/kernel/traps.c |    1 +
 1 file changed, 1 insertion(+)
arch/arc/kernel/traps.c +1 -0
@@ -163,3 +163,4 @@ void abort(void)
 {
 	__asm__ __volatile__("trap_s  5\n");
 }
+EXPORT_SYMBOL(abort);

Patches currently in stable-queue which might be from Vineet.Gupta1 at synopsys.com are

queue-4.9/arc-export-abort-for-modules.patch