hv: vmbus: mark PM functions as __maybe_unused
Subsystems (2)
PATCH 1/1 hv: vmbus: mark PM functions as __maybe_unused
When CONFIG_PM is disabled, we get a couple of harmless warnings:
drivers/hv/vmbus_drv.c:918:12: error: unused function 'vmbus_suspend' [-Werror,-Wunused-function] drivers/hv/vmbus_drv.c:937:12: error: unused function 'vmbus_resume' [-Werror,-Wunused-function] drivers/hv/vmbus_drv.c:2128:12: error: unused function 'vmbus_bus_suspend' [-Werror,-Wunused-function] drivers/hv/vmbus_drv.c:2208:12: error: unused function 'vmbus_bus_resume' [-Werror,-Wunused-function]
Mark these functions __maybe_unused to let gcc drop them silently.
--- drivers/hv/vmbus_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/hv/vmbus_drv.c +4 -4
@@ -915,7 +915,7 @@ static void vmbus_shutdown(struct device *child_device)/* * vmbus_suspend - Suspend a vmbus device */ -static int vmbus_suspend (struct device *child_device) +static int __maybe_unused vmbus_suspend (struct device *child_device) {struct hv_driver *drv;struct hv_device *dev =device_to_hv_device (child_device);
@@ -934,7 +934,7 @@ static int vmbus_suspend(struct device *child_device)/* * vmbus_resume - Resume a vmbus device */ -static int vmbus_resume (struct device *child_device) +static int __maybe_unused vmbus_resume (struct device *child_device) {struct hv_driver *drv;struct hv_device *dev =device_to_hv_device (child_device);
@@ -2125,7 +2125,7 @@ static int vmbus_acpi_add(struct acpi_device *device)return ret_val; } -static int vmbus_bus_suspend (struct device *dev) +static int __maybe_unused vmbus_bus_suspend (struct device *dev) {struct vmbus_channel *channel, *sc;unsigned long flags;
@@ -2205,7 +2205,7 @@ static int vmbus_bus_suspend(struct device *dev)return 0 ; } -static int vmbus_bus_resume (struct device *dev) +static int __maybe_unused vmbus_bus_resume (struct device *dev) {struct vmbus_channel_msginfo *msginfo;size_t msgsize;
Signature · 1 line
2.20.0
Dexuan Cui
maintainerQuoted 14 lines
From: Arnd Bergmann <[email protected]>
Sent: Wednesday, September 18, 2019 1:01 PMWhen
CONFIG_PMis disabled, we get a couple of harmless warnings:
drivers/hv/vmbus_drv.c:918:12: error: unused function 'vmbus_suspend' [-Werror,-Wunused-function]drivers/hv/vmbus_drv.c:937:12: error: unused function 'vmbus_resume' [-Werror,-Wunused-function]drivers/hv/vmbus_drv.c:2128:12: error: unused function 'vmbus_bus_suspend' [-Werror,-Wunused-function]drivers/hv/vmbus_drv.c:2208:12: error: unused function 'vmbus_bus_resume' [-Werror,-Wunused-function]
Quoted 1 line
Mark these functions
__maybe_unusedto let gcc drop them silently.
Hi Arnd,
Thanks for reporting the issue!
If CONFIG_PM is not set, IMO it's better to comment out these functions. :-)
I'll post a patch for this with you Cc'd.
Thanks,
-- Dexuan