wireshark: remove restriction to ARM ISA
PATCH 1/1 wireshark: remove restriction to ARM ISA
The restriction to ARM instruction set came in the original wireshark recipe, which was 2 major versions ago (and also a few toolchains ago). Wireshark 3.x seems to be building fine allowing thumb instructions, at least on cortexa9t2hf.
--- meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb | 2 -- 1 file changed, 2 deletions(-)
meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb +0 -2
@@ -19,8 +19,6 @@ PE = "1" inherit cmake pkgconfig python3native perlnative upstream-version-is-even -ARM_INSTRUCTION_SET = "arm" - PACKAGECONFIG ?= "libpcap gnutls libnl libcap sbc" PACKAGECONFIG_class-native = "libpcap gnutls ssl libssh"
Signature · 1 line
1.9.4
Quoted 14 lines · S. Lockwood-Childs
The restriction to ARM instruction set came in the original wireshark recipe, which was 2 major versions ago (and also a few toolchains ago). Wireshark 3.x seems to be building fine allowing thumb instructions, at least on cortexa9t2hf.
--- meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb | 2 -- 1 file changed, 2 deletions(-)meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb +0
-0
meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb PE = "1" · line 22
Quoted 4 lines
meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb +0
-1@@ -19,8 +19,6 @@ PE = "1" inherit cmake pkgconfig python3native perlnative upstream-version-is-even -ARM_INSTRUCTION_SET = "arm"
it will be interesting to see if it is still the case with thumb1 on <= armv5t earlier we use to test qrmarm with thumb, maybe build with
MACHINE=qemuarmv5 and in recipe set
ARM_INSTRUCTION_SET = "thumb"
and see if it still builds.
If not them limit this setting to arch <= v6
Quoted 12 lines
meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb +0
-2- PACKAGECONFIG ?= "libpcap gnutls libnl libcap sbc" PACKAGECONFIG_class-native = "libpcap gnutls ssl libssh" --1.9.4
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 23 lines · Khem Raj
Quoted 14 lines · S. Lockwood-Childs
The restriction to ARM instruction set came in the original wireshark recipe, which was 2 major versions ago (and also a few toolchains ago). Wireshark 3.x seems to be building fine allowing thumb instructions, at least on cortexa9t2hf.
--- meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb | 2 -- 1 file changed, 2 deletions(-)meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb +0
-0meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb PE = "1" · line 22
Quoted 4 lines
meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb +0
-1@@ -19,8 +19,6 @@ PE = "1" inherit cmake pkgconfig python3native perlnative upstream-version-is-even -ARM_INSTRUCTION_SET = "arm"it will be interesting to see if it is still the case with thumb1 on <= armv5t earlier we use to test qrmarm with thumb, maybe build with
Quoted 7 lines
MACHINE=qemuarmv5 and in recipe set
ARM_INSTRUCTION_SET= "thumb"and see if it still builds.
If not them limit this setting to arch <= v6
Yes, it did still build with MACHINE=qemuarmv5 and
-ARM_INSTRUCTION_SET = "arm"
+ARM_INSTRUCTION_SET = "thumb"
I don't even see any warnings in log.do_compile either