clk: imx7ulp: remove IMX7ULP_CLK_MIPI_PLL clock
PATCH v2 1/1 clk: imx7ulp: remove IMX7ULP_CLK_MIPI_PLL clock
The mipi pll clock comes from the MIPI PHY PLL output, so it should not be a fixed clock.
MIPI PHY PLL is in the MIPI DSI space, and it is used as the bit clock for transferring the pixel data out and its output clock is configured according to the display mode.
So it should be used only for MIPI DSI and not be exported out for other usages.
---
ChangeLog v1->v2:
* Keep other clock indexes unchanged as Shawn suggested.
Documentation/devicetree/bindings/clock/imx7ulp-clock.txt | 1 - drivers/clk/imx/clk-imx7ulp.c | 3 +-- include/dt-bindings/clock/imx7ulp-clock.h | 1 - 3 files changed, 1 insertion(+), 4 deletions(-)
Documentation/devicetree/bindings/clock/imx7ulp-clock.txt +0 -1
@@ -82,7 +82,6 @@ pcc2: pcc2@403f0000 { <&scg1 IMX7ULP_CLK_APLL_PFD0>, <&scg1 IMX7ULP_CLK_UPLL>, <&scg1 IMX7ULP_CLK_SOSC_BUS_CLK>, - <&scg1 IMX7ULP_CLK_MIPI_PLL>, <&scg1 IMX7ULP_CLK_FIRC_BUS_CLK>, <&scg1 IMX7ULP_CLK_ROSC>, <&scg1 IMX7ULP_CLK_SPLL_BUS_CLK>;
drivers/clk/imx/clk-imx7ulp.c +1 -2
@@ -28,7 +28,7 @@ static const char * const scs_sels[] = { "dummy", "sosc", "sirc", "firc", "dummstatic const char *const ddr_sels[] = {"apll_pfd_sel" ,"upll" , };static const char *const nic_sels[] = {"firc" ,"ddr_clk" , };static const char *const periph_plat_sels[] = {"dummy" ,"nic1_bus_clk" ,"nic1_clk" ,"ddr_clk" ,"apll_pfd2" ,"apll_pfd1" ,"apll_pfd0" ,"upll" , }; -static const char *const periph_bus_sels[] = {"dummy" ,"sosc_bus_clk" ,"mpll" ,"firc_bus_clk" ,"rosc" ,"nic1_bus_clk" ,"nic1_clk" ,"spll_bus_clk" , }; +static const char *const periph_bus_sels[] = {"dummy" ,"sosc_bus_clk" ,"dummy" ,"firc_bus_clk" ,"rosc" ,"nic1_bus_clk" ,"nic1_clk" ,"spll_bus_clk" , };static const char *const arm_sels[] = {"divcore" ,"dummy" ,"dummy" ,"hsrun_divcore" , };/* used by sosc/sirc/firc/ddr/spll/apll dividers */
@@ -75,7 +75,6 @@ static void __init imx7ulp_clk_scg1_init(struct device_node *np) clks[IMX7ULP_CLK_SOSC ] =imx_obtain_fixed_clk_hw (np,"sosc" ); clks[IMX7ULP_CLK_SIRC ] =imx_obtain_fixed_clk_hw (np,"sirc" ); clks[IMX7ULP_CLK_FIRC ] =imx_obtain_fixed_clk_hw (np,"firc" ); - clks[IMX7ULP_CLK_MIPI_PLL ] =imx_obtain_fixed_clk_hw (np,"mpll" ); clks[IMX7ULP_CLK_UPLL ] =imx_obtain_fixed_clk_hw (np,"upll" );/* SCG1 */
include/dt-bindings/clock/imx7ulp-clock.h +0 -1
@@ -49,7 +49,6 @@#define IMX7ULP_CLK_NIC1_DIV 36#define IMX7ULP_CLK_NIC1_BUS_DIV 37#define IMX7ULP_CLK_NIC1_EXT_DIV 38 -#define IMX7ULP_CLK_MIPI_PLL 39#define IMX7ULP_CLK_SIRC 40#define IMX7ULP_CLK_SOSC_BUS_CLK 41#define IMX7ULP_CLK_FIRC_BUS_CLK 42
Signature · 1 line
2.17.1
PATCH v2 1/1 clk: imx7ulp: remove IMX7ULP_CLK_MIPI_PLL clock
The mipi pll clock comes from the MIPI PHY PLL output, so it should not be a fixed clock.
MIPI PHY PLL is in the MIPI DSI space, and it is used as the bit clock for transferring the pixel data out and its output clock is configured according to the display mode.
So it should be used only for MIPI DSI and not be exported out for other usages.
---
ChangeLog v1->v2:
* Keep other clock indexes unchanged as Shawn suggested.
Documentation/devicetree/bindings/clock/imx7ulp-clock.txt | 1 - drivers/clk/imx/clk-imx7ulp.c | 3 +-- include/dt-bindings/clock/imx7ulp-clock.h | 1 - 3 files changed, 1 insertion(+), 4 deletions(-)
Documentation/devicetree/bindings/clock/imx7ulp-clock.txt +0 -1
@@ -82,7 +82,6 @@ pcc2: pcc2@403f0000 { <&scg1 IMX7ULP_CLK_APLL_PFD0>, <&scg1 IMX7ULP_CLK_UPLL>, <&scg1 IMX7ULP_CLK_SOSC_BUS_CLK>, - <&scg1 IMX7ULP_CLK_MIPI_PLL>, <&scg1 IMX7ULP_CLK_FIRC_BUS_CLK>, <&scg1 IMX7ULP_CLK_ROSC>, <&scg1 IMX7ULP_CLK_SPLL_BUS_CLK>;
drivers/clk/imx/clk-imx7ulp.c +1 -2
@@ -28,7 +28,7 @@ static const char * const scs_sels[] = { "dummy", "sosc", "sirc", "firc", "dummstatic const char *const ddr_sels[] = {"apll_pfd_sel" ,"upll" , };static const char *const nic_sels[] = {"firc" ,"ddr_clk" , };static const char *const periph_plat_sels[] = {"dummy" ,"nic1_bus_clk" ,"nic1_clk" ,"ddr_clk" ,"apll_pfd2" ,"apll_pfd1" ,"apll_pfd0" ,"upll" , }; -static const char *const periph_bus_sels[] = {"dummy" ,"sosc_bus_clk" ,"mpll" ,"firc_bus_clk" ,"rosc" ,"nic1_bus_clk" ,"nic1_clk" ,"spll_bus_clk" , }; +static const char *const periph_bus_sels[] = {"dummy" ,"sosc_bus_clk" ,"dummy" ,"firc_bus_clk" ,"rosc" ,"nic1_bus_clk" ,"nic1_clk" ,"spll_bus_clk" , };static const char *const arm_sels[] = {"divcore" ,"dummy" ,"dummy" ,"hsrun_divcore" , };/* used by sosc/sirc/firc/ddr/spll/apll dividers */
@@ -75,7 +75,6 @@ static void __init imx7ulp_clk_scg1_init(struct device_node *np) clks[IMX7ULP_CLK_SOSC ] =imx_obtain_fixed_clk_hw (np,"sosc" ); clks[IMX7ULP_CLK_SIRC ] =imx_obtain_fixed_clk_hw (np,"sirc" ); clks[IMX7ULP_CLK_FIRC ] =imx_obtain_fixed_clk_hw (np,"firc" ); - clks[IMX7ULP_CLK_MIPI_PLL ] =imx_obtain_fixed_clk_hw (np,"mpll" ); clks[IMX7ULP_CLK_UPLL ] =imx_obtain_fixed_clk_hw (np,"upll" );/* SCG1 */
include/dt-bindings/clock/imx7ulp-clock.h +0 -1
@@ -49,7 +49,6 @@#define IMX7ULP_CLK_NIC1_DIV 36#define IMX7ULP_CLK_NIC1_BUS_DIV 37#define IMX7ULP_CLK_NIC1_EXT_DIV 38 -#define IMX7ULP_CLK_MIPI_PLL 39#define IMX7ULP_CLK_SIRC 40#define IMX7ULP_CLK_SOSC_BUS_CLK 41#define IMX7ULP_CLK_FIRC_BUS_CLK 42
Signature · 1 line
2.17.1
Stephen Boyd
maintainerQuoting Fancy Fang (2019-09-18 20:10:48)
include/dt-bindings/clock/imx7ulp-clock.h line 52
Quoted 9 lines
include/dt-bindings/clock/imx7ulp-clock.h +0
-1@@ -49,7 +49,6 @@#define IMX7ULP_CLK_NIC1_DIV 36#define IMX7ULP_CLK_NIC1_BUS_DIV 37#define IMX7ULP_CLK_NIC1_EXT_DIV 38 -#define IMX7ULP_CLK_MIPI_PLL 39
You can't remove this. Just add a comment like /* unused */ or something to indicate this shouldn't be used.
Quoted 6 lines
include/dt-bindings/clock/imx7ulp-clock.h +0
-0#define IMX7ULP_CLK_SIRC 40#define IMX7ULP_CLK_SOSC_BUS_CLK 41#define IMX7ULP_CLK_FIRC_BUS_CLK 42Signature · 1 line
2.17.1
kbuild test robot
build botThank you for the patch! Yet something to improve:
Hi Fancy,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190918]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Fancy-Fang/clk-imx7ulp-remove-IMX7ULP_CLK_MIPI_PLL-clock/20190919-111243
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/imx7ulp.dtsi:279.13-14 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation