Skip to contentSkip to conversation

eal: remove redundant error output

PATCH In review Stephen Hemminger 3 participants 4 messages Aug 20, 2019 – Oct 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal: remove redundant error output

The function rte_eal_init_alert ends up printing the same message twice. Once via RTE_LOG and once to stderr. Remove the fprintf to stderr since it is redundant.

---
 lib/librte_eal/linux/eal/eal.c | 1 -
 1 file changed, 1 deletion(-)
lib/librte_eal/linux/eal/eal.c +0 -1
index 946222ccdb7a..076fb3cbde5f 100644
@@ -949,7 +949,6 @@ static int rte_eal_vfio_setup(void)
 
 static void rte_eal_init_alert(const char *msg)
 {
-	fprintf(stderr, "EAL: FATAL: %s\n", msg);
 	RTE_LOG(ERR, EAL, "%s\n", msg);
 }
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 6 lines · Stephen Hemminger

The function rte_eal_init_alert ends up printing the same message twice. Once via RTE_LOG and once to stderr. Remove the fprintf to stderr since it is redundant.

---

This was originally added at your suggestion:

http://mails.dpdk.org/archives/dev/2017-January/056431.html

Because sometimes we have these alerts before logging is up (so the RTE_LOG(...) won't show up, I gather).

Is it possible to have an either/or?

Quoted 14 lines
 lib/librte_eal/linux/eal/eal.c | 1 -
 1 file changed, 1 deletion(-)
lib/librte_eal/linux/eal/eal.c +0 -1
index 946222ccdb7a..076fb3cbde5f 100644
@@ -949,7 +949,6 @@ static int rte_eal_vfio_setup(void)
 
 static void rte_eal_init_alert(const char *msg)
 {
-	fprintf(stderr, "EAL: FATAL: %s\n", msg);
 	RTE_LOG(ERR, EAL, "%s\n", msg);
 }
#2 lore raw

PATCH v2 1/1 eal: don't call RTE_LOG before init

In reply to Stephen Hemminger

rte_init_alert is called before rte_log is initialized. Therefore RTE_LOG() should not be used (only stderr).

For VFIO, it is initialized after rte_log_init therefore, use RTE_LOG.

---
 lib/librte_eal/linux/eal/eal.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
lib/librte_eal/linux/eal/eal.c +1 -2
index 946222ccdb7a..6f54a8b2133f 100644
@@ -950,7 +950,6 @@ static int rte_eal_vfio_setup(void)
 static void rte_eal_init_alert(const char *msg)
 {
 	fprintf(stderr, "EAL: FATAL: %s\n", msg);
-	RTE_LOG(ERR, EAL, "%s\n", msg);
 }
 
 /*
@@ -1175,7 +1174,7 @@ rte_eal_init(int argc, char **argv)
 
 #ifdef VFIO_PRESENT
 	if (rte_eal_vfio_setup() < 0) {
-		rte_eal_init_alert("Cannot init VFIO");
+		RTE_LOG(ERR, EAL, "Cannot init VFIO\n");
 		rte_errno = EAGAIN;
 		rte_atomic32_clear(&run_once);
 		return -1;
Signature · 1 line
2.17.1
#3 lore raw

Re: [dpdk-dev] [PATCH v2] eal: don't call RTE_LOG before init

Quoted 2 lines · Stephen Hemminger

rte_init_alert is called before rte_log is initialized.

rte_eal_init_alert*

Quoted 1 line

Therefore RTE_LOG() should not be used (only stderr).

There should be nothing disastrous when calling RTE_LOG() before rte_eal_log_init has been called.
RTE_LOG -> rte_vlog with rte_logs.file == default_log_stream == NULL => it should end up writing to stderr in such a case.

And I understand this is the issue you wanted to fix because we write the same messages twice on stderr.

Quoted 3 lines

For VFIO, it is initialized after rte_log_init therefore, use RTE_LOG.

What about all the other calls after the vfio setup step? Now with this change, they would only be passed to stderr even if the log subsystem is initialised.

Can we have a "log initialised" boolean here and use it in rte_eal_init_alert?

Quoted 30 lines
---
 lib/librte_eal/linux/eal/eal.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
lib/librte_eal/linux/eal/eal.c +1 -3
index 946222ccdb7a..6f54a8b2133f 100644
@@ -950,7 +950,6 @@ static int rte_eal_vfio_setup(void)
 static void rte_eal_init_alert(const char *msg)
 {
        fprintf(stderr, "EAL: FATAL: %s\n", msg);
-       RTE_LOG(ERR, EAL, "%s\n", msg);
 }
 
 /*
@@ -1175,7 +1174,7 @@ rte_eal_init(int argc, char **argv)
 
 #ifdef VFIO_PRESENT
        if (rte_eal_vfio_setup() < 0) {
-               rte_eal_init_alert("Cannot init VFIO");
+               RTE_LOG(ERR, EAL, "Cannot init VFIO\n");
                rte_errno = EAGAIN;
                rte_atomic32_clear(&run_once);
                return -1;
--

2.17.1

Signature · 1 line
David Marchand