Skip to contentSkip to conversation

x86/boot: Reserve enough space for any cpu level string

PATCH New Cyrill Gorcunov 1 participant 1 message Sep 19, 2019 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/boot: Reserve enough space for any cpu level string

Currently when we're validating cpu on boot stage we assume that cpu level won't ever be greater than two digits. In particular the check_cpu() helper ensures to be so. Still the cpu_name() helper is a way too far from check_cpu() routine internals so I think better to be on a safe side and prevent any possible overrun errors when printing cpu name. For this sake just increase the buffer up to be able to keep any level.

CC Ingo Molnar <[email protected]>
CC Thomas Gleixner <[email protected]>
---
 arch/x86/boot/cpu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/boot/cpu.c +1 -1
Index: linux-tip.git/arch/x86/boot/cpu.c
===================================================================
@@ -20,7 +20,7 @@
 
 static char *cpu_name(int level)
 {
-	static char buf[6];
+	static char buf[16];
 
 	if (level == 64) {
 		return "x86-64";