spi: atmel: Remove AVR32 leftover
Subsystems (3)
PATCH 1/1 spi: atmel: Remove AVR32 leftover
AV32 support has been from the kernel a few release ago, but there was still some specific macro for this architecture in this driver. Lets remove it.
--- drivers/spi/spi-atmel.c | 24 ------------------------ 1 file changed, 24 deletions(-)
drivers/spi/spi-atmel.c +0 -24
@@ -222,37 +222,13 @@ | SPI_BF(name, value))/* Register access macros */ -#ifdef CONFIG_AVR32 -#define spi_readl (port, reg) \ - __raw_readl((port)->regs + SPI_##reg) -#define spi_writel (port, reg, value) \ - __raw_writel((value), (port)->regs + SPI_##reg) - -#define spi_readw (port, reg) \ - __raw_readw((port)->regs + SPI_##reg) -#define spi_writew (port, reg, value) \ - __raw_writew((value), (port)->regs + SPI_##reg) - -#define spi_readb (port, reg) \ - __raw_readb((port)->regs + SPI_##reg) -#define spi_writeb (port, reg, value) \ - __raw_writeb((value), (port)->regs + SPI_##reg) -#else #define spi_readl (port, reg) \ readl_relaxed((port)->regs + SPI_##reg)#define spi_writel (port, reg, value) \ writel_relaxed((value), (port)->regs + SPI_##reg) - -#define spi_readw (port, reg) \ - readw_relaxed((port)->regs + SPI_##reg)#define spi_writew (port, reg, value) \ writew_relaxed((value), (port)->regs + SPI_##reg) -#define spi_readb (port, reg) \ - readb_relaxed((port)->regs + SPI_##reg) -#define spi_writeb (port, reg, value) \ - writeb_relaxed((value), (port)->regs + SPI_##reg) -#endif /* use PIO for small transfers, avoiding DMA setup/teardown overhead and * cache operations; better heuristics consider wordsize and bitrate. */
Signature · 1 line
2.23.0
Alexandre Belloni
maintainerQuoted 1 line · Gregory CLEMENT
AV32 support has been from the kernel a few release ago, but there was
AVR32 and missing word^
Quoted 53 lines
still some specific macro for this architecture in this driver. Lets remove it.
Signed-off-by Gregory CLEMENT <[email protected]>--- drivers/spi/spi-atmel.c | 24 ------------------------ 1 file changed, 24 deletions(-)drivers/spi/spi-atmel.c +0
-24@@ -222,37 +222,13 @@ | SPI_BF(name, value))/* Register access macros */ -#ifdef CONFIG_AVR32 -#define spi_readl (port, reg) \ - __raw_readl((port)->regs + SPI_##reg) -#define spi_writel (port, reg, value) \ - __raw_writel((value), (port)->regs + SPI_##reg) - -#define spi_readw (port, reg) \ - __raw_readw((port)->regs + SPI_##reg) -#define spi_writew (port, reg, value) \ - __raw_writew((value), (port)->regs + SPI_##reg) - -#define spi_readb (port, reg) \ - __raw_readb((port)->regs + SPI_##reg) -#define spi_writeb (port, reg, value) \ - __raw_writeb((value), (port)->regs + SPI_##reg) -#else #define spi_readl (port, reg) \ readl_relaxed((port)->regs + SPI_##reg)#define spi_writel (port, reg, value) \ writel_relaxed((value), (port)->regs + SPI_##reg) - -#define spi_readw (port, reg) \ - readw_relaxed((port)->regs + SPI_##reg)#define spi_writew (port, reg, value) \ writew_relaxed((value), (port)->regs + SPI_##reg) -#define spi_readb (port, reg) \ - readb_relaxed((port)->regs + SPI_##reg) -#define spi_writeb (port, reg, value) \ - writeb_relaxed((value), (port)->regs + SPI_##reg) -#endif /* use PIO for small transfers, avoiding DMA setup/teardown overhead and * cache operations; better heuristics consider wordsize and bitrate. */ Signature · 1 line
2.23.0
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 6 lines · On Thu, 19 Sep 2019 19:24:53 +0200 Alexandre Belloni…
Quoted 1 line · Gregory CLEMENT
AV32 support has been from the kernel a few release ago, but there was
AVR32 and missing word^
Quoted 2 lines
still some specific macro for this architecture in this driver. Lets remove it.
If you want to actually be pedantic, there are a few other typos in the commit. Hopefully the below text has all of them fixed (and does not introduce any new one):
==
AVR32 support has been removed from the kernel a few releases ago, but there were still some specific macros for this architecture in this driver. Let's remove them.
==
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Mark Brown
maintainerApplied "spi: atmel: Remove AVR32 leftover" to the spi tree
In reply to Gregory CLEMENTThe patch
spi: atmel: Remove AVR32 leftover
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
e61bb114d41ddf6ae5bf05a0109fc13116550c7dMon Sep 17 00:00:00 2001
From: Gregory CLEMENT <[email protected]>
Date: Thu, 19 Sep 2019 17:40:34 +0200
Subject: [PATCH] spi: atmel: Remove AVR32 leftover
AV32 support has been from the kernel a few release ago, but there was still some specific macro for this architecture in this driver. Lets remove it.
--- drivers/spi/spi-atmel.c | 24 ------------------------ 1 file changed, 24 deletions(-)
drivers/spi/spi-atmel.c +0 -24
@@ -222,37 +222,13 @@ | SPI_BF(name, value))/* Register access macros */ -#ifdef CONFIG_AVR32 -#define spi_readl (port, reg) \ - __raw_readl((port)->regs + SPI_##reg) -#define spi_writel (port, reg, value) \ - __raw_writel((value), (port)->regs + SPI_##reg) - -#define spi_readw (port, reg) \ - __raw_readw((port)->regs + SPI_##reg) -#define spi_writew (port, reg, value) \ - __raw_writew((value), (port)->regs + SPI_##reg) - -#define spi_readb (port, reg) \ - __raw_readb((port)->regs + SPI_##reg) -#define spi_writeb (port, reg, value) \ - __raw_writeb((value), (port)->regs + SPI_##reg) -#else #define spi_readl (port, reg) \ readl_relaxed((port)->regs + SPI_##reg)#define spi_writel (port, reg, value) \ writel_relaxed((value), (port)->regs + SPI_##reg) - -#define spi_readw (port, reg) \ - readw_relaxed((port)->regs + SPI_##reg)#define spi_writew (port, reg, value) \ writew_relaxed((value), (port)->regs + SPI_##reg) -#define spi_readb (port, reg) \ - readb_relaxed((port)->regs + SPI_##reg) -#define spi_writeb (port, reg, value) \ - writeb_relaxed((value), (port)->regs + SPI_##reg) -#endif /* use PIO for small transfers, avoiding DMA setup/teardown overhead and * cache operations; better heuristics consider wordsize and bitrate. */
Signature · 1 line
2.20.1