Skip to contentSkip to conversation

rt-tests: cyclictest: Assume libnuma version 2 by default

PATCH In review John Kacur 2 participants 2 messages Sep 19, 2019 – Sep 23, 2019

lore
Share & tools
lore

John Kacur

author
#0 lore raw

PATCH 1/1 rt-tests: cyclictest: Assume libnuma version 2 by default

Most distributions have used libnuma version 2 for awhile now, so make it the default.

This doesn't prevent people from defining it as version 1, or compiling without numa.

---
 src/cyclictest/rt_numa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/cyclictest/rt_numa.h +1 -1
index e0f4b2e9d8b2..7adeb3c01324 100644
@@ -29,7 +29,7 @@ static int numa = 0;
 #include <numa.h>
 
 #ifndef LIBNUMA_API_VERSION
-#define LIBNUMA_API_VERSION 1
+#define LIBNUMA_API_VERSION 2
 #endif
 
 static void *
Signature · 1 line
2.20.1
#1 lore raw
Quoted 5 lines · John Kacur

Most distributions have used libnuma version 2 for awhile now, so make it the default.

This doesn't prevent people from defining it as version 1, or compiling without numa.

"LIBNUMA_API_VERSION 2" was introduced in version v2.0.2 of the numactl package. "LIBNUMA_API_VERSION 1" was never defined.
The version v2.0.2 was released in late 2008 as in more than a decade ago. Therefore I would suggest to just drop that compatibility layer and depend on the new API version. So if libnuma is used then the "one" please, otherwise no libnuma.

Sebastian