Skip to contentSkip to conversation

blkparse: man: add absolute timestamp printing option

PATCH In review Hiroaki Mihara 3 participants 3 messages Sep 20, 2019 – Sep 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blkparse: man: add absolute timestamp printing option

The functionality of printing out absolute timestamps has been implemented in code but not documented in man pages.

When comparing the timings of related events with block I/O traces, the absolute timestams play a key role. I think that the documentation of this might be beneficial to blktrace users.

The related commit was done in 2006 as follows,

Quoted 8 lines

commit 7bd4fd0a4fca645bb50a641afac1e460a4e32dfd

Author: Olaf Kirch <[email protected]>
Date:   Fri Dec 1 10:34:11 2006 +0100

[PATCH] Add timestamp support

URL of the above patch,
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/blktrace.git/commit/?id{d4fd0a4fca645bb50a641afac1e460a4e32dfd

---
 doc/blkparse.1 | 3 +++
 1 file changed, 3 insertions(+)
doc/blkparse.1 +3 -0
index 627b7b1..e494b6e 100644
@@ -368,6 +368,9 @@ Elapsed value in microseconds (\fI\-t\fR command line option)
 .IP \fBU\fR 4
 Payload unsigned integer
 
+.IP \fBz\fR 4
+The absolute time, as local time in your time zone, with no date displayed
+
 .PP
 Note that the user can optionally specify field display width, and optionally a
 left-aligned specifier. These precede field specifiers, with a '%' character,
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines · Hiroaki Mihara

The functionality of printing out absolute timestamps has been implemented in code but not documented in man pages.

When comparing the timings of related events with block I/O traces, the absolute timestams play a key role. I think that the documentation of this might be beneficial to blktrace users.

The related commit was done in 2006 as follows,

Quoted 8 lines

commit 7bd4fd0a4fca645bb50a641afac1e460a4e32dfd

Author: Olaf Kirch <[email protected]>
Date:   Fri Dec 1 10:34:11 2006 +0100

[PATCH] Add timestamp support

URL of the above patch,
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/blktrace.git/commit/?id{d4fd0a4fca645bb50a641afac1e460a4e32dfd

---
 doc/blkparse.1 | 3 +++
 1 file changed, 3 insertions(+)
doc/blkparse.1 +0 -0
index 627b7b1..e494b6e 100644

doc/blkparse.1 Elapsed value in microseconds (\fI\-t\fR command line option) · line 376

Quoted 9 lines
doc/blkparse.1 +3 -0
@@ -368,6 +368,9 @@ Elapsed value in microseconds (\fI\-t\fR command line option)
 .IP \fBU\fR 4
 Payload unsigned integer
 
+.IP \fBz\fR 4
+The absolute time, as local time in your time zone, with no date displayed
+
 .PP
 Note that the user can optionally specify field display width, and optionally a
 left-aligned specifier. These precede field specifiers, with a '%' character,
#2 lore raw
In reply to Hiroaki Mihara
Quoted 13 lines · Hiroaki Mihara

The functionality of printing out absolute timestamps has been implemented in code but not documented in man pages.

When comparing the timings of related events with block I/O traces, the absolute timestams play a key role. I think that the documentation of this might be beneficial to blktrace users.

The related commit was done in 2006 as follows,

Quoted 4 lines

commit 7bd4fd0a4fca645bb50a641afac1e460a4e32dfd

Author: Olaf Kirch <[email protected]>
Date:   Fri Dec 1 10:34:11 2006 +0100
Quoted 7 lines
Quoted 4 lines

[PATCH] Add timestamp support

URL of the above patch,
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/blktrace.git/commit/?id{d4fd0a4fca645bb50a641afac1e460a4e32dfd

I guess after 13 years it's about time to document it! Thanks, applied.

Signature · 1 line
Jens Axboe