Skip to contentSkip to conversation

powerpc:mark expected switch fall-throughs

PATCH New Lei Xu 1 participant 1 message Sep 20, 2019 PowerPC

lore
Share & tools
lore

Lei Xu

author
#0 lore raw

PATCH 1/1 powerpc:mark expected switch fall-throughs

When building kernel with -Wimplicit-fallthrough and -Werror, it reported the follwoing errors:

arch/powerpc/kernel/align.c: In function ‘emulate_spe’:
arch/powerpc/kernel/align.c:178:8: error: this statement may fall through [-Werror=implicit-fallthrough=]

    ret |= __get_user_inatomic(temp.v[3], p++);
        ^~

arch/powerpc/kernel/align.c:179:3: note: here
case 4:
^~~~
arch/powerpc/kernel/align.c:181:8: error: this statement may fall through [-Werror=implicit-fallthrough=]

    ret |= __get_user_inatomic(temp.v[5], p++);
        ^~

arch/powerpc/kernel/align.c:182:3: note: here
case 2:
^~~~
arch/powerpc/kernel/align.c:261:8: error: this statement may fall through [-Werror=implicit-fallthrough=]

    ret |= __put_user_inatomic(data.v[3], p++);
        ^~

arch/powerpc/kernel/align.c:262:3: note: here
case 4:
^~~~
arch/powerpc/kernel/align.c:264:8: error: this statement may fall through [-Werror=implicit-fallthrough=]

    ret |= __put_user_inatomic(data.v[5], p++);
        ^~

arch/powerpc/kernel/align.c:265:3: note: here
case 2:
^~~~
cc1: all warnings being treated as errors

This patch fixs the above errors.

---
 arch/powerpc/kernel/align.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/powerpc/kernel/align.c +4 -0
index 7107ad8..92045ed 100644
@@ -176,9 +176,11 @@ static int emulate_spe(struct pt_regs *regs, unsigned int reg,
 			ret |= __get_user_inatomic(temp.v[1], p++);
 			ret |= __get_user_inatomic(temp.v[2], p++);
 			ret |= __get_user_inatomic(temp.v[3], p++);
+			/* fall through */
 		case 4:
 			ret |= __get_user_inatomic(temp.v[4], p++);
 			ret |= __get_user_inatomic(temp.v[5], p++);
+			/* fall through */
 		case 2:
 			ret |= __get_user_inatomic(temp.v[6], p++);
 			ret |= __get_user_inatomic(temp.v[7], p++);
@@ -259,9 +261,11 @@ static int emulate_spe(struct pt_regs *regs, unsigned int reg,
 			ret |= __put_user_inatomic(data.v[1], p++);
 			ret |= __put_user_inatomic(data.v[2], p++);
 			ret |= __put_user_inatomic(data.v[3], p++);
+			/* fall through */
 		case 4:
 			ret |= __put_user_inatomic(data.v[4], p++);
 			ret |= __put_user_inatomic(data.v[5], p++);
+			/* fall through */
 		case 2:
 			ret |= __put_user_inatomic(data.v[6], p++);
 			ret |= __put_user_inatomic(data.v[7], p++);
Signature · 1 line
2.9.3