Skip to contentSkip to conversation

package/joe: license is GPL-2.0+

PATCH New Peter Korsgaard 4 participants 7 messages Sep 20, 2019 – Sep 30, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/joe: license is GPL-2.0+

Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8:

https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/

So change the license to GPL-2.0+

---
 package/joe/joe.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/joe/joe.mk +1 -1
index 9a3215c4e1..f0cac402e1 100644
@@ -6,7 +6,7 @@
 
 JOE_VERSION = 4.6
 JOE_SITE = http://downloads.sourceforge.net/project/joe-editor/JOE%20sources/joe-$(JOE_VERSION)
-JOE_LICENSE = GPL-1.0+
+JOE_LICENSE = GPL-2.0+
 JOE_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_NCURSES),y)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/joe: license is GPL-2.0+

Hi Peter,

Quoted 7 lines · Peter Korsgaard

Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8:

https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/

So change the license to GPL-2.0+

GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1].

What should we do? Should we switch to the new ones?

[1] https://spdx.org/licenses/GPL-2.0+.html

Yegor

Quoted 25 lines
---
 package/joe/joe.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/joe/joe.mk +1 -2
index 9a3215c4e1..f0cac402e1 100644
@@ -6,7 +6,7 @@
 
 JOE_VERSION = 4.6
 JOE_SITE = http://downloads.sourceforge.net/project/joe-editor/JOE%20sources/joe-$(JOE_VERSION)
-JOE_LICENSE = GPL-1.0+
+JOE_LICENSE = GPL-2.0+
 JOE_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_NCURSES),y)
--

2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH 1/1 package/joe: license is GPL-2.0+

Quoted 4 lines · On Fri, 20 Sep 2019 13:36:48 +0200 Yegor Yefremov <[email protected]>…

Hi Peter,

Quoted 1 line · Peter Korsgaard
Quoted 8 lines
Quoted 6 lines

Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8:

https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/

So change the license to GPL-2.0+

GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1].

I was aware of GPL-2.0+ being deprecated, but not GPL-2.0. And indeed SPDX now uses GPL-2.0-or-later (instead of GPL-2.0+) and GPL-2.0-only (instead of GPL-2.0).

Quoted 1 line

What should we do? Should we switch to the new ones?

Ideally yes, to follow SPDX. However, there are a few gotchas:

- The number of packages that need to be changed (though that's easily doable with sed)

- The potential backward compatibility breakage. If people have scripts/tools that parses our manifest.csv and interpret the license values, the renaming might break for them.

But maybe these are not that important, and sticking to SPDX is mort important ?

Anyway, that's a separate discussion from Peter's patch. Peter's patch is fine as-is, as it matches the current practice in Buildroot.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/joe: license is GPL-2.0+

In reply to Yegor Yefremov
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yegor" == Yegor Yefremov <[email protected]> writes:

Hi Peter,

Quoted 6 lines · Peter Korsgaard

Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8:

https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/

Quoted 7 lines
Quoted 1 line

So change the license to GPL-2.0+

GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1].

What should we do? Should we switch to the new ones?

[1] https://spdx.org/licenses/GPL-2.0+.html

That is a bigger discussion. I personally find the replacement "(GNU General Public License v2.0 only) or later" harder to read:

https://lists.denx.de/pipermail/u-boot/2015-August/223991.html

Are there any concrete advantages to changing this tree wide?

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 package/joe: license is GPL-2.0+

Quoted 16 lines · On Fri, 20 Sep 2019 13:56:20 +0200 Peter Korsgaard <[email protected]> wrote:
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yegor" == Yegor Yefremov <[email protected]> writes:

Hi Peter,

Quoted 7 lines · Peter Korsgaard

Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8:

https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/

So change the license to GPL-2.0+

GPL-2.0+, GPL-2.0 etc. identifiers are deprecated [1].

What should we do? Should we switch to the new ones?

Quoted 8 lines
Quoted 1 line

[1] https://spdx.org/licenses/GPL-2.0+.html

That is a bigger discussion. I personally find the replacement "(GNU General Public License v2.0 only) or later" harder to read:

https://lists.denx.de/pipermail/u-boot/2015-August/223991.html

Are there any concrete advantages to changing this tree wide?

The replacement is GPL-2.0-or-later, see https://spdx.org/licenses/.
I'm not sure where they got this "(GNU General Public License v2.0 only) or later" in the U-Boot discussion.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/1 package/joe: license is GPL-2.0+

In reply to Peter Korsgaard
Quoted 8 lines · Peter Korsgaard

Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8:

https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/

So change the license to GPL-2.0+

Applied to master, thanks.

As noted in the thread, changing GPL-2.0+ to GPL-2.0-or-later is a separate issue.

Regards,
Arnout

Quoted 18 lines
---
 package/joe/joe.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/joe/joe.mk +1 -1
index 9a3215c4e1..f0cac402e1 100644
@@ -6,7 +6,7 @@
 
 JOE_VERSION = 4.6
 JOE_SITE = http://downloads.sourceforge.net/project/joe-editor/JOE%20sources/joe-$(JOE_VERSION)
-JOE_LICENSE = GPL-1.0+
+JOE_LICENSE = GPL-2.0+
 JOE_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_NCURSES),y)
#6 lore raw

PATCH 1/1 package/joe: license is GPL-2.0+

In reply to Peter Korsgaard
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Joe changed the COPYING file from GPL-1.0 to GPL-2.0 in the development leading up to 3.8:

https://sourceforge.net/p/joe-editor/mercurial/ci/d731f9b3794bc4c896f2efa1c97ac2c82c3365ac/

So change the license to GPL-2.0+

Committed to 2019.02.x, 2019.05.x and 2019.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard