Skip to contentSkip to conversation

PCI: tegra: include linux/pinctrl/consumer.h

PATCH In review Arnd Bergmann 3 participants 3 messages Sep 20, 2019

Subsystems (3)
PCI Tegra architecture support PCI native host bridge and endpoint drivers
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 PCI: tegra: include linux/pinctrl/consumer.h

Without this, we can run into a build failure:

drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]

Fixes ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/pcie-tegra194.c +1 -0
index 09ed8e473cff..f89f5acee72d 100644
@@ -22,6 +22,7 @@
 #include <linux/of_pci.h>
 #include <linux/pci.h>
 #include <linux/phy/phy.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/random.h>
Signature · 1 line
2.20.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Arnd Bergmann

Without this, we can run into a build failure:

drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]

Fixes ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
Signed-off-by Arnd Bergmann <[email protected]>

Thanks for this. Another fix for this came in earlier today:

https://patchwork.ozlabs.org/patch/1165139/

Reviewed-by Andrew Murray <[email protected]>

Thanks,

Andrew Murray

Quoted 19 lines
---
 drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/pcie-tegra194.c +1 -0
index 09ed8e473cff..f89f5acee72d 100644
@@ -22,6 +22,7 @@
 #include <linux/of_pci.h>
 #include <linux/pci.h>
 #include <linux/phy/phy.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/random.h>
Signature · 1 line
2.20.0
#2 lore raw
Quoted 11 lines · Andrew Murray
Quoted 6 lines · Arnd Bergmann

Without this, we can run into a build failure:

drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]

Fixes ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
Signed-off-by Arnd Bergmann <[email protected]>

Thanks for this. Another fix for this came in earlier today:

https://patchwork.ozlabs.org/patch/1165139/

I have applied it since it came in earlier.

Thanks,
Lorenzo

Quoted 25 lines
Reviewed-by Andrew Murray <[email protected]>

Thanks,

Andrew Murray

Quoted 19 lines
---
 drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/pcie-tegra194.c +1 -0
index 09ed8e473cff..f89f5acee72d 100644
@@ -22,6 +22,7 @@
 #include <linux/of_pci.h>
 #include <linux/pci.h>
 #include <linux/phy/phy.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/random.h>
Signature · 1 line
2.20.0