Skip to contentSkip to conversation

arm64: update Kconfig to better handle CMDLINE

PATCH In review [email protected] 2 participants 4 messages Sep 20, 2019 – Oct 1, 2019 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: update Kconfig to better handle CMDLINE

From: Jan Kaisrlik <[email protected]>

Added a menu to choose how to CMDLINE will be handled. Config strings were copied from arm32 port.

---
 arch/arm64/Kconfig | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/Kconfig +18 -0
index 3adcec05b1f6..b1dd948f9665 100644
@@ -1538,6 +1538,23 @@ config CMDLINE
 	  entering them here. As a minimum, you should specify the the
 	  root device (e.g. root=/dev/nfs).
 
+choice
+	prompt "Kernel command line type" if CMDLINE != ""
+	default CMDLINE_FROM_BOOTLOADER
+
+config CMDLINE_FROM_BOOTLOADER
+	bool "Use bootloader kernel arguments if available"
+	help
+	  Uses the command-line options passed by the boot loader. If
+	  the boot loader doesn't provide any, the default kernel command
+	  string provided in CMDLINE will be used.
+
+config CMDLINE_EXTEND
+	bool "Extend bootloader kernel arguments"
+	help
+	  The command-line arguments provided by the boot loader will be
+	  appended to the default kernel command string.
+
 config CMDLINE_FORCE
 	bool "Always use the default kernel command string"
 	help
@@ -1545,6 +1562,7 @@ config CMDLINE_FORCE
 	  loader passes other arguments to the kernel.
 	  This is useful if you cannot or don't want to change the
 	  command-line options your boot loader passes to the kernel.
+endchoice
 
 config EFI_STUB
 	bool
Signature · 7 lines
2.23.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

+ linux-kernel

Quoted 50 lines · On Fri, Sep 20, 2019 at 6:43 PM <[email protected]> wrote:

From: Jan Kaisrlik <[email protected]>

Added a menu to choose how to CMDLINE will be handled. Config strings were copied from arm32 port.

---
 arch/arm64/Kconfig | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/Kconfig +18 -1
index 3adcec05b1f6..b1dd948f9665 100644
@@ -1538,6 +1538,23 @@ config CMDLINE
          entering them here. As a minimum, you should specify the the
          root device (e.g. root=/dev/nfs).
 
+choice
+       prompt "Kernel command line type" if CMDLINE != ""
+       default CMDLINE_FROM_BOOTLOADER
+
+config CMDLINE_FROM_BOOTLOADER
+       bool "Use bootloader kernel arguments if available"
+       help
+         Uses the command-line options passed by the boot loader. If
+         the boot loader doesn't provide any, the default kernel command
+         string provided in CMDLINE will be used.
+
+config CMDLINE_EXTEND
+       bool "Extend bootloader kernel arguments"
+       help
+         The command-line arguments provided by the boot loader will be
+         appended to the default kernel command string.
+
 config CMDLINE_FORCE
        bool "Always use the default kernel command string"
        help
@@ -1545,6 +1562,7 @@ config CMDLINE_FORCE
          loader passes other arguments to the kernel.
          This is useful if you cannot or don't want to change the
          command-line options your boot loader passes to the kernel.
+endchoice
 
 config EFI_STUB
        bool
--

2.23.0

maintainer
#2 lore raw
In reply to [email protected]
Quoted 2 lines · On Fri, Sep 20, 2019 at 06:42:49PM +0200, [email protected] wrote:

Added a menu to choose how to CMDLINE will be handled. Config strings were copied from arm32 port.

This was proposed before but we rejected it. Do you have a good reason, other than arm32 having it?

https://patchwork.kernel.org/patch/9459341/

Signature · 6 lines
Catalin

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Hello Catalin,

sorry, I did not notice the similar patch already exists.

Quoted 9 lines · Catalin Marinas
Quoted 2 lines · On Fri, Sep 20, 2019 at 06:42:49PM +0200, [email protected] wrote:

Added a menu to choose how to CMDLINE will be handled. Config strings were copied from arm32 port.

This was proposed before but we rejected it. Do you have a good reason, other than arm32 having it?

https://patchwork.kernel.org/patch/9459341/

I have a similar reason like Geoff from the mentioned patch. The main difference is I'm not able to modify kernel arguments in the bootloader. Also, I observe that Risc-v also adopt this patch and maybe others can find it useful as well.

Let me know if you would like to improve it.

Best regards,
Jan Kaisrlik

Quoted 3 lines

--
Catalin

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel