Skip to contentSkip to conversation

drm: Remove redundant of_device_is_available check

PATCH In review [email protected] 2 participants 2 messages Sep 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: Remove redundant of_device_is_available check

From: Ondrej Jirman <[email protected]>

This check is already performed by of_graph_get_remote_node. No need to repeat it immediately after the call.

---
 drivers/gpu/drm/drm_of.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/drm_of.c +0 -5
index 43d89dd59c6b..0ca58803ba46 100644
@@ -247,17 +247,12 @@ int drm_of_find_panel_or_bridge(const struct device_node *np,
 		*panel = NULL;
 
 	remote = of_graph_get_remote_node(np, port, endpoint);
 	if (!remote)
 		return -ENODEV;
 
-	if (!of_device_is_available(remote)) {
-		of_node_put(remote);
-		return -ENODEV;
-	}
-
 	if (panel) {
 		*panel = of_drm_find_panel(remote);
 		if (!IS_ERR(*panel))
 			ret = 0;
 		else
 			*panel = NULL;
Signature · 1 line
2.23.0
#1 lore raw
Quoted 7 lines · On Fri, Sep 20, 2019 at 1:29 PM <[email protected]> wrote:

From: Ondrej Jirman <[email protected]>

This check is already performed by of_graph_get_remote_node. No need to repeat it immediately after the call.

Thanks for your patch, I've applied it to drm-misc-next.

Sean

Quoted 27 lines
---
 drivers/gpu/drm/drm_of.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/drm_of.c +0 -6
index 43d89dd59c6b..0ca58803ba46 100644
@@ -247,17 +247,12 @@ int drm_of_find_panel_or_bridge(const struct device_node *np,
                *panel = NULL;
 
        remote = of_graph_get_remote_node(np, port, endpoint);
        if (!remote)
                return -ENODEV;
 
-       if (!of_device_is_available(remote)) {
-               of_node_put(remote);
-               return -ENODEV;
-       }
-
        if (panel) {
                *panel = of_drm_find_panel(remote);
                if (!IS_ERR(*panel))
                        ret = 0;
                else
                        *panel = NULL;
--
Quoted 2 lines

2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel