Skip to contentSkip to conversation

CAIF Kconfig fixes

PATCH In review [email protected] 2 participants 5 messages Oct 2, 2019

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

cover CAIF Kconfig fixes

This series of patches cleans up the CAIF Kconfig menus in net/caif/Kconfig and drivers/net/caif/Kconfig and also puts the CAIF Transport drivers into their own sub-menu.

 drivers/net/caif/Kconfig |   16 ++++++++++++----
 net/caif/Kconfig         |   10 +++++-----
 2 files changed, 17 insertions(+), 9 deletions(-)
author
#1 lore raw

PATCH 1/3 Clean up the net/caif/Kconfig menu

Clean up the net/caif/Kconfig menu:
- remove extraneous space
- minor language tweaks
- fix punctuation

Signed-off-by Randy Dunlap <[email protected]>
Cc Randy Dunlap <[email protected]>
---
 net/caif/Kconfig |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
net/caif/Kconfig +5 -5
@@ -13,11 +13,11 @@ menuconfig CAIF
 	with its modems. It is accessed from user space as sockets (PF_CAIF).
 
 	Say Y (or M) here if you build for a phone product (e.g. Android or
-	MeeGo ) that uses CAIF as transport, if unsure say N.
+	MeeGo) that uses CAIF as transport. If unsure say N.
 
 	If you select to build it as module then CAIF_NETDEV also needs to be
-	built as modules. You will also need to say yes to any CAIF physical
-	devices that your platform requires.
+	built as a module. You will also need to say Y (or M) to any CAIF
+	physical devices that your platform requires.
 
 	See Documentation/networking/caif for a further explanation on how to
 	use and configure CAIF.

@@ -37,7 +37,7 @@ config CAIF_NETDEV
 	default CAIF
 	---help---
 	Say Y if you will be using a CAIF based GPRS network device.
-	This can be either built-in or a loadable module,
+	This can be either built-in or a loadable module.
 	If you select to build it as a built-in then the main CAIF device must
 	also be a built-in.
 	If unsure say Y.

@@ -48,7 +48,7 @@ config CAIF_USB
 	default n
 	---help---
 	Say Y if you are using CAIF over USB CDC NCM.
-	This can be either built-in or a loadable module,
+	This can be either built-in or a loadable module.
 	If you select to build it as a built-in then the main CAIF device must
 	also be a built-in.
 	If unsure say N.
author
#2 lore raw

PATCH 2/3 Isolate CAIF transport drivers into their own menu

In reply to [email protected]

Isolate CAIF transport drivers into their own menu.

This cleans up the main Network device support menu, makes it easier to find the CAIF drivers, and makes it easier to enable/disable them as a group.

Signed-off-by Randy Dunlap <[email protected]>
Cc Randy Dunlap <[email protected]>
---
 drivers/net/caif/Kconfig |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/net/caif/Kconfig +9 -1
@@ -3,7 +3,13 @@
 # CAIF physical drivers
 #
 
-comment "CAIF transport drivers"
+menuconfig CAIF_DRIVERS
+	bool "CAIF transport drivers"
+	depends on CAIF
+	help
+	  Enable this to see CAIF physical drivers.
+
+if CAIF_DRIVERS
 
 config CAIF_TTY
 	tristate "CAIF TTY transport driver"

@@ -55,3 +61,5 @@ config CAIF_VIRTIO
 if CAIF_VIRTIO
 source "drivers/vhost/Kconfig.vringh"
 endif
+
+endif # CAIF_DRIVERS
author
#3 lore raw

PATCH 3/3 Minor fixes to the CAIF Transport drivers Kconfig file

In reply to [email protected]

Minor fixes to the CAIF Transport drivers Kconfig file:

- end sentence with period
- capitalize CAIF acronym

Signed-off-by Randy Dunlap <[email protected]>
Cc Randy Dunlap <[email protected]>
---
 drivers/net/caif/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/caif/Kconfig +3 -3
@@ -28,7 +28,7 @@ config CAIF_SPI_SLAVE
 	The CAIF Link layer SPI Protocol driver for Slave SPI interface.
 	This driver implements a platform driver to accommodate for a
 	platform specific SPI device. A sample CAIF SPI Platform device is
-	provided in Documentation/networking/caif/spi_porting.txt
+	provided in <file:Documentation/networking/caif/spi_porting.txt>.
 
 config CAIF_SPI_SYNC
 	bool "Next command and length in start of frame"

@@ -44,7 +44,7 @@ config CAIF_HSI
        depends on CAIF
        default n
        ---help---
-       The caif low level driver for CAIF over HSI.
+       The CAIF low level driver for CAIF over HSI.
        Be aware that if you enable this then you also need to
        enable a low-level HSI driver.
 

@@ -56,7 +56,7 @@ config CAIF_VIRTIO
 	select GENERIC_ALLOCATOR
 	default n
 	---help---
-	The caif driver for CAIF over Virtio.
+	The CAIF driver for CAIF over Virtio.
 
 if CAIF_VIRTIO
 source "drivers/vhost/Kconfig.vringh"
maintainer
#4 lore raw
In reply to [email protected]

From: [email protected]
Date: Tue, 01 Oct 2019 16:03:58 -0700

Quoted 4 lines

This series of patches cleans up the CAIF Kconfig menus in net/caif/Kconfig and drivers/net/caif/Kconfig and also puts the CAIF Transport drivers into their own sub-menu.

Series applied to net-next. Please fix your From: field in future submissions, thanks.