gen-insn-attr-x86.awk: Fix regexp warnings
PATCH 1/1 gen-insn-attr-x86.awk: Fix regexp warnings
This patch fixes the regexp warnings shown below:
GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator
The ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
[Test-run]
awk -f /home/sasha/torvalds/arch/x86/tools/gen-insn-attr-x86.awk \ /home/sasha/torvalds/arch/x86/lib/x86-opcode-map.txt >tmp/inat-tables.c
diff -U0 /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c \tmp/inat-tables.c; echo $?
0
[Debugging output]
DBG:ext:(66&F2)
DBG:match(ext, ...):(66&F2)
DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\)
--- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/tools/gen-insn-attr-x86.awk +2 -2
@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4
@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index
--
2.23.0
kbuild test robot
build botThank you for the patch! Perhaps something to improve:
Hi Alexander,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Alexander-Kapshuk/gen-insn-attr-x86-awk-Fix-regexp-warnings/20190921-194307
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
:::::: branch date: 73 minutes ago
:::::: commit date: 73 minutes agoIf you fix the issue, kindly add following tag
All warnings (new ones prefixed by >>):
>> Warning: Kernel ABI header at 'tools/arch/x86/tools/gen-insn-attr-x86.awk' differs from latest version at 'arch/x86/tools/gen-insn-attr-x86.awk'
55 real 10 user 5 sys 29.61% cpu make prepare
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
PATCH RESEND 1/1 gen-insn-attr-x86.awk: Fix regexp warnings
This patch fixes the regexp warnings shown below:
GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator
The ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
[Test-run]
awk -f arch/x86/tools/gen-insn-attr-x86.awk \ arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.c
diff arch/x86/lib/inat-tables.c ~/tmp/inat-tables.c; echo $? 0
awk -f tools/arch/x86/tools/gen-insn-attr-x86.awk \ tools/arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.c
diff tools/objtool/arch/x86/lib/inat-tables.c ~/tmp/inat-tables.c; echo $? 0
[Debugging output]
DBG:ext:(66&F2)
DBG:match(ext, ...):(66&F2)
DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\)
--- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- tools/arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/x86/tools/gen-insn-attr-x86.awk +2 -2
@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4
@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index
tools/arch/x86/tools/gen-insn-attr-x86.awk +2 -2
@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4
@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index
--
2.23.0
Borislav Petkov
maintainerQuoted 7 lines · Alexander Kapshuk
This patch fixes the regexp warnings shown below:
GEN/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operatorThe ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
How do you trigger this?
I don't see it in my builds so it looks like environment thing. What flavor of awk is yours?
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 15 lines · Borislav Petkov
Quoted 7 lines · Alexander Kapshuk
This patch fixes the regexp warnings shown below:
GEN/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operatorThe ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
How do you trigger this?
I don't see it in my builds so it looks like environment thing. What flavor of awk is yours?
Quoted 7 lines
Thx.
--
Regards/Gruss,
Boris.
gawk 5.0.1-1 on Arch Linux.
Borislav Petkov
maintainerQuoted 18 lines · Alexander Kapshuk
Quoted 17 lines · Borislav Petkov
Quoted 7 lines · Alexander Kapshuk
This patch fixes the regexp warnings shown below:
GEN/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operatorThe ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
How do you trigger this?
I don't see it in my builds so it looks like environment thing. What flavor of awk is yours?
Thx.
Quoted 7 lines
Quoted 5 lines
--
Regards/Gruss,
Boris.gawk 5.0.1-1 on Arch Linux.
Ok, looks like they're enforcing it in v5 as v4 which I have doesn't complain. Please add that fact to the commit message.
More review as a reply to your second patch.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteBorislav Petkov
maintainer+ Masami.
Quoted 1 line · Alexander Kapshuk
This patch fixes the regexp warnings shown below:
Avoid having "This patch" or "This commit" in the commit message. It is tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
Quoted 6 lines
GEN
/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operatorThe ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
I could use a reasoning here, as in, "gawk manual doesn't have those two characters in the list here:
https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html"
or so.
Quoted 5 lines
[Test-run]
awk -f arch/x86/tools/gen-insn-attr-x86.awk \ arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.c
Quoted 8 lines
diff
arch/x86/lib/inat-tables.c~/tmp/inat-tables.c; echo $? 0awk -f tools/arch/x86/tools/gen-insn-attr-x86.awk \ tools/arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.cdiff
tools/objtool/arch/x86/lib/inat-tables.c~/tmp/inat-tables.c; echo $? 0
No need for that - just say that diffing the output before and after shows no changes.
Quoted 4 lines
[Debugging output]
DBG:ext:(66&F2)
DBG:match(ext, ...):(66&F2)
DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\)
That is supposed to say what exactly? That it still does what it is expected to do?
Leaving in the rest for Masami.
Thx.
Quoted 54 lines
Signed-off-by Alexander Kapshuk <[email protected]>Reported-by kbuild test robot <[email protected]>--- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- tools/arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)arch/x86/tools/gen-insn-attr-x86.awk +2
-2@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get indextools/arch/x86/tools/gen-insn-attr-x86.awk +2
-3@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index --2.23.0
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 46 lines · Borislav Petkov
+ Masami.
Quoted 1 line · Alexander Kapshuk
This patch fixes the regexp warnings shown below:
Avoid having "This patch" or "This commit" in the commit message. It is tautologically useless.
Also, do
$ git grep 'This patch' Documentation/processfor more details.
Quoted 6 lines
GEN
/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operatorThe ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
I could use a reasoning here, as in, "gawk manual doesn't have those two characters in the list here:
https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html"
or so.
Quoted 5 lines
[Test-run]
awk -f arch/x86/tools/gen-insn-attr-x86.awk \ arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.cQuoted 8 lines
diff
arch/x86/lib/inat-tables.c~/tmp/inat-tables.c; echo $? 0awk -f tools/arch/x86/tools/gen-insn-attr-x86.awk \ tools/arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.cdiff
tools/objtool/arch/x86/lib/inat-tables.c~/tmp/inat-tables.c; echo $? 0No need for that - just say that diffing the output before and after shows no changes.
Quoted 7 lines
Quoted 4 lines
[Debugging output]
DBG:ext:(66&F2)
DBG:match(ext, ...):(66&F2)
DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\)That is supposed to say what exactly? That it still does what it is expected to do?
That was the intention.
Thanks for reviewing the patch.
I'll wait to hear from Masami before resending the patch.
Quoted 9 lines
Leaving in the rest for Masami.
Thx.
--
Regards/Gruss,
Boris.
Masami Hiramatsu
Acked-byQuoted 18 lines · On Mon, 23 Sep 2019 12:31:39 +0200 Borislav Petkov <[email protected]> wrote:
+ Masami.
Quoted 1 line · Alexander Kapshuk
This patch fixes the regexp warnings shown below:
Avoid having "This patch" or "This commit" in the commit message. It is tautologically useless.
Also, do
$ git grep 'This patch' Documentation/processfor more details.
Quoted 4 lines
GEN
/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator
Quoted 7 lines
Quoted 2 lines
The ':' and '&' characters need not escaping when used in string constants as part of regular expressions.
I could use a reasoning here, as in, "gawk manual doesn't have those two characters in the list here:
https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html"
Thank you for pointing it out. It is good to refer this page as the reason of this patch.
I couldn't remember why I added those escapes on those... (maybe for compatibility with mawk? anyway, nowadays there seems no problem)
Quoted 25 lines
or so.
Quoted 5 lines
[Test-run]
awk -f arch/x86/tools/gen-insn-attr-x86.awk \ arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.cQuoted 8 lines
diff
arch/x86/lib/inat-tables.c~/tmp/inat-tables.c; echo $? 0awk -f tools/arch/x86/tools/gen-insn-attr-x86.awk \ tools/arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.cdiff
tools/objtool/arch/x86/lib/inat-tables.c~/tmp/inat-tables.c; echo $? 0No need for that - just say that diffing the output before and after shows no changes.
Quoted 4 lines
[Debugging output]
DBG:ext:(66&F2)
DBG:match(ext, ...):(66&F2)
DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\)
Quoted 4 lines
That is supposed to say what exactly? That it still does what it is expected to do?
Leaving in the rest for Masami.
This looks good to me, except for the description pointed above. So feel free to add my ack on your patch on next version.
Thank you,
Quoted 63 lines
Thx.
Quoted 54 lines
Signed-off-by Alexander Kapshuk <[email protected]>Reported-by kbuild test robot <[email protected]>--- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- tools/arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)arch/x86/tools/gen-insn-attr-x86.awk +2
-2@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get indextools/arch/x86/tools/gen-insn-attr-x86.awk +2
-3@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index --2.23.0
Signature · 4 lines
Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Signature · 1 line
Masami Hiramatsu <[email protected]>
PATCH RESEND 1/1 gen-insn-attr-x86.awk: Fix regexp warnings
gawk 5.0.1 generates the regexp warnings shown below:
GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator
Ealier versions of gawk are not known to generate these warnings.
The gawk manual referenced below does not list characters ':' and '&' as needing escaping, so 'unescape' them.
https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html
Running diff on the output generated by the script before and after applying the patch reported no differences.
--- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- tools/arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/x86/tools/gen-insn-attr-x86.awk +2 -2
@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4
@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index
tools/arch/x86/tools/gen-insn-attr-x86.awk +2 -2
@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4
@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index
--
2.23.0
Borislav Petkov
maintainerQuoted 11 lines · Alexander Kapshuk
gawk 5.0.1 generates the regexp warnings shown below:
GEN/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operatorEalier versions of gawk are not known to generate these warnings.
The gawk manual referenced below does not list characters ':' and '&' as needing escaping, so 'unescape' them.
https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html
Quoted 6 lines
Running diff on the output generated by the script before and after applying the patch reported no differences.
Signed-off-by Alexander Kapshuk <[email protected]>Reported-by kbuild test robot <[email protected]>Reviewed-by Borislav Petkov <[email protected]>
This is not how Reviewed-by works. Read here:
for future reference. I fixed it up now.
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 26 lines · Borislav Petkov
Quoted 11 lines · Alexander Kapshuk
gawk 5.0.1 generates the regexp warnings shown below:
GEN/home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk:../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk:../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operatorEalier versions of gawk are not known to generate these warnings.
The gawk manual referenced below does not list characters ':' and '&' as needing escaping, so 'unescape' them.
https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.htmlQuoted 6 lines
Running diff on the output generated by the script before and after applying the patch reported no differences.
Signed-off-by Alexander Kapshuk <[email protected]>Reported-by kbuild test robot <[email protected]>Reviewed-by Borislav Petkov <[email protected]>This is not how Reviewed-by works. Read here:
for future reference. I fixed it up now.
Quoted 7 lines
Thx.
--
Regards/Gruss,
Boris.
Thank you for taking in the patch and clarifying my misunderstanding about the use of 'Reviewed-by'.
Point taken.
[tip: core/objtool] x86/insn: Fix awk regexp warnings
In reply to Alexander KapshukThe following commit has been merged into the core/objtool branch of tip:
The following commit has been merged into the core/objtool branch of tip:
Commit-ID: 700c1018b86d0d4b3f1f2d459708c0cdf42b521d Gitweb: https://git.kernel.org/tip/700c1018b86d0d4b3f1f2d459708c0cdf42b521d Author: Alexander Kapshuk <[email protected]> AuthorDate: Tue, 24 Sep 2019 07:46:59 +03:00 Committer: Borislav Petkov <[email protected]> CommitterDate: Tue, 01 Oct 2019 12:13:16 +02:00
x86/insn: Fix awk regexp warnings
gawk 5.0.1 generates the following regexp warnings:
GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator
Ealier versions of gawk are not known to generate these warnings. The gawk manual referenced below does not list characters ':' and '&' as needing escaping, so 'unescape' them. See
https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html
for more info.
Running diff on the output generated by the script before and after applying the patch reported no differences.
[ bp: Massage commit message. ]
--- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- tools/arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/x86/tools/gen-insn-attr-x86.awk +2 -2
@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4
@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index
tools/arch/x86/tools/gen-insn-attr-x86.awk +2 -2
@@ -69,7 +69,7 @@ BEGIN { lprefix1_expr = "\\((66|!F3)\\)" lprefix2_expr = "\\(F3\\)" - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" lprefix_expr = "\\((66|F2|F3)\\)" max_lprefix = 4
@@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) return add_flags(imm, mod) } -/^[0-9a-f]+\:/ { +/^[0-9a-f]+:/ { if (NR == 1) next # get index