Skip to contentSkip to conversation

Fix issues reported by Coccinelle

PATCH In review Saiyam Doshi 3 participants 5 messages Sep 17, 2019 – Sep 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover Fix issues reported by Coccinelle

Using cocciecheck to ensure there are no semantic issues in i2c-qup driver.

Refer below links for more information.
http://coccinelle.lip6.fr
https://bottest.wiki.kernel.org/coccicheck

Changes in v2:
* Updated changelog as suggested by Markus Elfring.

v1:
https://patchwork.ozlabs.org/cover/1163043/

Saiyam Doshi (3):
i2c: qup: remove explicit conversion to boolean
i2c: qup: Remove dev_err() log after platform_get_irq*() failure
i2c: qup: Use devm_platform_ioremap_resource helper

 drivers/i2c/busses/i2c-qup.c | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

--
2.20.1

#1 lore raw
Quoted 2 lines

Using cocciecheck to ensure there are no semantic issues in i2c-qup driver.

* This wording contains a typo.

* I would prefer to refer to a desired reduction of a few source code quality concerns.

Quoted 1 line

Changes in …

Can such a prefix be omitted?

Regards,
Markus

#2 lore raw
Quoted 4 lines · Markus Elfring
Quoted 2 lines

Using cocciecheck to ensure there are no semantic issues in i2c-qup driver.

* This wording contains a typo.

Doesn't matter to me for a cover letter as long as we can understand it.

Quoted 2 lines

* I would prefer to refer to a desired reduction of a few source code quality concerns.

Not needed. I understand what is going on here.

Quoted 3 lines
Quoted 1 line

Changes in …

Can such a prefix be omitted?

Why? I think it makes sense?

#3 lore raw
Quoted 4 lines
Quoted 2 lines

* I would prefer to refer to a desired reduction of a few source code quality concerns.

Not needed. I understand what is going on here.

I suggest to reconsider the interpretation of “ensurance” after only a few source code places were adjusted.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Changes in …

Can such a prefix be omitted?

Why? I think it makes sense?

Can the specification of a version identifier be occasionally sufficient already?

Regards,
Markus

#4 lore raw
In reply to Wolfram Sang
Quoted 4 lines · Wolfram Sang
Quoted 3 lines · Markus Elfring
Quoted 2 lines

Using cocciecheck to ensure there are no semantic issues in i2c-qup driver.

Quoted 8 lines
Quoted 1 line

* This wording contains a typo.

Doesn't matter to me for a cover letter as long as we can understand it.

Quoted 2 lines

* I would prefer to refer to a desired reduction of a few source code quality concerns.

Not needed. I understand what is going on here.

Markus - By "ensure", I mean there are no further cocciecheck issues at this point in time. And further, what changed is covered in individual patch changelog. So, I think this information is fine in cover.

Quoted 1 line
Quoted 1 line

Can such a prefix be omitted?

Can be, but I like to keep it.

Thanks for review.

-Saiyam