Skip to contentSkip to conversation

package/libsodium: add config for full build

PATCH Superseded Adrien Gallouët 2 participants 3 messages Sep 22, 2019 – Sep 23, 2019

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/libsodium: add config for full build

A new default option is added to build all functions.

---
Changes v2 -> v3:
- add a better help (suggested by Arnout Vandecappelle)

Changes v1 -> v2:
- full build (suggested by Arnout Vandecappelle)

---
 package/libsodium/Config.in    | 12 ++++++++++++
 package/libsodium/libsodium.mk |  4 ++++
 2 files changed, 16 insertions(+)
package/libsodium/Config.in +12 -0
index 47b9bb350c..518b0532ed 100644
@@ -4,3 +4,15 @@ config BR2_PACKAGE_LIBSODIUM
 	  A modern and easy-to-use crypto library.
 
 	  http://libsodium.org/
+
+if BR2_PACKAGE_LIBSODIUM
+
+config BR2_PACKAGE_LIBSODIUM_FULL
+	bool "all functions"
+	default y
+	help
+	  Build all seldom used and obsolete functions. Without
+	  this option, only the minimal set of normally used
+	  functions is built.
+
+endif
package/libsodium/libsodium.mk +4 -0
index a94a8271c5..9afa09ff37 100644
@@ -14,5 +14,9 @@ ifeq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),)
 LIBSODIUM_CONF_OPTS += --disable-pie
 endif
 
+ifeq ($(BR2_PACKAGE_LIBSODIUM_FULL),)
+LIBSODIUM_CONF_OPTS += --enable-minimal
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
2.19.1
#1 lore raw

PATCH v3 1/1 package/libsodium: add config for full build

Quoted 3 lines · On Sun, 22 Sep 2019 20:04:10 +0000 Adrien Gallou?t <[email protected]> wrote:

A new default option is added to build all functions.

I have missed the original discussion, but what is the reason to enable this by default ? It should be explained in the commit log I believe.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v3 1/1 package/libsodium: add config for full build

Hi Thomas,

Quoted 12 lines · Thomas Petazzoni
Quoted 3 lines · On Sun, 22 Sep 2019 20:04:10 +0000 Adrien Gallou?t <[email protected]> wrote:

A new default option is added to build all functions.

I have missed the original discussion, but what is the reason to enable this by default ? It should be explained in the commit log I believe.

Quoted 7 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

I submitted a new patch with a more detailed commit log.

Regards,
Adrien