Skip to contentSkip to conversation

rtw88: configure firmware after HCI started

PATCH In review [email protected] 2 participants 2 messages Sep 23, 2019 – Sep 24, 2019 Realtek wireless driver (rtw88)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 rtw88: configure firmware after HCI started

From: Yan-Hsuan Chuang <[email protected]>

After firmware has been downloaded, driver should send some information to it through H2C commands. Those H2C commands are transmitted through TX path.

But before HCI has been started, the TX path is not working completely. Such as PCI interfaces, the interrupts are not enabled, hence TX interrupts will not be issued after H2C skb has been DMAed to the device. And the H2C skbs will not be released until the device is powered off.

---
 drivers/net/wireless/realtek/rtw88/mac.c  | 3 ---
 drivers/net/wireless/realtek/rtw88/main.c | 4 ++++
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/net/wireless/realtek/rtw88/mac.c +0 -3
index fc14b37d927d..b61b073031e5 100644
@@ -707,9 +707,6 @@ int rtw_download_firmware(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
 	rtwdev->h2c.last_box_num = 0;
 	rtwdev->h2c.seq = 0;
 
-	rtw_fw_send_general_info(rtwdev);
-	rtw_fw_send_phydm_info(rtwdev);
-
 	rtw_flag_set(rtwdev, RTW_FLAG_FW_RUNNING);
 
 	return 0;
drivers/net/wireless/realtek/rtw88/main.c +4 -0
index fc8f6213fc8f..6dd457741b15 100644
@@ -704,6 +704,10 @@ static int rtw_power_on(struct rtw_dev *rtwdev)
 		goto err_off;
 	}
 
+	/* send H2C after HCI has started */
+	rtw_fw_send_general_info(rtwdev);
+	rtw_fw_send_phydm_info(rtwdev);
+
 	wifi_only = !rtwdev->efuse.btcoex;
 	rtw_coex_power_on_setting(rtwdev);
 	rtw_coex_init_hw_config(rtwdev, wifi_only);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · <[email protected]> wrote:

From: Yan-Hsuan Chuang <[email protected]>

After firmware has been downloaded, driver should send some information to it through H2C commands. Those H2C commands are transmitted through TX path.

Quoted 7 lines

But before HCI has been started, the TX path is not working completely. Such as PCI interfaces, the interrupts are not enabled, hence TX interrupts will not be issued after H2C skb has been DMAed to the device. And the H2C skbs will not be released until the device is powered off.

Patch applied to wireless-drivers.git, thanks.

0b8dc6abbdb9 rtw88: configure firmware after HCI started

Signature · 3 lines
https://patchwork.kernel.org/patch/11155999/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches