Skip to contentSkip to conversation

drm/komeda: Use devm_platform_ioremap_resource() in komeda_dev_create()

PATCH Applied Markus Elfring 3 participants 4 messages Sep 21, 2019 – Nov 6, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/komeda: Use devm_platform_ioremap_resource() in komeda_dev_create()

From: Markus Elfring <[email protected]>
Date: Sat, 21 Sep 2019 19:43:51 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/gpu/drm/arm/display/komeda/komeda_dev.c +1 -8
index ca64a129c594..a387d923962e 100644
@@ -172,19 +172,12 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	const struct komeda_product_data *product;
 	struct komeda_dev *mdev;
-	struct resource *io_res;
 	int err = 0;
 
 	product = of_device_get_match_data(dev);
 	if (!product)
 		return ERR_PTR(-ENODEV);
 
-	io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!io_res) {
-		DRM_ERROR("No registers defined.\n");
-		return ERR_PTR(-ENODEV);
-	}
-
 	mdev = devm_kzalloc(dev, sizeof(*mdev), GFP_KERNEL);
 	if (!mdev)
 		return ERR_PTR(-ENOMEM);
@@ -192,7 +185,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	mutex_init(&mdev->lock);
 
 	mdev->dev = dev;
-	mdev->reg_base = devm_ioremap_resource(dev, io_res);
+	mdev->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mdev->reg_base)) {
 		DRM_ERROR("Map register space failed.\n");
 		err = PTR_ERR(mdev->reg_base);

--
2.23.0

#1 lore raw
Quoted 37 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sat, 21 Sep 2019 19:43:51 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/gpu/drm/arm/display/komeda/komeda_dev.c +0 -7
index ca64a129c594..a387d923962e 100644
@@ -172,19 +172,12 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	const struct komeda_product_data *product;
 	struct komeda_dev *mdev;
-	struct resource *io_res;
 	int err = 0;
 
 	product = of_device_get_match_data(dev);
 	if (!product)
 		return ERR_PTR(-ENODEV);
 
-	io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!io_res) {
-		DRM_ERROR("No registers defined.\n");
-		return ERR_PTR(-ENODEV);
-	}
-
 	mdev = devm_kzalloc(dev, sizeof(*mdev), GFP_KERNEL);
 	if (!mdev)
 		return ERR_PTR(-ENOMEM);

drivers/gpu/drm/arm/display/komeda/komeda_dev.c struct komeda_dev *komeda_dev_create(struct device *dev) · line 188

Quoted 5 lines
drivers/gpu/drm/arm/display/komeda/komeda_dev.c +1 -1
@@ -192,7 +185,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	mutex_init(&mdev->lock);
 
 	mdev->dev = dev;
-	mdev->reg_base = devm_ioremap_resource(dev, io_res);
+	mdev->reg_base = devm_platform_ioremap_resource(pdev, 0);

Hi Markus:

Thank you for the patch.

Quoted 5 lines
drivers/gpu/drm/arm/display/komeda/komeda_dev.c +0 -1
 	if (IS_ERR(mdev->reg_base)) {
 		DRM_ERROR("Map register space failed.\n");
 		err = PTR_ERR(mdev->reg_base);
--

2.23.0

#2 lore raw
In reply to Markus Elfring
Quoted 8 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sat, 21 Sep 2019 19:43:51 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Thank you for the patch.

Looks good to me.

Quoted 40 lines
---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

--
2.23.0

drivers/gpu/drm/arm/display/komeda/komeda_dev.c +1 -8
index ca64a129c594..a387d923962e 100644
@@ -172,19 +172,12 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	const struct komeda_product_data *product;
 	struct komeda_dev *mdev;
-	struct resource *io_res;
 	int err = 0;
 
 	product = of_device_get_match_data(dev);
 	if (!product)
 		return ERR_PTR(-ENODEV);
 
-	io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!io_res) {
-		DRM_ERROR("No registers defined.\n");
-		return ERR_PTR(-ENODEV);
-	}
-
 	mdev = devm_kzalloc(dev, sizeof(*mdev), GFP_KERNEL);
 	if (!mdev)
 		return ERR_PTR(-ENOMEM);
@@ -192,7 +185,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	mutex_init(&mdev->lock);
 
 	mdev->dev = dev;
-	mdev->reg_base = devm_ioremap_resource(dev, io_res);
+	mdev->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mdev->reg_base)) {
 		DRM_ERROR("Map register space failed.\n");
 		err = PTR_ERR(mdev->reg_base);
#3 lore raw
Quoted 6 lines · On Wednesday, 9 October 2019 09:57:11 GMT james qian wang (Arm Technology…
Quoted 5 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sat, 21 Sep 2019 19:43:51 +0200

Simplify this function implementation by using a known wrapper function.

Quoted 8 lines
Quoted 3 lines

This issue was detected by using the Coccinelle software.

Thank you for the patch.

Looks good to me.

Applied to drm-misc-next - 50ec5b563bed04b0b262822b755f6aa336f1f40a

Quoted 46 lines
Quoted 33 lines
---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

--
2.23.0

drivers/gpu/drm/arm/display/komeda/komeda_dev.c +0 -7
index ca64a129c594..a387d923962e 100644
@@ -172,19 +172,12 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	const struct komeda_product_data *product;
 	struct komeda_dev *mdev;
-	struct resource *io_res;
 	int err = 0;
 
 	product = of_device_get_match_data(dev);
 	if (!product)
 		return ERR_PTR(-ENODEV);
 
-	io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!io_res) {
-		DRM_ERROR("No registers defined.\n");
-		return ERR_PTR(-ENODEV);
-	}
-
 	mdev = devm_kzalloc(dev, sizeof(*mdev), GFP_KERNEL);
 	if (!mdev)
 		return ERR_PTR(-ENOMEM);

drivers/gpu/drm/arm/display/komeda/komeda_dev.c struct komeda_dev *komeda_dev_create(struct device *dev) · line 191

Quoted 8 lines
drivers/gpu/drm/arm/display/komeda/komeda_dev.c +1 -1
@@ -192,7 +185,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
 	mutex_init(&mdev->lock);
 
 	mdev->dev = dev;
-	mdev->reg_base = devm_ioremap_resource(dev, io_res);
+	mdev->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mdev->reg_base)) {
 		DRM_ERROR("Map register space failed.\n");
 		err = PTR_ERR(mdev->reg_base);

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 1 line
Mihail