Skip to contentSkip to conversation

drm/amd/powerplay: remove duplicate macro of smu_get_uclk_dpm_states

PATCH In review Wang, Kevin(Yang) 3 participants 3 messages Sep 23, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/powerplay: remove duplicate macro of smu_get_uclk_dpm_states

remove duplicate macro of smu_get_uclk_dpm_states

fix commit:
drm/amd/powerplay: add the interface for getting ultimate frequency v3

---
 drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h +0 -2
index 45da21dc2356..5a0059b9aec9 100644
@@ -752,8 +752,6 @@ struct smu_funcs
 	((smu)->ppt_funcs->get_uclk_dpm_states ? (smu)->ppt_funcs->get_uclk_dpm_states((smu), (clocks_in_khz), (num_states)) : 0)
 #define smu_get_max_sustainable_clocks_by_dc(smu, max_clocks) \
 	((smu)->funcs->get_max_sustainable_clocks_by_dc ? (smu)->funcs->get_max_sustainable_clocks_by_dc((smu), (max_clocks)) : 0)
-#define smu_get_uclk_dpm_states(smu, clocks_in_khz, num_states) \
-	((smu)->ppt_funcs->get_uclk_dpm_states ? (smu)->ppt_funcs->get_uclk_dpm_states((smu), (clocks_in_khz), (num_states)) : 0)
 #define smu_baco_is_support(smu) \
 	((smu)->funcs->baco_is_support? (smu)->funcs->baco_is_support((smu)) : false)
 #define smu_baco_get_state(smu, state) \
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Prike Liang
#2 lore raw

Thanks clean up the duplicate code. The patch is

Thanks,
Prike

Quoted 34 lines

-----Original Message-----
From: Wang, Kevin(Yang) <[email protected]>
Sent: Monday, September 23, 2019 3:50 PM
To: [email protected]
Cc: Huang, Ray <[email protected]>; Feng, Kenneth <[email protected]>; Liang, Prike <[email protected]>; Wang, Kevin(Yang) <[email protected]>
Subject: [PATCH] drm/amd/powerplay: remove duplicate macro of smu_get_uclk_dpm_states

remove duplicate macro of smu_get_uclk_dpm_states

fix commit:
drm/amd/powerplay: add the interface for getting ultimate frequency v3

---
 drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h +0 -0
index 45da21dc2356..5a0059b9aec9 100644
@@ -752,8 +752,6 @@ struct smu_funcs
 	((smu)->ppt_funcs->get_uclk_dpm_states ? (smu)->ppt_funcs-
Quoted 1 line

get_uclk_dpm_states((smu), (clocks_in_khz), (num_states)) : 0) #define

smu_get_max_sustainable_clocks_by_dc(smu, max_clocks) \
((smu)->funcs->get_max_sustainable_clocks_by_dc ? (smu)->funcs-

Quoted 1 line

get_max_sustainable_clocks_by_dc((smu), (max_clocks)) : 0) -#define

smu_get_uclk_dpm_states(smu, clocks_in_khz, num_states) \

drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h +0 -1
-	((smu)->ppt_funcs->get_uclk_dpm_states ? (smu)->ppt_funcs-
Quoted 1 line

get_uclk_dpm_states((smu), (clocks_in_khz), (num_states)) : 0)

Quoted 5 lines

#define smu_baco_is_support(smu) \
((smu)->funcs->baco_is_support? (smu)->funcs-

Quoted 1 line

baco_is_support((smu)) : false) #define smu_baco_get_state(smu, state) \

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by Kenneth Feng
#3 lore raw
In reply to a message not in the archive

-----Original Message-----
From: Wang, Kevin(Yang)
Sent: Monday, September 23, 2019 3:50 PM
To: [email protected]
Cc: Huang, Ray <[email protected]>; Feng, Kenneth <[email protected]>; Liang, Prike <[email protected]>; Wang, Kevin(Yang) <[email protected]>
Subject: [PATCH] drm/amd/powerplay: remove duplicate macro of smu_get_uclk_dpm_states

remove duplicate macro of smu_get_uclk_dpm_states

fix commit:
drm/amd/powerplay: add the interface for getting ultimate frequency v3

---
 drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h +0 -2
index 45da21dc2356..5a0059b9aec9 100644
@@ -752,8 +752,6 @@ struct smu_funcs
 	((smu)->ppt_funcs->get_uclk_dpm_states ? (smu)->ppt_funcs->get_uclk_dpm_states((smu), (clocks_in_khz), (num_states)) : 0)  #define smu_get_max_sustainable_clocks_by_dc(smu, max_clocks) \
 	((smu)->funcs->get_max_sustainable_clocks_by_dc ? (smu)->funcs->get_max_sustainable_clocks_by_dc((smu), (max_clocks)) : 0) -#define smu_get_uclk_dpm_states(smu, clocks_in_khz, num_states) \
-	((smu)->ppt_funcs->get_uclk_dpm_states ? (smu)->ppt_funcs->get_uclk_dpm_states((smu), (clocks_in_khz), (num_states)) : 0)
 #define smu_baco_is_support(smu) \
 	((smu)->funcs->baco_is_support? (smu)->funcs->baco_is_support((smu)) : false)  #define smu_baco_get_state(smu, state) \
--

2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx