Skip to contentSkip to conversation

ath10k: fix memory leak

PATCH In review Navid Emamdoost 2 participants 3 messages Sep 20, 2019 – Sep 23, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: fix memory leak

In ath10k_usb_hif_tx_sg the allocated urb should be released if usb_submit_urb fails.

---
 drivers/net/wireless/ath/ath10k/usb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath10k/usb.c +1 -0
index e1420f67f776..730ed22e08a0 100644
@@ -435,6 +435,7 @@ static int ath10k_usb_hif_tx_sg(struct ath10k *ar, u8 pipe_id,
 			ath10k_dbg(ar, ATH10K_DBG_USB_BULK,
 				   "usb bulk transmit failed: %d\n", ret);
 			usb_unanchor_urb(urb);
+			usb_free_urb(urb);
 			ret = -EINVAL;
 			goto err_free_urb_to_pipe;
 		}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Navid Emamdoost

In ath10k_usb_hif_tx_sg the allocated urb should be released if usb_submit_urb fails.

Patch applied to ath-next branch of ath.git, thanks.

b8d17e7d93d2 ath10k: fix memory leak

Signature · 9 lines
https://patchwork.kernel.org/patch/11153699/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
In reply to Navid Emamdoost
Quoted 5 lines · Navid Emamdoost

In ath10k_usb_hif_tx_sg the allocated urb should be released if usb_submit_urb fails.

Patch applied to ath-next branch of ath.git, thanks.

b8d17e7d93d2 ath10k: fix memory leak

Signature · 3 lines
https://patchwork.kernel.org/patch/11153699/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches