Skip to contentSkip to conversation

arm64: errata: Update stale comment

PATCH In review Thierry Reding 2 participants 2 messages Sep 23, 2019 – Oct 2, 2019 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: errata: Update stale comment

From: Thierry Reding <[email protected]>

Commit 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack thereof") renamed the caller of the install_bp_hardening_cb() function but forgot to update a comment, which can be confusing when trying to follow the code flow.

Fixes 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack thereof")
---
 arch/arm64/kernel/cpu_errata.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/kernel/cpu_errata.c +2 -2
index 1e43ba5c79b7..f593f4cffc0d 100644
@@ -128,8 +128,8 @@ static void install_bp_hardening_cb(bp_hardening_cb_t fn,
 	int cpu, slot = -1;
 
 	/*
-	 * enable_smccc_arch_workaround_1() passes NULL for the hyp_vecs
-	 * start/end if we're a guest. Skip the hyp-vectors work.
+	 * detect_harden_bp_fw() passes NULL for the hyp_vecs start/end if
+	 * we're a guest. Skip the hyp-vectors work.
 	 */
 	if (!hyp_vecs_start) {
 		__this_cpu_write(bp_hardening_data.fn, fn);
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · On Mon, 23 Sep 2019 11:12:29 +0200 Thierry Reding <[email protected]>…

From: Thierry Reding <[email protected]>

Commit 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack thereof") renamed the caller of the install_bp_hardening_cb() function but forgot to update a comment, which can be confusing when trying to follow the code flow.

Fixes 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack thereof")
---
 arch/arm64/kernel/cpu_errata.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/kernel/cpu_errata.c +0 -0
index 1e43ba5c79b7..f593f4cffc0d 100644

arch/arm64/kernel/cpu_errata.c static void install_bp_hardening_cb(bp_hardening_cb_t fn, · line 135

Quoted 10 lines
arch/arm64/kernel/cpu_errata.c +2 -2
@@ -128,8 +128,8 @@ static void install_bp_hardening_cb(bp_hardening_cb_t fn,
 	int cpu, slot = -1;
 
 	/*
-	 * enable_smccc_arch_workaround_1() passes NULL for the hyp_vecs
-	 * start/end if we're a guest. Skip the hyp-vectors work.
+	 * detect_harden_bp_fw() passes NULL for the hyp_vecs start/end if
+	 * we're a guest. Skip the hyp-vectors work.
 	 */
 	if (!hyp_vecs_start) {
 		__this_cpu_write(bp_hardening_data.fn, fn);
Signature · 1 line
Without deviation from the norm, progress is not possible.