Skip to contentSkip to conversation

sched/core: Remove double update_max_interval() call on CPU startup

PATCH Applied Valentin Schneider 2 participants 2 messages Sep 23, 2019 – Sep 27, 2019 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/core: Remove double update_max_interval() call on CPU startup

update_max_interval() is called in both CPUHP_AP_SCHED_STARTING's startup and teardown callbacks, but it turns out it's also called at the end of the startup callback of CPUHP_AP_ACTIVE (which is further down the startup sequence).

There's no point in repeating this interval update in the startup sequence since the CPU will remain online until it goes down the teardown path.

Remove the redundant call in sched_cpu_activate() (CPUHP_AP_ACTIVE).

---
 kernel/sched/core.c | 2 --
 1 file changed, 2 deletions(-)
kernel/sched/core.c +0 -3
index 87b84a726db4..6b94e71f659e 100644
@@ -6418,9 +6418,6 @@ int sched_cpu_activate(unsigned int cpu)
 	}
 	rq_unlock_irqrestore(rq, &rf);
 
-	update_max_interval();
-
 	return 0;
 }
 
--

2.22.0

#1 lore raw
The following commit has been merged into the sched/urgent branch of tip:

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID:     9fc41acc89e58262c917b4be89ef00a87485804f
Gitweb:        https://git.kernel.org/tip/9fc41acc89e58262c917b4be89ef00a87485804f
Author:        Valentin Schneider <[email protected]>
AuthorDate:    Mon, 23 Sep 2019 10:30:17 +01:00
Committer:     Ingo Molnar <[email protected]>
CommitterDate: Wed, 25 Sep 2019 17:42:32 +02:00

sched/core: Remove double update_max_interval() call on CPU startup

update_max_interval() is called in both CPUHP_AP_SCHED_STARTING's startup and teardown callbacks, but it turns out it's also called at the end of the startup callback of CPUHP_AP_ACTIVE (which is further down the startup sequence).

There's no point in repeating this interval update in the startup sequence since the CPU will remain online until it goes down the teardown path.

Remove the redundant call in sched_cpu_activate() (CPUHP_AP_ACTIVE).

---
 kernel/sched/core.c | 2 --
 1 file changed, 2 deletions(-)
kernel/sched/core.c +0 -2
index 00ef44c..1b61cf4 100644
@@ -6425,8 +6425,6 @@ int sched_cpu_activate(unsigned int cpu)
 	}
 	rq_unlock_irqrestore(rq, &rf);
 
-	update_max_interval();
-
 	return 0;
 }