Skip to contentSkip to conversation

x86/unittests.cfg: Increase the timeout of the sieve test to 180s

PATCH Applied Thomas Huth 2 participants 3 messages Sep 23, 2019 – Nov 15, 2019 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/unittests.cfg: Increase the timeout of the sieve test to 180s

In the gitlab-CI (where we are running the tests with TCG), the sieve test sometimes takes more than 90s to finish, and thus fails due to the 90s timeout from scripts/runtime.bash. Increase the timeout for this test to make it always succeed.

---
See for example this run here where it took more than 90s:

https://gitlab.com/huth/kvm-unit-tests/-/jobs/301407814

If you don't like the change in unittests.cfg, I can also tweak the (global) timeout in .gitlab-ci.yml instead.

 x86/unittests.cfg | 1 +
 1 file changed, 1 insertion(+)
x86/unittests.cfg +1 -0
index 694ee3d..e951629 100644
@@ -172,6 +172,7 @@ file = s3.flat
 
 [sieve]
 file = sieve.flat
+timeout = 180
 
 [syscall]
 file = syscall.flat
Signature · 1 line
2.18.1
#1 lore raw
Quoted 23 lines · Thomas Huth

In the gitlab-CI (where we are running the tests with TCG), the sieve test sometimes takes more than 90s to finish, and thus fails due to the 90s timeout from scripts/runtime.bash. Increase the timeout for this test to make it always succeed.

---
See for example this run here where it took more than 90s:

https://gitlab.com/huth/kvm-unit-tests/-/jobs/301407814

If you don't like the change in unittests.cfg, I can also tweak the (global) timeout in .gitlab-ci.yml instead.

 x86/unittests.cfg | 1 +
 1 file changed, 1 insertion(+)
x86/unittests.cfg +0 -0
index 694ee3d..e951629 100644

x86/unittests.cfg file = s3.flat · line 178

Quoted 7 lines
x86/unittests.cfg +1 -0
@@ -172,6 +172,7 @@ file = s3.flat
 
 [sieve]
 file = sieve.flat
+timeout = 180
 
 [syscall]
 file = syscall.flat

Ping?

Thomas

maintainer Applied
#2 lore raw
In reply to Thomas Huth
Quoted 23 lines · Thomas Huth

In the gitlab-CI (where we are running the tests with TCG), the sieve test sometimes takes more than 90s to finish, and thus fails due to the 90s timeout from scripts/runtime.bash. Increase the timeout for this test to make it always succeed.

---
See for example this run here where it took more than 90s:

https://gitlab.com/huth/kvm-unit-tests/-/jobs/301407814

If you don't like the change in unittests.cfg, I can also tweak the (global) timeout in .gitlab-ci.yml instead.

 x86/unittests.cfg | 1 +
 1 file changed, 1 insertion(+)
x86/unittests.cfg +0 -0
index 694ee3d..e951629 100644

x86/unittests.cfg file = s3.flat · line 178

Quoted 7 lines
x86/unittests.cfg +1 -0
@@ -172,6 +172,7 @@ file = s3.flat
 
 [sieve]
 file = sieve.flat
+timeout = 180
 
 [syscall]
 file = syscall.flat

Queued, thanks.

Paolo