Skip to contentSkip to conversation

libhttpserver: new package

PATCH New stephan.hoffmann at ext.grandcentrix.net 2 participants 4 messages Sep 23, 2019 – Sep 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libhttpserver: new package

From: Stephan Hoffmann <[email protected]>

libhttpserver is a C++ library for building high performance RESTfuls web servers. libhttpserver is built upon libmicrohttpd to provide a simple API for developers to create HTTP services in C++.

The installed pkg-config file contains an error, thus we include the patch 458d16b922304006fe418897044e14b0544a127a from the upstream repo that is not yet released.

---
 package/Config.in                             |  1 +
 ...-expectations-in-libhttpserver.pc.in.patch | 24 +++++++++++++++++++
 package/libhttpserver/Config.in               | 14 +++++++++++
 package/libhttpserver/libhttpserver.hash      |  2 ++
 package/libhttpserver/libhttpserver.mk        | 16 +++++++++++++
 5 files changed, 57 insertions(+)
 create mode 100644 package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch
 create mode 100644 package/libhttpserver/Config.in
 create mode 100644 package/libhttpserver/libhttpserver.hash
 create mode 100644 package/libhttpserver/libhttpserver.mk
package/Config.in +1 -0
index 2fc11065f6..e6ee550e7a 100644
@@ -1584,6 +1584,7 @@ menu "Networking"
 	source "package/libgsasl/Config.in"
 	source "package/libhtp/Config.in"
 	source "package/libhttpparser/Config.in"
+	source "package/libhttpserver/Config.in"
 	source "package/libidn/Config.in"
 	source "package/libidn2/Config.in"
 	source "package/libiscsi/Config.in"
package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch new file +24 -0
new file mode 100644
index 0000000000..e0ca5575dc
@@ -0,0 +1,24 @@
+From 2bc7cf0beb6b8a124c1c7360c4fb5279e8763f07 Mon Sep 17 00:00:00 2001
+From: Sebastiano Merlino <[email protected]>
+Date: Sat, 8 Jun 2019 15:36:06 -0700
+Subject: [PATCH] Fix lib expectations in libhttpserver.pc.in
+
+---
+ libhttpserver.pc.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libhttpserver.pc.in b/libhttpserver.pc.in
+index 36355ee..55f7c0e 100644
+--- a/libhttpserver.pc.in
++++ b/libhttpserver.pc.in
+@@ -8,6 +8,6 @@ Description: A C++ library for creating an embedded Rest HTTP server
+ Version: @VERSION@
+ Requires: libmicrohttpd >= 0.9.37
+ Conflicts:
+-Libs: -L${libdir} -lmicrohttpd
++Libs: -L${libdir} -lhttpserver
+ Libs.private: @LHT_LIBDEPS@
+ Cflags: -I${includedir} -I${includedir}/httpserver
+-- 
+2.17.1
+
package/libhttpserver/Config.in new file +14 -0
new file mode 100644
index 0000000000..526ca7c41e
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_LIBHTTPSERVER
+	bool "libhttpserver"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_LIBMICROHTTPD
+	help
+	  libhttpserver is a C++ library for building high performance
+	  RESTfuls web servers. libhttpserver is built upon
+	  libmicrohttpd to provide a simple API for developers to
+	  create HTTP services in C++.
+
+	  https://github.com/etr/libhttpserver
+
+comment "libhttpserver needs a toolchain w/ c++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/libhttpserver/libhttpserver.hash new file +2 -0
new file mode 100644
index 0000000000..5561c3d917
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 778fa0aec199bf8737b2d540c2563a694c18957329f9885e372f7aaafb838351 libhttpserver-0.17.5.tar.gz
package/libhttpserver/libhttpserver.mk new file +16 -0
new file mode 100644
index 0000000000..e46271d7d9
@@ -0,0 +1,16 @@
+################################################################################
+#
+# libhttpserver
+#
+################################################################################
+
+LIBHTTPSERVER_VERSION = 0.17.5
+LIBHTTPSERVER_SITE = $(call github,etr,libhttpserver,$(LIBHTTPSERVER_VERSION))
+LIBHTTPSERVER_LICENSE = LGPL-2.1-or-later
+LIBHTTPSERVER_LICENSE_FILES = COPYING.LESSER
+LIBHTTPSERVER_INSTALL_STAGING = YES
+LIBHTTPSERVER_CONF_OPTS += --enable-same-directory-build
+LIBHTTPSERVER_AUTORECONF = YES
+LIBHTTPSERVER_DEPENDENCIES = libmicrohttpd
+
+$(eval $(autotools-package))
Signature · 22 lines
2.17.1


-- 

*Azure IoT* Gold Partner ? *Azure Sphere* Elite Partner ? *Vodafone 
NB-IoT* Partner ? Apple *MFi* & *HomeKit* Developer ? *Bluetooth* SIG ? 
*zigbee* Alliance ? *LoRa* Alliance ? *Thread* Group


grandcentrix GmbH???
Holzmarkt 1???50676 *K?ln*?|?Phoenixseestrasse 18???44263 *Dortmund*???
Deutschland
| t <https://twitter.com/grandcentrix> | f 
<https://www.facebook.com/GrandCentrix/> | in 
<https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
|?email: hello at grandcentrix.net <mailto:[email protected]>



Amtsgericht K?ln | HRB ?70119 | Gesch?ftsf?hrer: R. Rottmann, M. Willnow | 
USt.-IdNr.: DE266333969
#1 lore raw

PATCH 1/1 libhttpserver: new package

Hello Stephan,

Thanks for this contribution! It looks mostly good, but I have a few comments below.

Quoted 10 lines · On Mon, 23 Sep 2019 13:52:37 +0200 <[email protected]>…

From: Stephan Hoffmann <[email protected]>

libhttpserver is a C++ library for building high performance RESTfuls web servers. libhttpserver is built upon libmicrohttpd to provide a simple API for developers to create HTTP services in C++.

The installed pkg-config file contains an error, thus we include the patch 458d16b922304006fe418897044e14b0544a127a from the upstream repo that is not yet released.

Quoted 8 lines
---
 package/Config.in                             |  1 +
 ...-expectations-in-libhttpserver.pc.in.patch | 24 +++++++++++++++++++
 package/libhttpserver/Config.in               | 14 +++++++++++
 package/libhttpserver/libhttpserver.hash      |  2 ++
 package/libhttpserver/libhttpserver.mk        | 16 +++++++++++++
 5 files changed, 57 insertions(+)

Could you add an entry in the DEVELOPERS file for this package? This way, you'll receive notifications about build issues of this package, as well as when a new upstream release is available.

package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch line 5

Quoted 11 lines
package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch new file +5 -0
new file mode 100644
index 0000000000..e0ca5575dc
@@ -0,0 +1,24 @@
+From 2bc7cf0beb6b8a124c1c7360c4fb5279e8763f07 Mon Sep 17 00:00:00 2001
+From: Sebastiano Merlino <[email protected]>
+Date: Sat, 8 Jun 2019 15:36:06 -0700
+Subject: [PATCH] Fix lib expectations in libhttpserver.pc.in
+

We need a Signed-off-by line (at least from you) in this patch. Also, if it comes from upstream, a link to the upstream commit is good to have.

package/libhttpserver/Config.in line 4

Quoted 10 lines
package/libhttpserver/Config.in new file +4 -0
new file mode 100644
index 0000000000..526ca7c41e
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_LIBHTTPSERVER
+	bool "libhttpserver"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_LIBMICROHTTPD

Since you select BR2_PACKAGE_LIBMICROHTTPD, you need to replicate the "depends on" of BR2_PACKAGE_LIBMICROHTTPD, i.e BR2_TOOLCHAIN_HAS_THREADS.

package/libhttpserver/Config.in line 14

Quoted 10 lines
package/libhttpserver/Config.in new file +10 -0
+	help
+	  libhttpserver is a C++ library for building high performance
+	  RESTfuls web servers. libhttpserver is built upon
+	  libmicrohttpd to provide a simple API for developers to
+	  create HTTP services in C++.
+
+	  https://github.com/etr/libhttpserver
+
+comment "libhttpserver needs a toolchain w/ c++"
+	depends on !BR2_INSTALL_LIBSTDCPP

.. and update this comment. Also we write "C++" and not "c++" in those comments.

package/libhttpserver/libhttpserver.hash line 2

Quoted 8 lines
package/libhttpserver/libhttpserver.hash new file +2 -0
new file mode 100644
index 0000000000..5561c3d917
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 778fa0aec199bf8737b2d540c2563a694c18957329f9885e372f7aaafb838351 libhttpserver-0.17.5.tar.gz

Please add the hash of the license file as well.

Quoted 8 lines
package/libhttpserver/libhttpserver.mk new file +2 -0
new file mode 100644
index 0000000000..e46271d7d9
@@ -0,0 +1,16 @@
+################################################################################
+#

package/libhttpserver/libhttpserver.mk line 12

Quoted 10 lines
package/libhttpserver/libhttpserver.mk new file +10 -0
+# libhttpserver
+#
+################################################################################
+
+LIBHTTPSERVER_VERSION = 0.17.5
+LIBHTTPSERVER_SITE = $(call github,etr,libhttpserver,$(LIBHTTPSERVER_VERSION))
+LIBHTTPSERVER_LICENSE = LGPL-2.1-or-later
+LIBHTTPSERVER_LICENSE_FILES = COPYING.LESSER
+LIBHTTPSERVER_INSTALL_STAGING = YES
+LIBHTTPSERVER_CONF_OPTS += --enable-same-directory-build

You can make the += just a = since it's unconditional.

package/libhttpserver/libhttpserver.mk line 16

Quoted 4 lines
package/libhttpserver/libhttpserver.mk new file +4 -0
+LIBHTTPSERVER_AUTORECONF = YES
+LIBHTTPSERVER_DEPENDENCIES = libmicrohttpd
+
+$(eval $(autotools-package))

Could you address those minor details and send an updated version?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 libhttpserver: new package

Hello Thomas!

Quoted 8 lines · Thomas Petazzoni
Quoted 1 line

diff --git

a/package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch b/package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch

Quoted 4 lines

new file mode 100644
index 0000000000..e0ca5575dc
--- /dev/null
+++

b/package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch

Quoted 12 lines

package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch line 5

Quoted 6 lines
package/libhttpserver/0001-Fix-lib-expectations-in-libhttpserver.pc.in.patch new file +5 -0
@@ -0,0 +1,24 @@
+From 2bc7cf0beb6b8a124c1c7360c4fb5279e8763f07 Mon Sep 17 00:00:00 2001
+From: Sebastiano Merlino <[email protected]>
+Date: Sat, 8 Jun 2019 15:36:06 -0700
+Subject: [PATCH] Fix lib expectations in libhttpserver.pc.in
+

We need a Signed-off-by line (at least from you) in this patch. Also, if it comes from upstream, a link to the upstream commit is good to have.

Is there any mechanism allowing to cherry pick a commit from the upstream repo instead of providing a patch file? I don't really feel good about modifying the patch file;-)

Kind regards
Stephan

Signature · 21 lines
*Azure IoT* Gold Partner ? *Azure Sphere* Elite Partner ? *Vodafone 
NB-IoT* Partner ? Apple *MFi* & *HomeKit* Developer ? *Bluetooth* SIG ? 
*zigbee* Alliance ? *LoRa* Alliance ? *Thread* Group


grandcentrix GmbH???
Holzmarkt 1???50676 *K?ln*?|?Phoenixseestrasse 18???44263 *Dortmund*???
Deutschland
| t <https://twitter.com/grandcentrix> | f 
<https://www.facebook.com/GrandCentrix/> | in 
<https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
|?email: hello at grandcentrix.net <mailto:[email protected]>



Amtsgericht K?ln | HRB ?70119 | Gesch?ftsf?hrer: R. Rottmann, M. Willnow | 
USt.-IdNr.: DE266333969

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190924/4ffd4a4d/attachment.html>
#3 lore raw

PATCH 1/1 libhttpserver: new package

Quoted 7 lines · On Tue, 24 Sep 2019 09:22:37 +0200 Stephan Hoffmann…
Quoted 4 lines

We need a Signed-off-by line (at least from you) in this patch. Also, if it comes from upstream, a link to the upstream commit is good to have.

Is there any mechanism allowing to cherry pick a commit from the upstream repo instead of providing a patch file? I don't really feel good about modifying the patch file;-)

We prefer to have patches locally instead of downloading them, because the hash of patches generated by Github is not stable.

We have numerous patches locally in package directories, and changing their commit log is perfectly fine.

See for example package/fastd/0003-cipher-remove-aes128-ctr-NaCl-implementation.patch how the Signed-off-by line and reference to the upstream commit was added.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com