Skip to contentSkip to conversation

package/cups-filters: select bash

PATCH Superseded unixmania at gmail.com 2 participants 3 messages Sep 24, 2019 – Sep 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/cups-filters: select bash

From: Carlos Santos <[email protected]>

The following files installed by cups-filters are bash scripts:

/usr/lib/cups/filter/brftoembosser
/usr/lib/cups/filter/imageubrltoindexv3
/usr/lib/cups/filter/imageubrltoindexv4
/usr/lib/cups/filter/textbrftoindexv3
/usr/lib/cups/filter/imagetobrf
/usr/lib/cups/filter/vectortopdf
/usr/lib/cups/filter/vectortobrf
/usr/lib/cups/filter/texttobrf
/usr/lib/cups/filter/brftopagedbrf
/usr/lib/cups/filter/musicxmltobrf

---
Changes v1->v2:
- fix typo in commit message (cips->cups)

---
 package/cups-filters/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/cups-filters/Config.in +1 -0
index 5badf0e1f1..bb54bc1d1b 100644
@@ -8,6 +8,7 @@ config BR2_PACKAGE_CUPS_FILTERS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_PACKAGE_CUPS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
+	select BR2_PACKAGE_BASH
 	select BR2_PACKAGE_JPEG
 	select BR2_PACKAGE_FONTCONFIG
 	select BR2_PACKAGE_FREETYPE
Signature · 1 line
2.18.1
#1 lore raw

PATCH v2 1/1 package/cups-filters: select bash

Hello Carlos,

package/cups-filters/Config.in config BR2_PACKAGE_CUPS_FILTERS · line 11

Quoted 9 lines · On Mon, 23 Sep 2019 22:15:42 -0300 unixmania at gmail.com wrote:
package/cups-filters/Config.in +1 -0
index 5badf0e1f1..bb54bc1d1b 100644
@@ -8,6 +8,7 @@ config BR2_PACKAGE_CUPS_FILTERS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_PACKAGE_CUPS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
+	select BR2_PACKAGE_BASH

To select bash, you would have to replicate the:

depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS

dependency of bash to cups-filters, which is a bit annoying, as it's off by default.

Are the scripts that use #!/bin/bash really using bashims, or are they using #!/bin/bash but are in fact POSIX compliant ?

Or could we install them only if bash is available ? Are they useful in all situations, or only in some specific cases.

I'm just trying to figure out what is the right solution for this. Perhaps ultimately the solution will be to select bash, with "depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS", but I'd like to explore the other possibilities.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/cups-filters: select bash

Quoted 18 lines · Thomas Petazzoni

Hello Carlos,

package/cups-filters/Config.in config BR2_PACKAGE_CUPS_FILTERS · line 11

Quoted 9 lines · On Mon, 23 Sep 2019 22:15:42 -0300 unixmania at gmail.com wrote:
package/cups-filters/Config.in +1 -0
index 5badf0e1f1..bb54bc1d1b 100644
@@ -8,6 +8,7 @@ config BR2_PACKAGE_CUPS_FILTERS
      depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
      depends on BR2_PACKAGE_CUPS
      depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
+     select BR2_PACKAGE_BASH

To select bash, you would have to replicate the:

Quoted 7 lines

depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS

dependency of bash to cups-filters, which is a bit annoying, as it's off by default.

Are the scripts that use #!/bin/bash really using bashims, or are they using #!/bin/bash but are in fact POSIX compliant ?

Yes, they are full of bashisms.

Quoted 2 lines

Or could we install them only if bash is available ? Are they useful in all situations, or only in some specific cases.

I investigated a bit more and found that the bash scripts belong to the Braille support, which cannot be enabled anyway, since it requires liblouis (http://liblouis.org/) which is not available on Buildroot.

Quoted 5 lines

I'm just trying to figure out what is the right solution for this. Perhaps ultimately the solution will be to select bash, with "depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS", but I'd like to explore the other possibilities.

Quoted 7 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

I will send a new patch disabling the Braille support.

Signature · 1 line
Carlos Santos <[email protected]>