Skip to contentSkip to conversation

spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

PATCH New Vignesh Raghavendra 4 participants 21 messages Sep 24, 2019 – Oct 9, 2019 Memory technology devices (MTD)

lore
Share & tools
lore

Vignesh Raghavendra

author maintainer
#0 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
Signature · 1 line
2.23.0
author maintainer
#1 lore raw

PATCH 1/3 spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and n25q256*

Older variants of n25q256* and n25q512* do not support 4 Byte stateless addressing opcodes. Therefore drop SPI_NOR_4B_OPCODES flag from these entries.

---
 drivers/mtd/spi/spi-nor-ids.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/mtd/spi/spi-nor-ids.c +4 -4
index a3920ba520e0..6f7386db4226 100644
@@ -161,12 +161,12 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
-	{ INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
-	{ INFO("n25q256ax1",  0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+	{ INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO("n25q256ax1",  0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ INFO6("mt25qu512a",  0x20bb20, 0x104400, 64 * 1024, 1024,
 		 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
-	{ INFO("n25q512a",    0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
-	{ INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+	{ INFO("n25q512a",    0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
+	{ INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
Signature · 1 line
2.23.0
author maintainer
#2 lore raw

PATCH 2/3 spi-nor: spi-nor-ids: Rename mt25qu512a entry

In reply to Vignesh Raghavendra

mt25qu512a is just a rebranded name for n25q512a. All the 6 bytes of JEDEC ID bytes are same for mt25qu512a and n25q512a. Therefore rename mt25qu512a to "mt25qu512a (n25q512a)", so that its much clearer to user.

---
 drivers/mtd/spi/spi-nor-ids.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/spi-nor-ids.c +1 -1
index 6f7386db4226..967537eafb55 100644
@@ -163,7 +163,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q256ax1",  0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
-	{ INFO6("mt25qu512a",  0x20bb20, 0x104400, 64 * 1024, 1024,
+	{ INFO6("mt25qu512a (n25q512a)",  0x20bb20, 0x104400, 64 * 1024, 1024,
 		 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("n25q512a",    0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
Signature · 1 line
2.23.0
author maintainer
#3 lore raw

PATCH 3/3 spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and n25q512*

In reply to Vignesh Raghavendra

Newer variants of n25q256* and n25q512* flashes support 4 Byte addressing opcodes. Add entries for the same. These flashes Bit 6 set in 5th byte of READ ID response.

---
 drivers/mtd/spi/spi-nor-ids.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +3 -0
index 967537eafb55..0074073b123a 100644
@@ -161,11 +161,14 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
+	{ INFO6("n25q256a",    0x20ba19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ INFO6("n25q256ax1",  0x20bb19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("n25q256ax1",  0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
 	{ INFO6("mt25qu512a (n25q512a)",  0x20bb20, 0x104400, 64 * 1024, 1024,
 		 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("n25q512a",    0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
+	{ INFO6("n25q512ax3",  0x20ba20, 0x104400, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
Signature · 1 line
2.23.0
#4 lore raw

PATCH 3/3 spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and n25q512*

Quoted 15 lines · Vignesh Raghavendra

Newer variants of n25q256* and n25q512* flashes support 4 Byte addressing opcodes. Add entries for the same. These flashes Bit 6 set in 5th byte of READ ID response.

---
 drivers/mtd/spi/spi-nor-ids.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 967537eafb55..0074073b123a 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 164

Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -161,11 +161,14 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256a",    0x20ba19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

From the discussion in the other thread, this should probably be named "mt25-something"? Seems like the 0x44 in the 5th byte wouldn't be found in the n25q256a?

Regards,
Simon

Quoted 13 lines
drivers/mtd/spi/spi-nor-ids.c +2 -1
        { INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256ax1",  0x20bb19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("n25q256ax1",  0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO6("mt25qu512a (n25q512a)",  0x20bb20, 0x104400, 64 * 1024, 1024,
                 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("n25q512a",    0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q512ax3",  0x20ba20, 0x104400, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
        { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
--

2.23.0

#5 lore raw

PATCH 3/3 spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and n25q512*

+Tudor Ambarus (from discussion in https://patchwork.ozlabs.org/patch/1160501/)

Quoted 42 lines · Simon Goldschmidt
Quoted 15 lines · Vignesh Raghavendra

Newer variants of n25q256* and n25q512* flashes support 4 Byte addressing opcodes. Add entries for the same. These flashes Bit 6 set in 5th byte of READ ID response.

---
 drivers/mtd/spi/spi-nor-ids.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 967537eafb55..0074073b123a 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 164

Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -161,11 +161,14 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256a",    0x20ba19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

From the discussion in the other thread, this should probably be named "mt25-something"? Seems like the 0x44 in the 5th byte wouldn't be found in the n25q256a?

Regards,
Simon

Quoted 13 lines
drivers/mtd/spi/spi-nor-ids.c +2 -1
        { INFO("n25q256a",    0x20ba19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256ax1",  0x20bb19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("n25q256ax1",  0x20bb19, 0, 64 * 1024,  512, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO6("mt25qu512a (n25q512a)",  0x20bb20, 0x104400, 64 * 1024, 1024,
                 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("n25q512a",    0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q512ax3",  0x20ba20, 0x104400, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
        { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
        { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
--

2.23.0

#6 lore raw

PATCH 3/3 spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and n25q512*

In reply to Simon Goldschmidt

Hi, Simon,

Quoted 14 lines · Simon Goldschmidt

External E-Mail

Quoted 10 lines · Vignesh Raghavendra

Newer variants of n25q256* and n25q512* flashes support 4 Byte addressing opcodes. Add entries for the same. These flashes Bit 6 set in 5th byte of READ ID response.

---
 drivers/mtd/spi/spi-nor-ids.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 14 lines

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 164

Quoted 9 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
index 967537eafb55..0074073b123a 100644
@@ -161,11 +161,14 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256a",    0x20ba19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

From the discussion in the other thread, this should probably be named "mt25-something"? Seems like the 0x44 in the 5th byte wouldn't be found in the n25q256a?

Probably yes, but the ultimate test would be to dump all the JEDEC ID bytes from the n25q256a flash, with code similar to that from below. It's not the first time that we see manufacturers messing with the JEDEC IDs or with the SFDP tables. It would be really helpful if you can dump the JEDEC ID bytes on a n25q256a.

drivers/mtd/spi/spi-nor-core.c +0 -0
index 1acff745d1a2..0be3496c5367 100644
@@ -885,13 +885,16 @@ static const struct flash_info *spi_nor_read_id(struct

spi_nor *nor)

        info = spi_nor_ids;
        for (; info->name; info++) {
                if (info->id_len) {
-                       if (!memcmp(info->id, id, info->id_len))
+                       if (!memcmp(info->id, id, info->id_len)) {
+                               dev_err(nor->dev, "JEDEC id bytes: %*ph\n",
+                                       SPI_NOR_MAX_ID_LEN, id);
                                return info;
+                       }
                }
        }

- dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",
- id[0], id[1], id[2]);
+ dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n",

+                SPI_NOR_MAX_ID_LEN, id);
        return ERR_PTR(-ENODEV);

}

author maintainer
#7 lore raw

PATCH 3/3 spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and n25q512*

Simon,

Quoted 31 lines · Tudor.Ambarus at microchip.com

Hi, Simon,

Quoted 28 lines · Simon Goldschmidt

External E-Mail

Quoted 15 lines · Vignesh Raghavendra

Newer variants of n25q256* and n25q512* flashes support 4 Byte addressing opcodes. Add entries for the same. These flashes Bit 6 set in 5th byte of READ ID response.

---
 drivers/mtd/spi/spi-nor-ids.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 967537eafb55..0074073b123a 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 164

Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -161,11 +161,14 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256a",    0x20ba19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

From the discussion in the other thread, this should probably be named "mt25-something"? Seems like the 0x44 in the 5th byte wouldn't be found in the n25q256a?

Sorry, I thought mt25 parts are also marked as n25q based on your replies.. For now, I believe we can assume all devices with 0x44 in the 5th byte are mt25 parts and support 4 byte opcodes. Will next v2 with this assumptions.

Regards
Vignesh

Quoted 31 lines

Probably yes, but the ultimate test would be to dump all the JEDEC ID bytes from the n25q256a flash, with code similar to that from below. It's not the first time that we see manufacturers messing with the JEDEC IDs or with the SFDP tables. It would be really helpful if you can dump the JEDEC ID bytes on a n25q256a.

drivers/mtd/spi/spi-nor-core.c +6 -3
index 1acff745d1a2..0be3496c5367 100644
@@ -885,13 +885,16 @@ static const struct flash_info *spi_nor_read_id(struct
 spi_nor *nor)
        info = spi_nor_ids;
        for (; info->name; info++) {
                if (info->id_len) {
-                       if (!memcmp(info->id, id, info->id_len))
+                       if (!memcmp(info->id, id, info->id_len)) {
+                               dev_err(nor->dev, "JEDEC id bytes: %*ph\n",
+                                       SPI_NOR_MAX_ID_LEN, id);
                                return info;
+                       }
                }
        }
 
-       dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",
-               id[0], id[1], id[2]);
+        dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n",
+                SPI_NOR_MAX_ID_LEN, id);
        return ERR_PTR(-ENODEV);
 }
Signature · 2 lines
Regards
Vignesh
#8 lore raw

PATCH 3/3 spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and n25q512*

Hi Vignesh,

Quoted 36 lines · Vignesh Raghavendra

Simon,

Quoted 31 lines · Tudor.Ambarus at microchip.com

Hi, Simon,

Quoted 28 lines · Simon Goldschmidt

External E-Mail

Quoted 15 lines · Vignesh Raghavendra

Newer variants of n25q256* and n25q512* flashes support 4 Byte addressing opcodes. Add entries for the same. These flashes Bit 6 set in 5th byte of READ ID response.

---
 drivers/mtd/spi/spi-nor-ids.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 967537eafb55..0074073b123a 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 164

Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -161,11 +161,14 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256a",    0x20ba19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

From the discussion in the other thread, this should probably be named "mt25-something"? Seems like the 0x44 in the 5th byte wouldn't be found in the n25q256a?

Quoted 4 lines

Sorry, I thought mt25 parts are also marked as n25q based on your replies.. For now, I believe we can assume all devices with 0x44 in the 5th byte are mt25 parts and support 4 byte opcodes. Will next v2 with this assumptions.

Well, that's my fault. Seems I mixed up the parts here. Our switch to mt25 was earlier than I had thought and I was using boards with mt25 where I thought I had n25q before me... Sorry for the confusion!

I can however not tell you if all mt25 chips support 4 byte opcodes. The ones I have do though.

Oh, and there are also Altera/Intel EPCQ devices (e.g. on the socfpga_socrates) that are reported as n25q256a. I'd have to look at them as well to see if 4 byte opcodes are supported and what the full ID is.

Regards,
Simon

Quoted 39 lines

Regards
Vignesh

Quoted 21 lines

Probably yes, but the ultimate test would be to dump all the JEDEC ID bytes from the n25q256a flash, with code similar to that from below. It's not the first time that we see manufacturers messing with the JEDEC IDs or with the SFDP tables. It would be really helpful if you can dump the JEDEC ID bytes on a n25q256a.

drivers/mtd/spi/spi-nor-core.c +3 -1
index 1acff745d1a2..0be3496c5367 100644
@@ -885,13 +885,16 @@ static const struct flash_info *spi_nor_read_id(struct
 spi_nor *nor)
        info = spi_nor_ids;
        for (; info->name; info++) {
                if (info->id_len) {
-                       if (!memcmp(info->id, id, info->id_len))
+                       if (!memcmp(info->id, id, info->id_len)) {
+                               dev_err(nor->dev, "JEDEC id bytes: %*ph\n",
+                                       SPI_NOR_MAX_ID_LEN, id);
                                return info;

drivers/mtd/spi/spi-nor-core.c static const struct flash_info *spi_nor_read_id(struct · line 900

Quoted 10 lines
drivers/mtd/spi/spi-nor-core.c +3 -2
+                       }
                }
        }
 
-       dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",
-               id[0], id[1], id[2]);
+        dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n",
+                SPI_NOR_MAX_ID_LEN, id);
        return ERR_PTR(-ENODEV);
 }

--
Regards
Vignesh

author maintainer
#9 lore raw

PATCH 3/3 spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and n25q512*

Quoted 48 lines · Simon Goldschmidt

Hi Vignesh,

Quoted 36 lines · Vignesh Raghavendra

Simon,

Quoted 31 lines · Tudor.Ambarus at microchip.com

Hi, Simon,

Quoted 28 lines · Simon Goldschmidt

External E-Mail

Quoted 15 lines · Vignesh Raghavendra

Newer variants of n25q256* and n25q512* flashes support 4 Byte addressing opcodes. Add entries for the same. These flashes Bit 6 set in 5th byte of READ ID response.

---
 drivers/mtd/spi/spi-nor-ids.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 967537eafb55..0074073b123a 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 164

Quoted 4 lines
drivers/mtd/spi/spi-nor-ids.c +1 -0
@@ -161,11 +161,14 @@ const struct flash_info spi_nor_ids[] = {
        { INFO("n25q064a",    0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a11",  0x20bb18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
        { INFO("n25q128a13",  0x20ba18, 0, 64 * 1024,  256, SECT_4K | SPI_NOR_QUAD_READ) },
+       { INFO6("n25q256a",    0x20ba19, 0x104400, 64 * 1024,  512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },

From the discussion in the other thread, this should probably be named "mt25-something"? Seems like the 0x44 in the 5th byte wouldn't be found in the n25q256a?

Quoted 4 lines

Sorry, I thought mt25 parts are also marked as n25q based on your replies.. For now, I believe we can assume all devices with 0x44 in the 5th byte are mt25 parts and support 4 byte opcodes. Will next v2 with this assumptions.

Well, that's my fault. Seems I mixed up the parts here. Our switch to mt25 was earlier than I had thought and I was using boards with mt25 where I thought I had n25q before me... Sorry for the confusion!

Quoted 7 lines

I can however not tell you if all mt25 chips support 4 byte opcodes. The ones I have do though.

Oh, and there are also Altera/Intel EPCQ devices (e.g. on the socfpga_socrates) that are reported as n25q256a. I'd have to look at them as well to see if 4 byte opcodes are supported and what the full ID is.

I will go ahead and post patches with mt25* in the name. If we find parts with same ID code but sold as n25q* we can rename the entries or add new ones if ID codes are different.

Regards
Vignesh

Quoted 42 lines

Regards,
Simon

Quoted 39 lines

Regards
Vignesh

Quoted 21 lines

Probably yes, but the ultimate test would be to dump all the JEDEC ID bytes from the n25q256a flash, with code similar to that from below. It's not the first time that we see manufacturers messing with the JEDEC IDs or with the SFDP tables. It would be really helpful if you can dump the JEDEC ID bytes on a n25q256a.

drivers/mtd/spi/spi-nor-core.c +3 -1
index 1acff745d1a2..0be3496c5367 100644
@@ -885,13 +885,16 @@ static const struct flash_info *spi_nor_read_id(struct
 spi_nor *nor)
        info = spi_nor_ids;
        for (; info->name; info++) {
                if (info->id_len) {
-                       if (!memcmp(info->id, id, info->id_len))
+                       if (!memcmp(info->id, id, info->id_len)) {
+                               dev_err(nor->dev, "JEDEC id bytes: %*ph\n",
+                                       SPI_NOR_MAX_ID_LEN, id);
                                return info;

drivers/mtd/spi/spi-nor-core.c static const struct flash_info *spi_nor_read_id(struct · line 900

Quoted 10 lines
drivers/mtd/spi/spi-nor-core.c +3 -2
+                       }
                }
        }
 
-       dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",
-               id[0], id[1], id[2]);
+        dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n",
+                SPI_NOR_MAX_ID_LEN, id);
        return ERR_PTR(-ENODEV);
 }

--
Regards
Vignesh

Signature · 2 lines
Regards
Vignesh
#10 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

In reply to Vignesh Raghavendra

Hi Vignesh,

Quoted 5 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

Quoted 7 lines

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Regards,
Simon

Quoted 22 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

author maintainer
#11 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Hi Simon,

Quoted 10 lines · Simon Goldschmidt

Hi Vignesh,

Quoted 7 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Quoted 9 lines
Quoted 5 lines

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Did it ever work on your board ie did you test it when you were testing my patches porting SPI NOR framework from kernel?

What's the controller driver? Cadence QSPI?

Regards
Vignesh

Quoted 28 lines

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Regards,
Simon

Quoted 22 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

Signature · 2 lines
Regards
Vignesh
#12 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

HI Vignesh,

Quoted 20 lines · Vignesh Raghavendra

Hi Simon,

Quoted 16 lines · Simon Goldschmidt

Hi Vignesh,

Quoted 12 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Quoted 6 lines
Quoted 3 lines

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Did it ever work on your board ie did you test it when you were testing my patches porting SPI NOR framework from kernel?

I tested that series on the EBV Socrates (socfpga_socrates), while this is our custom board. It is similar, but the flash chips are different. So unfortunately, I don't know if it ever worked...

I'll try to run this series on socfpga_socrates soon.

Quoted 2 lines

What's the controller driver? Cadence QSPI?

Yes.

Regards,
Simon

Quoted 36 lines

Regards
Vignesh

Quoted 28 lines

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Regards,
Simon

Quoted 22 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

--
Regards
Vignesh

author maintainer
#13 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Quoted 34 lines · Simon Goldschmidt

HI Vignesh,

Quoted 20 lines · Vignesh Raghavendra

Hi Simon,

Quoted 16 lines · Simon Goldschmidt

Hi Vignesh,

Quoted 12 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Quoted 6 lines
Quoted 3 lines

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Did it ever work on your board ie did you test it when you were testing my patches porting SPI NOR framework from kernel?

I tested that series on the EBV Socrates (socfpga_socrates), while this is our custom board. It is similar, but the flash chips are different. So unfortunately, I don't know if it ever worked...

Quoted 6 lines

I'll try to run this series on socfpga_socrates soon.

Quoted 2 lines

What's the controller driver? Cadence QSPI?

Yes.

What does the DT snippet for flash node looks like? I think cadence QSPI is broken for SFDP if it has:

	spi-rx-bus-width = <4>;

Driver does:

       if (rx_width & SPI_RX_QUAD)
                /* Instruction and address at DQ0, data at DQ0-3. */
                rd_reg |= CQSPI_INST_TYPE_QUAD << CQSPI_REG_RD_INSTR_TYPE_DATA_LSB;

So, driver tries to execute SFDP command in 1-1-4 mode which is wrong.
For now try setting spi-rx-bus-width to 1 and see if SFDP works (of course this not the fix)

I have patches[1] to convert this driver to implement spi-mem framework which should help in fixing this issues. Will post them probably@the start of merge window after some more testing. If you have time, please give it a try

[1] https://github.com/r-vignesh/u-boot.git branch: cqspi

Regards
Vignesh

Quoted 40 lines

Regards,
Simon

Quoted 36 lines

Regards
Vignesh

Quoted 28 lines

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Regards,
Simon

Quoted 22 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

--
Regards
Vignesh

Signature · 2 lines
Regards
Vignesh
#14 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Hi Vignesh,

Quoted 50 lines · Vignesh Raghavendra
Quoted 34 lines · Simon Goldschmidt

HI Vignesh,

Quoted 20 lines · Vignesh Raghavendra

Hi Simon,

Quoted 16 lines · Simon Goldschmidt

Hi Vignesh,

Quoted 12 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Quoted 6 lines
Quoted 3 lines

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Did it ever work on your board ie did you test it when you were testing my patches porting SPI NOR framework from kernel?

I tested that series on the EBV Socrates (socfpga_socrates), while this is our custom board. It is similar, but the flash chips are different. So unfortunately, I don't know if it ever worked...

Quoted 6 lines

I'll try to run this series on socfpga_socrates soon.

Quoted 2 lines

What's the controller driver? Cadence QSPI?

Yes.

What does the DT snippet for flash node looks like? I think cadence QSPI is broken for SFDP if it has:

        spi-rx-bus-width = <4>;
Quoted 8 lines

Driver does:

       if (rx_width & SPI_RX_QUAD)
                /* Instruction and address at DQ0, data at DQ0-3. */
                rd_reg |= CQSPI_INST_TYPE_QUAD << CQSPI_REG_RD_INSTR_TYPE_DATA_LSB;

So, driver tries to execute SFDP command in 1-1-4 mode which is wrong.
For now try setting spi-rx-bus-width to 1 and see if SFDP works (of course this not the fix)

Right. That makes it work, thanks. I'll send the SFDP tables dump in the other thread.

Plus I can now test this series :-)

Quoted 5 lines

I have patches[1] to convert this driver to implement spi-mem framework which should help in fixing this issues. Will post them probably at the start of merge window after some more testing. If you have time, please give it a try

[1] https://github.com/r-vignesh/u-boot.git branch: cqspi

Oh, cool. That was on my list for some time now, but I haven't gotten around to even starting it.

Regards,
Simon

Quoted 49 lines

Regards
Vignesh

Quoted 40 lines

Regards,
Simon

Quoted 36 lines

Regards
Vignesh

Quoted 28 lines

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Regards,
Simon

Quoted 22 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

--
Regards
Vignesh

--
Regards
Vignesh

#15 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

In reply to Simon Goldschmidt

Hi, Simon,

Quoted 19 lines · Simon Goldschmidt

External E-Mail

Hi Vignesh,

Quoted 5 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

Quoted 7 lines

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Quoted 5 lines

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Can you please check what's written on the chip itself? Usually manufacturers write the chip name, and then the week and the year in the form week||year. Ex 4214, where week is 42 and the year 2014.

MT25QL256ABA datasheet says that: "Beginning
week 42 (2014), Micron's MT25Q production parts will include SFDP data that aligns with revision 1.6."

So maybe earlier versions don't have sfdp support?

Also, can you try this kind of patch? Let's dump the sfdp header. SPI_FLASH_SFDP_SUPPORT has to be selected.

drivers/mtd/spi/spi-nor-core.c +10 -2
index 1acff745d1a2..7e93be90fc09 100644
@@ -1815,14 +1815,22 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor,
 {
        const struct sfdp_parameter_header *param_header, *bfpt_header;
        struct sfdp_parameter_header *param_headers = NULL;
-       struct sfdp_header header;
+       struct sfdp_header header = {};
+       u32 *sfdp_table = (u32 *)&header;
        size_t psize;
        int i, err;
 
        /* Get the SFDP header. */
        err = spi_nor_read_sfdp(nor, 0, sizeof(header), &header);
-       if (err < 0)
+       if (err < 0) {
+               dev_err(nor->dev, "spi_nor_read_sfdp err = %d\n", err);
                return err;
+       }
+
+       for (i = 0; i < sizeof(header) / sizeof(u32); i++) {
+               sfdp_table[i] = le32_to_cpu(sfdp_table[i]);
+               dev_err(nor->dev, "sfdp_table[%d] = %08x\n", i, sfdp_table[i]);
+       }
 
 
Quoted 31 lines

Regards,
Simon

Quoted 16 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
Quoted 6 lines
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#16 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Hi Tudor,

Quoted 33 lines · On Tue, Sep 24, 2019 at 11:23 AM <[email protected]> wrote:

Hi, Simon,

Quoted 19 lines · Simon Goldschmidt

External E-Mail

Hi Vignesh,

Quoted 5 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

Quoted 7 lines

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Quoted 5 lines

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Can you please check what's written on the chip itself? Usually manufacturers write the chip name, and then the week and the year in the form week||year. Ex 4214, where week is 42 and the year 2014.

Quoted 5 lines

MT25QL256ABA datasheet says that: "Beginning
week 42 (2014), Micron's MT25Q production parts will include SFDP data that aligns with revision 1.6."

So maybe earlier versions don't have sfdp support?

Problem solved. It was a driver issue, not a chip issue (see last mails).

Regards,
Simon

Quoted 63 lines

Also, can you try this kind of patch? Let's dump the sfdp header. SPI_FLASH_SFDP_SUPPORT has to be selected.

drivers/mtd/spi/spi-nor-core.c +10 -2
index 1acff745d1a2..7e93be90fc09 100644
@@ -1815,14 +1815,22 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor,
 {
        const struct sfdp_parameter_header *param_header, *bfpt_header;
        struct sfdp_parameter_header *param_headers = NULL;
-       struct sfdp_header header;
+       struct sfdp_header header = {};
+       u32 *sfdp_table = (u32 *)&header;
        size_t psize;
        int i, err;
 
        /* Get the SFDP header. */
        err = spi_nor_read_sfdp(nor, 0, sizeof(header), &header);
-       if (err < 0)
+       if (err < 0) {
+               dev_err(nor->dev, "spi_nor_read_sfdp err = %d\n", err);
                return err;
+       }
+
+       for (i = 0; i < sizeof(header) / sizeof(u32); i++) {
+               sfdp_table[i] = le32_to_cpu(sfdp_table[i]);
+               dev_err(nor->dev, "sfdp_table[%d] = %08x\n", i, sfdp_table[i]);
+       }
 
 
Quoted 31 lines

Regards,
Simon

Quoted 16 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
Quoted 6 lines
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#17 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

In reply to Vignesh Raghavendra

Hi Vignesh,

I've check this patches on top of 31e086e460f.
The read/write/erase seems to work.

However, as I can see 'sf protect lock' doesn't work - it finish successfully but the area remains unlocked. As I remember It worked with old u-boot spi-nor code, but I need to check it.

---
Eugeniy Paltsev

________________________________________
From: Vignesh Raghavendra <[email protected]>
Sent: Tuesday, September 24, 2019 08:56
To: Jagan Teki; Eugeniy Paltsev; Ashish Kumar; Simon Goldschmidt
Cc: Vignesh Raghavendra; u-boot at lists.denx.de; Tom Rini; Alexey Brodkin
Subject: [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

author maintainer
#18 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Quoted 6 lines · Eugeniy Paltsev

Hi Vignesh,

I've check this patches on top of 31e086e460f.
The read/write/erase seems to work.

However, as I can see 'sf protect lock' doesn't work - it finish successfully but the area remains unlocked.

Did you verify that area is indeed unlocked by writing data and then reading it back? I was able to find a board with mt25qu512a which is same as n25q512a in terms of locking I see it works fine:

=> sf probe
SF: Detected n25q512a with page size 256 Bytes, erase size 4 KiB, total 64 MiB => sf protect lock 0 0x4000000; echo $?
0
=> sf write 0x82000000 0x3FF0000 0x100
device 0 offset 0x3ff0000, size 0x100
SF: 256 bytes @ 0x3ff0000 Written: ERROR -5

If you still see failures wrt locking, could you provide debug logs from spi_mem_exec_op() (in drivers/spi/spi-mem.c) just like last time?

Regards
Vignesh

Quoted 46 lines

As I remember It worked with old u-boot spi-nor code, but I need to check it.

---
Eugeniy Paltsev

________________________________________
From: Vignesh Raghavendra <[email protected]>
Sent: Tuesday, September 24, 2019 08:56
To: Jagan Teki; Eugeniy Paltsev; Ashish Kumar; Simon Goldschmidt
Cc: Vignesh Raghavendra; u-boot at lists.denx.de; Tom Rini; Alexey Brodkin
Subject: [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

Signature · 2 lines
Regards
Vignesh
#19 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Hi Vignesh,

I've tested your "[U-Boot,RFT,v2,0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing " series applies on the latest master (879396a2405).
'axs103_defconfig' was used without changes.

Probe/read/write/erase work for n25q512ax3.

Lock/unlock don't work, so here is debug log:
(I've tried to run lock/unlock after unlock/lock and write/erase after lock, so I guess it will cover all combinations useful for debug)

--------------------->8--------------------------
AXS# sf probe && echo OK

9f | [6B in] 20 ba 20 10 00 00 [ret 0]
06 | [0B -] [ret 0]
b7 | [0B -] [ret 0]
04 | [0B -] [ret 0]

SF: Detected n25q512ax3 with page size 256 Bytes, erase size 4 KiB, total 64 MiB OK
AXS# sf protect lock 0x0 0x4000000 && echo OK
05 | [1B in] 9c [ret 0]
OK
AXS# mw 0x81000000 0 5 && sf write 0x81000000 0x180000 0x10 && echo OK device 0 offset 0x180000, size 0x10
06 | [0B -] [ret 0]
02 00 18 00 00 | [16B out] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ret 0] 05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
SF: 16 bytes @ 0x180000 Written: OK
OK
AXS# sf protect unlock 0x0 0x4000000 && echo OK

05 | [1B in] 9c [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 00 [ret 0]
05 | [1B in] 00 [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 00 [ret 0]
OK
AXS# sf protect lock 0x0 0x4000000 && echo OK
05 | [1B in] 00 [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 9c [ret 0]
05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 9c [ret 0]

OK
AXS# sf protect lock 0x0 0x4000000 && echo OK
05 | [1B in] 9c [ret 0]
OK
AXS#
AXS#
AXS# sf protect unlock 0x0 0x4000000 && echo OK

05 | [1B in] 9c [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 00 [ret 0]
05 | [1B in] 00 [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 00 [ret 0]

OK
AXS# sf protect unlock 0x0 0x4000000 && echo OK
05 | [1B in] 00 [ret 0]
OK
AXS#
AXS#
AXS# sf protect lock 0x0 0x4000000 && echo OK

05 | [1B in] 00 [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 9c [ret 0]
05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 9c [ret 0]

OK
AXS# sf erase 0x180000 0x1000 && echo OK
06 | [0B -] [ret 0]
20 00 18 00 00 | [0B -] [ret 0]

05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
04 | [0B -] [ret 0]

SF: 4096 bytes @ 0x180000 Erased: OK
OK
AXS# sf read 0x81000000 0x180000 0x10 && md.b 0x81000000 0x10 && echo OK device 0 offset 0x180000, size 0x10
0b 00 18 00 00 | [16B in] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ret 0]
SF: 16 bytes @ 0x180000 Read: OK
81000000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
OK
AXS# mw 0x81000000 0 5 && sf write 0x81000000 0x180000 0x10 && echo OK device 0 offset 0x180000, size 0x10
06 | [0B -] [ret 0]
02 00 18 00 00 | [16B out] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ret 0] 05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
SF: 16 bytes @ 0x180000 Written: OK
OK
AXS# sf read 0x81000000 0x180000 0x10 && echo OK
device 0 offset 0x180000, size 0x10
0b 00 18 00 00 | [16B in] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ret 0]
SF: 16 bytes @ 0x180000 Read: OK
OK
--------------------->8--------------------------

---
Eugeniy Paltsev

________________________________________
From: Vignesh Raghavendra <[email protected]>
Sent: Wednesday, September 25, 2019 11:11
To: Eugeniy Paltsev; Jagan Teki; Ashish Kumar; Simon Goldschmidt
Cc: u-boot at lists.denx.de; Tom Rini; Alexey Brodkin
Subject: Re: [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Quoted 6 lines · Eugeniy Paltsev

Hi Vignesh,

I've check this patches on top of 31e086e460f.
The read/write/erase seems to work.

However, as I can see 'sf protect lock' doesn't work - it finish successfully but the area remains unlocked.

Did you verify that area is indeed unlocked by writing data and then reading it back? I was able to find a board with mt25qu512a which is same as n25q512a in terms of locking I see it works fine:

=> sf probe
SF: Detected n25q512a with page size 256 Bytes, erase size 4 KiB, total 64 MiB => sf protect lock 0 0x4000000; echo $?
0
=> sf write 0x82000000 0x3FF0000 0x100
device 0 offset 0x3ff0000, size 0x100
SF: 256 bytes @ 0x3ff0000 Written: ERROR -5

If you still see failures wrt locking, could you provide debug logs from spi_mem_exec_op() (in drivers/spi/spi-mem.c) just like last time?

Regards
Vignesh

Quoted 40 lines

As I remember It worked with old u-boot spi-nor code, but I need to check it.

---
Eugeniy Paltsev

________________________________________
From: Vignesh Raghavendra <[email protected]>
Sent: Tuesday, September 24, 2019 08:56
To: Jagan Teki; Eugeniy Paltsev; Ashish Kumar; Simon Goldschmidt
Cc: Vignesh Raghavendra; u-boot at lists.denx.de; Tom Rini; Alexey Brodkin
Subject: [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
Quoted 6 lines
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

--
Regards
Vignesh

author maintainer
#20 lore raw

cover spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Hi Eugeniy,

Quoted 7 lines · Eugeniy Paltsev

Hi Vignesh,

I've tested your "[U-Boot,RFT,v2,0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing " series applies on the latest master (879396a2405).
'axs103_defconfig' was used without changes.

Quoted 1 line

Probe/read/write/erase work for n25q512ax3.

Thanks for the testing!

Quoted 9 lines

Lock/unlock don't work, so here is debug log:
(I've tried to run lock/unlock after unlock/lock and write/erase after lock, so I guess it will cover all combinations useful for debug)

--------------------->8--------------------------
AXS# sf probe && echo OK

9f | [6B in] 20 ba 20 10 00 00 [ret 0]
06 | [0B -] [ret 0]
b7 | [0B -] [ret 0]
04 | [0B -] [ret 0]
Quoted 5 lines

SF: Detected n25q512ax3 with page size 256 Bytes, erase size 4 KiB, total 64 MiB OK
AXS# sf protect lock 0x0 0x4000000 && echo OK
05 | [1B in] 9c [ret 0]
OK

You are trying to lock entire 64MB space. Per Data sheet of flash, this requires setting BP3-BP0 bits in Status register. But only BP2-BP0 are set

Neither the old framework nor current framework (or even Linux kernel) supports handling of BP3 bit. So this failure is _not a regression_.

In this particular case, U-Boot code sets only BP2-BP0 when asked to lock entire 64MB range. But this effectively locks sectors 960 to 1023.

Regards
Vignesh

Quoted 273 lines

AXS# mw 0x81000000 0 5 && sf write 0x81000000 0x180000 0x10 && echo OK device 0 offset 0x180000, size 0x10
06 | [0B -] [ret 0]
02 00 18 00 00 | [16B out] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ret 0] 05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
SF: 16 bytes @ 0x180000 Written: OK
OK
AXS# sf protect unlock 0x0 0x4000000 && echo OK

05 | [1B in] 9c [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 00 [ret 0]
05 | [1B in] 00 [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 00 [ret 0]
OK
AXS# sf protect lock 0x0 0x4000000 && echo OK
05 | [1B in] 00 [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 9c [ret 0]
05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 9c [ret 0]

OK
AXS# sf protect lock 0x0 0x4000000 && echo OK
05 | [1B in] 9c [ret 0]
OK
AXS#
AXS#
AXS# sf protect unlock 0x0 0x4000000 && echo OK

05 | [1B in] 9c [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 00 [ret 0]
05 | [1B in] 00 [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 00 [ret 0]

OK
AXS# sf protect unlock 0x0 0x4000000 && echo OK
05 | [1B in] 00 [ret 0]
OK
AXS#
AXS#
AXS# sf protect lock 0x0 0x4000000 && echo OK

05 | [1B in] 00 [ret 0]
06 | [0B -] [ret 0]
01 | [1B out] 9c [ret 0]
05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
05 | [1B in] 9c [ret 0]

OK
AXS# sf erase 0x180000 0x1000 && echo OK
06 | [0B -] [ret 0]
20 00 18 00 00 | [0B -] [ret 0]

05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9f [ret 0]
70 | [1B in] 01 [ret 0]
05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
04 | [0B -] [ret 0]

SF: 4096 bytes @ 0x180000 Erased: OK
OK
AXS# sf read 0x81000000 0x180000 0x10 && md.b 0x81000000 0x10 && echo OK device 0 offset 0x180000, size 0x10
0b 00 18 00 00 | [16B in] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ret 0]
SF: 16 bytes @ 0x180000 Read: OK
81000000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
OK
AXS# mw 0x81000000 0 5 && sf write 0x81000000 0x180000 0x10 && echo OK device 0 offset 0x180000, size 0x10
06 | [0B -] [ret 0]
02 00 18 00 00 | [16B out] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ret 0] 05 | [1B in] 9c [ret 0]
70 | [1B in] 81 [ret 0]
SF: 16 bytes @ 0x180000 Written: OK
OK
AXS# sf read 0x81000000 0x180000 0x10 && echo OK
device 0 offset 0x180000, size 0x10
0b 00 18 00 00 | [16B in] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ret 0]
SF: 16 bytes @ 0x180000 Read: OK
OK
--------------------->8--------------------------

---
Eugeniy Paltsev

________________________________________
From: Vignesh Raghavendra <[email protected]>
Sent: Wednesday, September 25, 2019 11:11
To: Eugeniy Paltsev; Jagan Teki; Ashish Kumar; Simon Goldschmidt
Cc: u-boot at lists.denx.de; Tom Rini; Alexey Brodkin
Subject: Re: [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Quoted 6 lines · Eugeniy Paltsev

Hi Vignesh,

I've check this patches on top of 31e086e460f.
The read/write/erase seems to work.

However, as I can see 'sf protect lock' doesn't work - it finish successfully but the area remains unlocked.

Did you verify that area is indeed unlocked by writing data and then reading it back? I was able to find a board with mt25qu512a which is same as n25q512a in terms of locking I see it works fine:

=> sf probe
SF: Detected n25q512a with page size 256 Bytes, erase size 4 KiB, total 64 MiB => sf protect lock 0 0x4000000; echo $?
0
=> sf write 0x82000000 0x3FF0000 0x100
device 0 offset 0x3ff0000, size 0x100
SF: 256 bytes @ 0x3ff0000 Written: ERROR -5

If you still see failures wrt locking, could you provide debug logs from spi_mem_exec_op() (in drivers/spi/spi-mem.c) just like last time?

Regards
Vignesh

Quoted 40 lines

As I remember It worked with old u-boot spi-nor code, but I need to check it.

---
Eugeniy Paltsev

________________________________________
From: Vignesh Raghavendra <[email protected]>
Sent: Tuesday, September 24, 2019 08:56
To: Jagan Teki; Eugeniy Paltsev; Ashish Kumar; Simon Goldschmidt
Cc: Vignesh Raghavendra; u-boot at lists.denx.de; Tom Rini; Alexey Brodkin
Subject: [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
Quoted 6 lines
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

--
Regards
Vignesh

Signature · 2 lines
Regards
Vignesh