armv7: ls102xa: add errata ID A-008646 for workaround
PATCH v2 1/2 armv7: ls102xa: add errata ID A-008646 for workaround
The patch adds errata ID A-008646 for workaround
---
Change in v2:
- split one patch to two patches
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +1 -1
@@ -68,7 +68,7 @@ static void __secure ls1_deepsleep_irq_cfg(void) ippdexpcr0 =in_be32 (&rcpm->ippdexpcr0);/* -* Workaround: There is bug of register ippdexpcr1, when read it always +* Workaround of errata A-008646: There is bug of register ippdexpcr1, when read it always * returns zero, so its value is saved to a scrachpad register to be * read, that is why we don't read it from register ippdexpcr1 itself. */
Signature · 1 line
2.17.1
PATCH v2 2/2 armv7: ls102xa: not power down OCRAM1
The patch always not power down OCRAM1
for wakeup source to wakeup system in
deep sleep
---
Change in v2:
- split one patch to two patches
- always not power down OCRAM1
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +2 -1
@@ -73,7 +73,8 @@ static void __secure ls1_deepsleep_irq_cfg(void)* read, that is why we don't read it from register ippdexpcr1 itself. */ ippdexpcr1 =in_le32 (&scfg->sparecr[7 ]); -out_be32 (&rcpm->ippdexpcr1, ippdexpcr1); +/* Always not power down OCRAM1 */ +out_be32 (&rcpm->ippdexpcr1, ippdexpcr1 |RCPM_IPPDEXPCR1_OCRAM1 );if (ippdexpcr0 &RCPM_IPPDEXPCR0_ETSEC ) pmcintecr |= SCFG_PMCINTECR_ETSECRXG0 |
Signature · 1 line
2.17.1
PATCH v2 2/2 armv7: ls102xa: not power down OCRAM1
Quoted 12 lines
-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Tuesday, September 24, 2019 12:49 PM
To: albert.u.boot at aribaud.net; Prabhakar X <[email protected]>; Rajesh Bhagat <[email protected]>; Priyanka Jain <[email protected]>; Ran Wang <[email protected]>; Leo Li <[email protected]>; Jagdish Gediya <[email protected]>
Cc: u-boot at lists.denx.de; Biwen Li <[email protected]>
Subject: [v2,2/2] armv7: ls102xa: not power down OCRAM1
Quoted 3 lines
The patch always not power down OCRAM1
for wakeup source to wakeup system in
deep sleep
Please provide a better description.
--priyankajain
Quoted 28 lines
Signed-off-by Biwen Li <[email protected]>---
Change in v2:
- split one patch to two patches
- always not power down OCRAM1
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +2
-1@@ -73,7 +73,8 @@ static void __secure ls1_deepsleep_irq_cfg(void)* read, that is why we don't read it from register ippdexpcr1 itself. */ ippdexpcr1 =in_le32 (&scfg->sparecr[7 ]); -out_be32 (&rcpm->ippdexpcr1, ippdexpcr1); +/* Always not power down OCRAM1 */ +out_be32 (&rcpm->ippdexpcr1, ippdexpcr1 |RCPM_IPPDEXPCR1_OCRAM1 );if (ippdexpcr0 &RCPM_IPPDEXPCR0_ETSEC )pmcintecr |= SCFG_PMCINTECR_ETSECRXG0 |--
2.17.1
PATCH v2 2/2 armv7: ls102xa: not power down OCRAM1
: [v2,2/2] armv7: ls102xa: not power down OCRAM1
Quoted 5 lines
Quoted 4 lines
The patch always not power down OCRAM1
for wakeup source to wakeup system in
deep sleepPlease provide a better description.
Okay, got it, I will provide it in v3.
Quoted 30 lines
--priyankajain
Quoted 28 lines
Signed-off-by Biwen Li <[email protected]>---
Change in v2:
- split one patch to two patches
- always not power down OCRAM1
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +2
-1@@ -73,7 +73,8 @@ static void __secure ls1_deepsleep_irq_cfg(void)* read, that is why we don't read it from register ippdexpcr1 itself. */ ippdexpcr1 =in_le32 (&scfg->sparecr[7 ]); -out_be32 (&rcpm->ippdexpcr1, ippdexpcr1); +/* Always not power down OCRAM1 */ +out_be32 (&rcpm->ippdexpcr1, ippdexpcr1 |RCPM_IPPDEXPCR1_OCRAM1 );if (ippdexpcr0 &RCPM_IPPDEXPCR0_ETSEC )pmcintecr |= SCFG_PMCINTECR_ETSECRXG0 |--
2.17.1
PATCH v2 1/2 armv7: ls102xa: add errata ID A-008646 for workaround
In reply to Biwen LiQuoted 12 lines
-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Tuesday, September 24, 2019 12:49 PM
To: albert.u.boot at aribaud.net; Prabhakar X <[email protected]>; Rajesh Bhagat <[email protected]>; Priyanka Jain <[email protected]>; Ran Wang <[email protected]>; Leo Li <[email protected]>; Jagdish Gediya <[email protected]>
Cc: u-boot at lists.denx.de; Biwen Li <[email protected]>
Subject: [v2,1/2] armv7: ls102xa: add errata ID A-008646 for workaround
Quoted 2 lines
The patch adds errata ID A-008646 for workaround
Only comment is updated in this patch.
Update subject and description to reflect this.
Quoted 20 lines
Signed-off-by Biwen Li <[email protected]>---
Change in v2:
- split one patch to two patches
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +0
-1@@ -68,7 +68,7 @@ static void __secure ls1_deepsleep_irq_cfg(void) ippdexpcr0 =in_be32 (&rcpm->ippdexpcr0);/* -* Workaround: There is bug of register ippdexpcr1, when read it always
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +1
-0+* Workaround of errata A-008646: There is bug of register ippdexpcr1,
Quoted 1 line
when read it always
Line over 80 characters
Test and fix checkpatch errors before submitting patch
--priyankajain
Quoted 5 lines
* returns zero, so its value is saved to a scrachpad register to be
* read, that is why we don't read it from register ippdexpcr1 itself. */
--
2.17.1
PATCH v2 1/2 armv7: ls102xa: add errata ID A-008646 for workaround
Quoted 20 lines
Quoted 3 lines
The patch adds errata ID A-008646 for workaround
Only comment is updated in this patch.
Update subject and description to reflect this.Quoted 15 lines
Signed-off-by Biwen Li <[email protected]>---
Change in v2:
- split one patch to two patches
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +0
-0@@ -68,7 +68,7 @@ static void __secure ls1_deepsleep_irq_cfg(void)
Quoted 9 lines
Quoted 7 lines
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +0
-1ippdexpcr0 =in_be32 (&rcpm->ippdexpcr0);/* -* Workaround: There is bug of register ippdexpcr1, when read it always
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +2
-0+ * Workaround of errata A-008646: There is bug of register +ippdexpcr1,when read it always
Line over 80 characters
Test and fix checkpatch errors before submitting patch
Okay, got it, I will fix it in v3.
Quoted 7 lines
--priyankajain
Quoted 5 lines
* returns zero, so its value is saved to a scrachpad register to be
* read, that is why we don't read it from register ippdexpcr1 itself. */
--
2.17.1