Skip to contentSkip to conversation

scsi: libcxgbi: remove unused function to stop warning

PATCH Applied Austin Kim 2 participants 2 messages Sep 24, 2019 – Oct 1, 2019 SCSI

lore
Share & tools
lore

Austin Kim

author
#0 lore raw

PATCH 1/1 scsi: libcxgbi: remove unused function to stop warning

Since 'commit fc8d0590d914 ("libcxgbi: Add ipv6 api to driver")' was introduced, there is no call to csk_print_port()
and csk_print_ip() is made.

Hence kernel build with clang complains below message:
drivers/scsi/cxgbi/libcxgbi.c:2287:19: warning: unused function 'csk_print_port' [-Wunused-function] static inline int csk_print_port(struct cxgbi_sock *csk, char *buf)

                          ^
   drivers/scsi/cxgbi/libcxgbi.c:2298:19: warning: unused function 'csk_print_ip' [-Wunused-function]
   static inline int csk_print_ip(struct cxgbi_sock *csk, char *buf)
                        ^

So it had better remove csk_print_port() and csk_print_ip() to stop warning.

---
 drivers/scsi/cxgbi/libcxgbi.c | 28 ----------------------------
 1 file changed, 28 deletions(-)
drivers/scsi/cxgbi/libcxgbi.c +0 -28
index 3e17af8..0d044c1 100644
@@ -2284,34 +2284,6 @@ int cxgbi_set_conn_param(struct iscsi_cls_conn *cls_conn,
 }
 EXPORT_SYMBOL_GPL(cxgbi_set_conn_param);
 
-static inline int csk_print_port(struct cxgbi_sock *csk, char *buf)
-{
-	int len;
-
-	cxgbi_sock_get(csk);
-	len = sprintf(buf, "%hu\n", ntohs(csk->daddr.sin_port));
-	cxgbi_sock_put(csk);
-
-	return len;
-}
-
-static inline int csk_print_ip(struct cxgbi_sock *csk, char *buf)
-{
-	int len;
-
-	cxgbi_sock_get(csk);
-	if (csk->csk_family == AF_INET)
-		len = sprintf(buf, "%pI4",
-			      &csk->daddr.sin_addr.s_addr);
-	else
-		len = sprintf(buf, "%pI6",
-			      &csk->daddr6.sin6_addr);
-
-	cxgbi_sock_put(csk);
-
-	return len;
-}
-
 int cxgbi_get_ep_param(struct iscsi_endpoint *ep, enum iscsi_param param,
 		       char *buf)
 {
Signature · 1 line
2.6.2
#1 lore raw

Austin,

Quoted 3 lines

Since 'commit fc8d0590d914 ("libcxgbi: Add ipv6 api to driver")' was introduced, there is no call to csk_print_port()
and csk_print_ip() is made.

Applied to 5.5/scsi-queue. Thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering