Skip to contentSkip to conversation

libnvdimm/region: Update is_nvdimm_sync check to handle volatile regions

PATCH In review Aneesh Kumar K.V 3 participants 5 messages Sep 24, 2019 – Sep 25, 2019 libnvdimm: non-volatile memory device

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libnvdimm/region: Update is_nvdimm_sync check to handle volatile regions

We should consider volatile regions synchronous so that we are resilient to OS crashes. This is needed when we have hypervisor like KVM exporting a ramdisk as pmem dimms.

---
 drivers/nvdimm/region_devs.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvdimm/region_devs.c +3 -0
index ab91890f2486..ef423ba1a711 100644
@@ -1168,6 +1168,9 @@ EXPORT_SYMBOL_GPL(nvdimm_has_cache);
 
 bool is_nvdimm_sync(struct nd_region *nd_region)
 {
+	if (is_nd_volatile(&nd_region->dev))
+		return true;
+
 	return is_nd_pmem(&nd_region->dev) &&
 		!test_bit(ND_REGION_ASYNC, &nd_region->flags);
 }
Signature · 6 lines
2.21.0

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines

We should consider volatile regions synchronous so that we are resilient to OS crashes. This is needed when we have hypervisor like KVM exporting a ramdisk
as pmem dimms.

---
 drivers/nvdimm/region_devs.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvdimm/region_devs.c +3 -1
index ab91890f2486..ef423ba1a711 100644
@@ -1168,6 +1168,9 @@ EXPORT_SYMBOL_GPL(nvdimm_has_cache);
 
 bool is_nvdimm_sync(struct nd_region *nd_region)
 {
+	if (is_nd_volatile(&nd_region->dev))
+		return true;
+
 	return is_nd_pmem(&nd_region->dev) &&
 		!test_bit(ND_REGION_ASYNC, &nd_region->flags);
 }
--
Quoted 1 line

2.21.0

Quoted 6 lines

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

#2 lore raw
In reply to Aneesh Kumar K.V
Quoted 4 lines · Aneesh Kumar K.V

We should consider volatile regions synchronous so that we are resilient to OS crashes. This is needed when we have hypervisor like KVM exporting a ramdisk as pmem dimms.

We have a hard time understanding what agent is being referenced when we use "we" in a patch changelog. We would prefer that we consider not using "we" in favor of explicitly named agents, or otherwise review the changelog to make sure that "we" is clearly discernable. We will fix it up this time when applying, but we hope we have made it clear how confusing liberal use of "we" can be.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

#3 lore raw
Quoted 8 lines · Dan Williams
Quoted 4 lines · Aneesh Kumar K.V

We should consider volatile regions synchronous so that we are resilient to OS crashes. This is needed when we have hypervisor like KVM exporting a ramdisk as pmem dimms.

Quoted 6 lines

We have a hard time understanding what agent is being referenced when we use "we" in a patch changelog. We would prefer that we consider not using "we" in favor of explicitly named agents, or otherwise review the changelog to make sure that "we" is clearly discernable. We will fix it up this time when applying, but we hope we have made it clear how confusing liberal use of "we" can be.

To be clear, I'm not strictly opposed to using "we" when it is established which we is being referred and stays constant throughout the description. This instance caught my eye again because the first couple "we"s seems to be the kernel, and the last we seems to be a user platform configuration.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

#4 lore raw

Hi Dan,

Quoted 16 lines · Dan Williams
Quoted 8 lines · Dan Williams
Quoted 4 lines · Aneesh Kumar K.V

We should consider volatile regions synchronous so that we are resilient to OS crashes. This is needed when we have hypervisor like KVM exporting a ramdisk as pmem dimms.

Quoted 6 lines

We have a hard time understanding what agent is being referenced when we use "we" in a patch changelog. We would prefer that we consider not using "we" in favor of explicitly named agents, or otherwise review the changelog to make sure that "we" is clearly discernable. We will fix it up this time when applying, but we hope we have made it clear how confusing liberal use of "we" can be.

Quoted 6 lines

To be clear, I'm not strictly opposed to using "we" when it is established which we is being referred and stays constant throughout the description. This instance caught my eye again because the first couple "we"s seems to be the kernel, and the last we seems to be a user platform configuration.

Thanks for the feedback. I will take extra care to clearly indicate the component/agent next time.

Thanks for taking the patch.

-aneesh

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm