parisc: remove 32-bit DMA enforcement from sba_iommu
PATCH 1/1 parisc: remove 32-bit DMA enforcement from sba_iommu
This breaks booting from sata_sil24 with the recent DMA change. According to James Bottomley this was in to improve performance. Remove it for now to make DMA working again.
--- drivers/parisc/sba_iommu.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/parisc/sba_iommu.c +0 -8
@@ -678,14 +678,6 @@ static int sba_dma_supported( struct device *dev, u64 mask)return (0 ); } -/* Documentation/DMA-API-HOWTO.txt tells drivers to try 64-bit -* first, then fall back to 32-bit if that fails. -* We are just "encouraging" 32-bit DMA masks here since we can -* never allow IOMMU bypass unless we add special support for ZX1. -*/ -if (mask > ~0U ) -return 0 ; - ioc =GET_IOC (dev);if (!ioc)return 0 ;
Signature · 1 line
2.23.0.rc1
Helge,
Quoted 31 lines · Sven Schnelle
This breaks booting from
sata_sil24with the recent DMA change. According to James Bottomley this was in to improve performance. Remove it for now to make DMA working again.Signed-off-by Sven Schnelle <[email protected]>--- drivers/parisc/sba_iommu.c | 8 -------- 1 file changed, 8 deletions(-)drivers/parisc/sba_iommu.c +0
-8@@ -678,14 +678,6 @@ static int sba_dma_supported( struct device *dev, u64 mask)return (0 ); } -/* Documentation/DMA-API-HOWTO.txt tells drivers to try 64-bit -* first, then fall back to 32-bit if that fails. -* We are just "encouraging" 32-bit DMA masks here since we can -* never allow IOMMU bypass unless we add special support for ZX1. -*/ -if (mask > ~0U ) -return 0 ; - ioc =GET_IOC (dev);if (!ioc)return 0 ;Signature · 1 line
2.23.0.rc1
please drop that patch for now. With 64-bit DMA my C8000 crashes with HPMCs likely caused by invalid DMA transfers. So i have to read up a bit on the DMA capabilites, and what "since we can never allow IOMMU bypass unless we add special support for ZX1" means.
The other option is to prepare a patch that limits the DMA mask with the API Christoph mentioned, but i would first like to understand the capabilities of the chipset.
Regards
Sven