Skip to contentSkip to conversation

srp_daemon: print maximum initiator to target IU size

PATCH Applied Honggang LI 3 participants 3 messages Sep 25, 2019 – Oct 29, 2019 InfiniBand

lore
Share & tools
lore

Honggang LI

author
#0 lore raw

PATCH v2 1/1 srp_daemon: print maximum initiator to target IU size

From: Honggang Li <[email protected]>

The 'Send Message Size' field of IOControllerProfile attributes contains the maximum initiator to target IU size.

When there is something wrong with SRP login to a third party SRP target, whose ib_srpt parameters can't be collected with ordinary method, dump the 'Send Message Size' may help us to diagnose the problem.

Signed-off-by Honggang Li <[email protected]>
---
 srp_daemon/srp_daemon.c | 2 ++
 1 file changed, 2 insertions(+)
srp_daemon/srp_daemon.c +2 -0
index 337b21c7..cf046b79 100644
@@ -1022,6 +1022,8 @@ static int do_port(struct resources *res, uint16_t pkey, uint16_t dlid,
 			pr_human("        vendor ID: %06x\n", be32toh(target->ioc_prof.vendor_id) >> 8);
 			pr_human("        device ID: %06x\n", be32toh(target->ioc_prof.device_id));
 			pr_human("        IO class : %04hx\n", be16toh(target->ioc_prof.io_class));
+			pr_human("        Maximum size of Send Messages in bytes: %d\n",
+				 be32toh(target->ioc_prof.send_size));
 			pr_human("        ID:        %s\n", target->ioc_prof.id);
 			pr_human("        service entries: %d\n", target->ioc_prof.service_entries);
Signature · 1 line
2.21.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 21 lines · Honggang LI

From: Honggang Li <[email protected]>

The 'Send Message Size' field of IOControllerProfile attributes contains the maximum initiator to target IU size.

When there is something wrong with SRP login to a third party SRP target, whose ib_srpt parameters can't be collected with ordinary method, dump the 'Send Message Size' may help us to diagnose the problem.

Signed-off-by Honggang Li <[email protected]>
---
 srp_daemon/srp_daemon.c | 2 ++
 1 file changed, 2 insertions(+)
srp_daemon/srp_daemon.c +0 -0
index 337b21c7..cf046b79 100644

srp_daemon/srp_daemon.c static int do_port(struct resources *res, uint16_t pkey, uint16_t dlid, · line 1029

Quoted 8 lines
srp_daemon/srp_daemon.c +2 -0
@@ -1022,6 +1022,8 @@ static int do_port(struct resources *res, uint16_t pkey, uint16_t dlid,
 			pr_human("        vendor ID: %06x\n", be32toh(target->ioc_prof.vendor_id) >> 8);
 			pr_human("        device ID: %06x\n", be32toh(target->ioc_prof.device_id));
 			pr_human("        IO class : %04hx\n", be16toh(target->ioc_prof.io_class));
+			pr_human("        Maximum size of Send Messages in bytes: %d\n",
+				 be32toh(target->ioc_prof.send_size));
 			pr_human("        ID:        %s\n", target->ioc_prof.id);
 			pr_human("        service entries: %d\n", target->ioc_prof.service_entries);
Reviewed-by Bart Van Assche <[email protected]>
Applied
#2 lore raw
In reply to Honggang LI
Quoted 10 lines · Honggang LI

From: Honggang Li <[email protected]>

The 'Send Message Size' field of IOControllerProfile attributes contains the maximum initiator to target IU size.

When there is something wrong with SRP login to a third party SRP target, whose ib_srpt parameters can't be collected with ordinary method, dump the 'Send Message Size' may help us to diagnose the problem.

Quoted 5 lines
Signed-off-by Honggang Li <[email protected]>
Reviewed-by Bart Van Assche <[email protected]>
---
 srp_daemon/srp_daemon.c | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks

Things will go faster if you send rdma-core patches as PRs.. It saves me a bunch of work :)

Jason