drm/vmwgfx: prevent memory leak in vmw_context_define
Subsystems (3)
PATCH 1/1 drm/vmwgfx: prevent memory leak in vmw_context_define
In vmw_context_define if vmw_context_init fails the allocated resource should be unreferenced. The goto label was fixed.
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vmwgfx/vmwgfx_context.c +1 -1
@@ -773,7 +773,7 @@ static int vmw_context_define(struct drm_device *dev, void *data, ret =vmw_context_init (dev_priv, res, vmw_user_context_free, dx);if (unlikely (ret !=0 )) - goto out_unlock; + goto out_err; tmp =vmw_resource_reference (&ctx->res); ret = ttm_base_object_init(tfile, &ctx->base, false, VMW_RES_CONTEXT,
Signature · 1 line
2.17.1
Quoted 13 lines · Navid Emamdoost
In
vmw_context_defineifvmw_context_initfails the allocated resource should be unreferenced. The goto label was fixed.Signed-off-by Navid Emamdoost <[email protected]>--- drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vmwgfx/vmwgfx_context.c +0
-0
drivers/gpu/drm/vmwgfx/vmwgfx_context.c static int vmw_context_define(struct drm_device *dev, void *data, · line 779
Quoted 8 lines
drivers/gpu/drm/vmwgfx/vmwgfx_context.c +1
-1@@ -773,7 +773,7 @@ static int vmw_context_define(struct drm_device *dev, void *data, ret =vmw_context_init (dev_priv, res, vmw_user_context_free, dx);if (unlikely (ret !=0 )) - goto out_unlock; + goto out_err; tmp =vmw_resource_reference (&ctx->res); ret = ttm_base_object_init(tfile, &ctx->base, false, VMW_RES_CONTEXT,
This patch doesn't look correct. vmw_context_init should free up all resources if failing.
Thanks,
Thomas
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel