Skip to contentSkip to conversation

armv7: ls102xa: add errata ID A-008646 for workaround

PATCH New Biwen Li 2 participants 4 messages Sep 25, 2019 – Oct 22, 2019 Arm (32-bit)

lore
Share & tools
lore

Biwen Li

author
#0 lore raw

PATCH v3 1/2 armv7: ls102xa: add errata ID A-008646 for workaround

The patch adds an errata ID A-008646 for workaround to provide more information by ID.

---
Change in v3:
- adjust code style

Change in v2:
- update subject and description

 arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +4 -3
index bb169aaaf4..afa4fd7a48 100644
@@ -68,9 +68,10 @@ static void __secure ls1_deepsleep_irq_cfg(void)
 
 	ippdexpcr0 = in_be32(&rcpm->ippdexpcr0);
 	/*
-	 * Workaround: There is bug of register ippdexpcr1, when read it always
-	 * returns zero, so its value is saved to a scrachpad register to be
-	 * read, that is why we don't read it from register ippdexpcr1 itself.
+	 * Workaround of errata A-008646: There is bug of register ippdexpcr1,
+	 * when read it always returns zero, so its value is saved to a
+	 * scrachpad register to be read, that is why we don't read it from
+	 * register ippdexpcr1 itself.
 	 */
 	ippdexpcr1 = in_le32(&scfg->sparecr[7]);
 	out_be32(&rcpm->ippdexpcr1, ippdexpcr1);
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v3 2/2 armv7: ls102xa: Don't power down OCRAM1 during deep sleep

Don't power down OCRAM1 for wakeup source
to wakeup system in deep sleep

---
Change in v3:
- update subject and description

Change in v2:
- split one patch to two patches
- always not power down OCRAM1

 arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +2 -1
index afa4fd7a48..3df5a1141a 100644
@@ -74,7 +74,8 @@ static void __secure ls1_deepsleep_irq_cfg(void)
 	 * register ippdexpcr1 itself.
 	 */
 	ippdexpcr1 = in_le32(&scfg->sparecr[7]);
-	out_be32(&rcpm->ippdexpcr1, ippdexpcr1);
+	/* Always not power down OCRAM1 */
+	out_be32(&rcpm->ippdexpcr1, ippdexpcr1 | RCPM_IPPDEXPCR1_OCRAM1);
 
 	if (ippdexpcr0 & RCPM_IPPDEXPCR0_ETSEC)
 		pmcintecr |= SCFG_PMCINTECR_ETSECRXG0 |
Signature · 1 line
2.17.1
#2 lore raw

PATCH v3 2/2 armv7: ls102xa: Don't power down OCRAM1 during deep sleep

Quoted 44 lines

-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Wednesday, September 25, 2019 4:11 PM
To: albert.u.boot at aribaud.net; Prabhakar X <[email protected]>; Rajesh Bhagat <[email protected]>; Priyanka Jain <[email protected]>; Ran Wang <[email protected]>; Leo Li <[email protected]>; Jagdish Gediya <[email protected]>
Cc: u-boot at lists.denx.de; Biwen Li <[email protected]>
Subject: [v3,2/2] armv7: ls102xa: Don't power down OCRAM1 during deep sleep

Don't power down OCRAM1 for wakeup source to wakeup system in deep sleep

---
Change in v3:
- update subject and description

Change in v2:
- split one patch to two patches
- always not power down OCRAM1

arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +2 -1
index afa4fd7a48..3df5a1141a 100644
@@ -74,7 +74,8 @@ static void __secure ls1_deepsleep_irq_cfg(void)
 	 * register ippdexpcr1 itself.
 	 */
 	ippdexpcr1 = in_le32(&scfg->sparecr[7]);
-	out_be32(&rcpm->ippdexpcr1, ippdexpcr1);
+	/* Always not power down OCRAM1 */
+	out_be32(&rcpm->ippdexpcr1, ippdexpcr1 |
 RCPM_IPPDEXPCR1_OCRAM1);
 
 	if (ippdexpcr0 & RCPM_IPPDEXPCR0_ETSEC)
		pmcintecr |= SCFG_PMCINTECR_ETSECRXG0 |
Quoted 2 lines

--
2.17.1

Updated description and comment in code.
Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain

#3 lore raw

PATCH v3 1/2 armv7: ls102xa: add errata ID A-008646 for workaround

In reply to Biwen Li
Quoted 47 lines

-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Wednesday, September 25, 2019 4:11 PM
To: albert.u.boot at aribaud.net; Prabhakar X <[email protected]>; Rajesh Bhagat <[email protected]>; Priyanka Jain <[email protected]>; Ran Wang <[email protected]>; Leo Li <[email protected]>; Jagdish Gediya <[email protected]>
Cc: u-boot at lists.denx.de; Biwen Li <[email protected]>
Subject: [v3,1/2] armv7: ls102xa: add errata ID A-008646 for workaround

The patch adds an errata ID A-008646 for workaround to provide more information by ID.

---
Change in v3:
- adjust code style

Change in v2:
- update subject and description

arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c | 7 ++++---

1 file changed, 4 insertions(+), 3 deletions(-)
arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +0 -1
index bb169aaaf4..afa4fd7a48 100644
@@ -68,9 +68,10 @@ static void __secure ls1_deepsleep_irq_cfg(void)
 
 	ippdexpcr0 = in_be32(&rcpm->ippdexpcr0);
 	/*
-	 * Workaround: There is bug of register ippdexpcr1, when read it

always

arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +1 -2
-	 * returns zero, so its value is saved to a scrachpad register to be
-	 * read, that is why we don't read it from register ippdexpcr1 itself.
+	 * Workaround of errata A-008646: There is bug of register

ippdexpcr1,

arch/arm/cpu/armv7/ls102xa/ls102xa_psci.c +3 -0
+	 * when read it always returns zero, so its value is saved to a
+	 * scrachpad register to be read, that is why we don't read it from
+	 * register ippdexpcr1 itself.
	 */
	ippdexpcr1 = in_le32(&scfg->sparecr[7]);
	out_be32(&rcpm->ippdexpcr1, ippdexpcr1);
Quoted 2 lines

--
2.17.1

Added errata word in description.
Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain