Skip to contentSkip to conversation

of: mdio: Fix a signedness bug in of_phy_get_and_connect()

PATCH Applied Dan Carpenter 2 participants 2 messages Sep 25, 2019 – Sep 27, 2019

Subsystems (4)
Networking Network drivers Kernel janitors Device tree
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 of: mdio: Fix a signedness bug in of_phy_get_and_connect()

The "iface" variable is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered.

Fixes b78624125304 ("of_mdio: Abstract a general interface for phy connect")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/of/of_mdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/of/of_mdio.c +1 -1
index 000b95787df1..bd6129db6417 100644
@@ -362,7 +362,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev,
 	int ret;
 
 	iface = of_get_phy_mode(np);
-	if (iface < 0)
+	if ((int)iface < 0)
 		return NULL;
 	if (of_phy_is_fixed_link(np)) {
 		ret = of_phy_register_fixed_link(np);
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 25 Sep 2019 14:01:00 +0300

Quoted 5 lines

The "iface" variable is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered.

Fixes b78624125304 ("of_mdio: Abstract a general interface for phy connect")
Signed-off-by Dan Carpenter <[email protected]>

Applied.