package/libssh: add option to enable server support
PATCH 1/1 package/libssh: add option to enable server support
From: Heiko Thiery <[email protected]>
This patch adds Config.in option for ssh server support.
--- package/libssh/Config.in | 9 +++++++++ package/libssh/libssh.mk | 7 ++++++- 2 files changed, 15 insertions(+), 1 deletion(-)
package/libssh/Config.in +9 -0
@@ -13,6 +13,15 @@ config BR2_PACKAGE_LIBSSH http://www.libssh.org/ +if BR2_PACKAGE_LIBSSH + +config BR2_PACKAGE_LIBSSH_SERVER + bool "server" + help + Enable libssh server support + +endif + comment "libssh needs a toolchain w/ dynamic library, threads" depends on BR2_USE_MMU depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
package/libssh/libssh.mk +6 -1
@@ -14,12 +14,17 @@ LIBSSH_INSTALL_STAGING = YES LIBSSH_SUPPORTS_IN_SOURCE_BUILD = NO LIBSSH_CONF_OPTS = \ -DWITH_STACK_PROTECTOR=OFF \ - -DWITH_SERVER=OFF \ -DWITH_EXAMPLES=OFF # cmake older than 3.10 require this to avoid try_run() in FindThreads LIBSSH_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF +ifeq ($(BR2_PACKAGE_LIBSSH_SERVER),y) + LIBSSH_CONF_OPTS += -DWITH_SERVER=ON +else + LIBSSH_CONF_OPTS += -DWITH_SERVER=OFF +endif + ifeq ($(BR2_PACKAGE_ZLIB),y) LIBSSH_CONF_OPTS += -DWITH_ZLIB=ON LIBSSH_DEPENDENCIES += zlib
Signature · 1 line
2.20.1
PATCH 1/1 package/libssh: add option to enable server support
Hello,
Thanks for your contribution!
package/libssh/libssh.mk LIBSSH_INSTALL_STAGING = YES · line 25
Quoted 4 lines · On Wed, 25 Sep 2019 14:17:26 +0200 heiko.thiery at gmail.com wrote:
package/libssh/libssh.mk +4
-0+ifeq ($(BR2_PACKAGE_LIBSSH_SERVER),y) + LIBSSH_CONF_OPTS += -DWITH_SERVER=ON +else + LIBSSH_CONF_OPTS += -DWITH_SERVER=OFF
We don't indent such lines in our coding style, as can be seen in the rest of the file. I have fixed this and applied your patch to Buildroot master branch.
Just curious, what is the use case for the server support in libssh ? The INSTALL file is not very clear about what WITH_SERVER=ON provides.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/libssh: add option to enable server support
Hi Thomas,
We don't indent such lines in our coding style, as can be seen in the
Quoted 3 lines
rest of the file. I have fixed this and applied your patch to Buildroot master branch.
Ok .. thank you.
Quoted 3 lines
Just curious, what is the use case for the server support in libssh ? The INSTALL file is not very clear about what WITH_SERVER=ON provides.
I need this option for a netconf server implementation (netopeer2). I will prepare a patchset to bring also these packages.
--
Heiko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190928/d6694a28/attachment.html>