Skip to contentSkip to conversation

docs: fix memory.low description in cgroup-v2.rst

PATCH Applied Jon Haslam 3 participants 3 messages Sep 25, 2019 – Oct 1, 2019

Subsystems (2)
lore
Share & tools
lore

Jon Haslam

author
#0 lore raw

PATCH 1/1 docs: fix memory.low description in cgroup-v2.rst

The current cgroup-v2.rst file contains an incorrect description of when memory is reclaimed from a cgroup that is using the 'memory.low' mechanism. This fix simply corrects the text to reflect the actual implementation.

Fixes 7854207fe954 ("mm/docs: describe memory.low refinements")
---
 Documentation/admin-guide/cgroup-v2.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +3 -3
index 0fa8c0e615c2..26d1cde6b34a 100644
@@ -1117,8 +1117,8 @@ PAGE_SIZE multiple when read back.
 
 	Best-effort memory protection.  If the memory usage of a
 	cgroup is within its effective low boundary, the cgroup's
-	memory won't be reclaimed unless memory can be reclaimed
-	from unprotected cgroups.
+	memory won't be reclaimed unless there is no reclaimable
+	memory available in unprotected cgroups.
 
 	Effective low boundary is limited by memory.low values of
 	all ancestor cgroups. If there is memory.low overcommitment
@@ -1914,7 +1914,7 @@ Cpuset Interface Files
 
         It accepts only the following input values when written to.
 
-        "root"   - a paritition root
+        "root"   - a partition root
         "member" - a non-root member of a partition
 
 	When set to be a partition root, the current cgroup is the
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jon Haslam

The current cgroup-v2.rst file contains an incorrect description of when memory is reclaimed from a cgroup that is using the 'memory.low' mechanism. This fix simply corrects the text to reflect the actual implementation.

Fixes 7854207fe954 ("mm/docs: describe memory.low refinements")

Thanks, Jon!

Quoted 31 lines
---
 Documentation/admin-guide/cgroup-v2.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/admin-guide/cgroup-v2.rst +3 -3
index 0fa8c0e615c2..26d1cde6b34a 100644
@@ -1117,8 +1117,8 @@ PAGE_SIZE multiple when read back.
 
 	Best-effort memory protection.  If the memory usage of a
 	cgroup is within its effective low boundary, the cgroup's
-	memory won't be reclaimed unless memory can be reclaimed
-	from unprotected cgroups.
+	memory won't be reclaimed unless there is no reclaimable
+	memory available in unprotected cgroups.
 
 	Effective low boundary is limited by memory.low values of
 	all ancestor cgroups. If there is memory.low overcommitment
@@ -1914,7 +1914,7 @@ Cpuset Interface Files
 
         It accepts only the following input values when written to.
 
-        "root"   - a paritition root
+        "root"   - a partition root
         "member" - a non-root member of a partition
 
 	When set to be a partition root, the current cgroup is the
Signature · 1 line
2.17.1
maintainer Applied
#2 lore raw
In reply to Jon Haslam
Quoted 7 lines · On Wed, 25 Sep 2019 12:56:04 -0700 Jon Haslam <[email protected]> wrote:

The current cgroup-v2.rst file contains an incorrect description of when memory is reclaimed from a cgroup that is using the 'memory.low' mechanism. This fix simply corrects the text to reflect the actual implementation.

Fixes 7854207fe954 ("mm/docs: describe memory.low refinements")

Applied, thanks.

jon